Merge "Refactor "Open language selector when logged in""

tests/browser/features/step_definitions/common_steps.rb

@@ -25,12 +25,3 @@ Then(/^my interface language is "(.*?)"$/) do |language|
 	code = on(PanelPage).language_to_code(language)
 	on(PanelPage).interface_element.attribute('lang').should == code
 end
-
-def uls_position()
-	if !defined?($uls_position)
-		visit(PanelPage)
-		$uls_position = @browser.execute_script( "return mw.config.get( 'wgULSPosition' )" );
-	else
-		$uls_position
-	end
-end

tests/browser/features/step_definitions/triggers_steps.rb

@@ -1,7 +1,10 @@
 When(/^I click language selector trigger element$/) do
-	on(RandomPage).uls_trigger
+	on(PanelPage).trigger_personal
 end
 
 Then(/^I should see the language selector$/) do
-	on(PanelPage).uls_element.should be_visible
+	on(PanelPage) do |page|
+		page.uls_element.should be_visible
+		page.uls_onscreen?.should be_true
+	end
 end