Prefer double-quoted strings in Ruby code

Bug: 57597
Change-Id: I12b96411abe255130e156e20fa41eef558460196
This commit is contained in:
mayankmadan
2013-11-27 01:21:33 +05:30
committed by Nikerabbit
parent bbeb82f809
commit 78152b95c0
23 changed files with 138 additions and 138 deletions

View File

@@ -1,2 +1,2 @@
require_relative 'hooks'
require 'mediawiki/selenium'
require_relative "hooks"
require "mediawiki/selenium"

View File

@@ -1,8 +1,8 @@
Before('@language') do |scenario|
Before("@language") do |scenario|
@language = true
@scenario = scenario
end
After('@reset-preferences-after') do |scenario|
After("@reset-preferences-after") do |scenario|
visit(ResetPreferencesPage).submit_element.click if @browser.exist?
end

View File

@@ -4,20 +4,20 @@ require "page-object"
module InterlanguagePageModule
include PageObject
a(:add_links, id: 'wbc-linkToItem-link')
a(:back_to_display, text: 'Back to display settings')
a(:back_to_input, text: 'Back to input settings')
span(:cog, class: 'uls-settings-trigger')
button(:ellipsis_button, class: 'uls-more-languages button')
a(:english_link, text: 'English')
a(:hindi_link, text: 'हिन्दी')
div(:input_settings, id: 'input-settings-block')
div(:language_list, class: 'row uls-language-list lcd')
text_field(:language_search, id: 'languagefilter')
button(:non_default_language, class: 'button uls-language-button', index: 1)
a(:talk, text: 'Discussion')
span(:x, id: 'languagesettings-close')
a(:how_to_use_ml_transliteration, href: 'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration')
a(:edit_link, css: '#ca-edit a')
a(:interlang_link, css: '#p-lang li.interlanguage-link')
a(:add_links, id: "wbc-linkToItem-link")
a(:back_to_display, text: "Back to display settings")
a(:back_to_input, text: "Back to input settings")
span(:cog, class: "uls-settings-trigger")
button(:ellipsis_button, class: "uls-more-languages button")
a(:english_link, text: "English")
a(:hindi_link, text: "हिन्दी")
div(:input_settings, id: "input-settings-block")
div(:language_list, class: "row uls-language-list lcd")
text_field(:language_search, id: "languagefilter")
button(:non_default_language, class: "button uls-language-button", index: 1)
a(:talk, text: "Discussion")
span(:x, id: "languagesettings-close")
a(:how_to_use_ml_transliteration, href: "https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration")
a(:edit_link, css: "#ca-edit a")
a(:interlang_link, css: "#p-lang ul")
end

View File

@@ -3,16 +3,16 @@ module LanguageModule
def language_to_code(language)
case language
when 'German'
'de'
when 'English'
'en'
when 'Finnish'
'fi'
when 'Hebrew'
'he'
when 'Hindi'
'hi'
when "German"
"de"
when "English"
"en"
when "Finnish"
"fi"
when "Hebrew"
"he"
when "Hindi"
"hi"
else
pending
end

View File

@@ -1,9 +1,9 @@
module URL
def self.url(name)
if ENV['MEDIAWIKI_URL']
mediawiki_url = ENV['MEDIAWIKI_URL']
if ENV["MEDIAWIKI_URL"]
mediawiki_url = ENV["MEDIAWIKI_URL"]
else
mediawiki_url = 'http://en.wikipedia.beta.wmflabs.org/wiki/'
mediawiki_url = "http://en.wikipedia.beta.wmflabs.org/wiki/"
end
"#{mediawiki_url}#{name}"
end

View File

@@ -1,5 +1,5 @@
class EditPage
include PageObject
textarea(:editarea, id: 'wpTextbox1')
textarea(:editarea, id: "wpTextbox1")
end

View File

@@ -3,17 +3,17 @@ class IMEPage
include LanguageModule
include URL
page_url URL.url('?<%=params[:extra]%>')
page_url URL.url("?<%=params[:extra]%>")
div(:input_method, class: 'imeselector imeselector-toggle')
a(:input_method_enabled, class: 'ime-name imeselector-toggle')
h3(:input_method_ime_list_title, class: 'ime-list-title')
ul(:input_method_language_list, class: 'ime-language-list')
div(:input_method_selector_menu, class: 'imeselector-menu')
text_field(:language_filter, id: 'languagefilter')
li(:malayalam_inscript2, data_ime_inputmethod: 'ml-inscript2')
a(:more_languages, class: 'ime-selector-more-languages')
text_field(:search_input, id: 'searchInput')
div(:input_method, class: "imeselector imeselector-toggle")
a(:input_method_enabled, class: "ime-name imeselector-toggle")
h3(:input_method_ime_list_title, class: "ime-list-title")
ul(:input_method_language_list, class: "ime-language-list")
div(:input_method_selector_menu, class: "imeselector-menu")
text_field(:language_filter, id: "languagefilter")
li(:malayalam_inscript2, data_ime_inputmethod: "ml-inscript2")
a(:more_languages, class: "ime-selector-more-languages")
text_field(:search_input, id: "searchInput")
def ime_input_method_menu_onscreen?
@browser.execute_script( "

View File

@@ -4,7 +4,7 @@ class InterlanguagePage
include URL
def self.url
URL.url('Boleyn_family')
URL.url("Boleyn_family")
end
page_url url

View File

@@ -2,18 +2,18 @@ class LoginPage
include PageObject
include URL
page_url URL.url('Special:UserLogin')
page_url URL.url("Special:UserLogin")
div(:feedback, class: 'errorbox')
button(:login, id: 'wpLoginAttempt')
text_field(:password, id: 'wpPassword1')
a(:password_strength, text: 'password strength')
a(:phishing, text: 'phishing')
text_field(:username, id: 'wpName1')
div(:feedback, class: "errorbox")
button(:login, id: "wpLoginAttempt")
text_field(:password, id: "wpPassword1")
a(:password_strength, text: "password strength")
a(:phishing, text: "phishing")
text_field(:username, id: "wpName1")
a(:username_displayed, title: /Your user page/)
def logged_in_as_element
@browser.div(id: 'mw-content-text').p.b
@browser.div(id: "mw-content-text").p.b
end
def login_with(username, password)
self.username = username

View File

@@ -2,10 +2,10 @@ class MainPage
include PageObject
include URL
page_url URL.url('Main_Page')
page_url URL.url("Main_Page")
def non_interlanguage_links_use_autonym_font?
@browser.elements(css: '#p-lang li:not(.interlanguage-link)').collect do |element|
@browser.elements(css: "#p-lang li:not(.interlanguage-link)").collect do |element|
element.style("font-family")
end.to_s.match(/Autonym/) != nil
end

View File

@@ -3,7 +3,7 @@ class NoInterlanguagePage
include URL
def self.url
URL.url('Think_Like_a_Cat')
URL.url("Think_Like_a_Cat")
end
page_url url

View File

@@ -3,58 +3,58 @@ class PanelPage
include LanguageModule
include URL
page_url URL.url('?<%=params[:extra]%>')
page_url URL.url("?<%=params[:extra]%>")
div(:uls, class: 'uls-menu')
span(:uls_button_close, id: 'uls-close')
div(:uls, class: "uls-menu")
span(:uls_button_close, id: "uls-close")
div(:language_settings_dialog, id: 'language-settings-dialog')
div(:panel_display, id: 'display-settings-block')
div(:panel_input, id: 'input-settings-block')
button(:panel_fonts, id: 'uls-display-settings-fonts-tab')
button(:panel_language, id: 'uls-display-settings-language-tab')
div(:language_settings_dialog, id: "language-settings-dialog")
div(:panel_display, id: "display-settings-block")
div(:panel_input, id: "input-settings-block")
button(:panel_fonts, id: "uls-display-settings-fonts-tab")
button(:panel_language, id: "uls-display-settings-language-tab")
div(:panel_side_display, id: 'display-panel-trigger')
div(:panel_side_input, id: 'input-panel-trigger')
div(:panel_side_display, id: "display-panel-trigger")
div(:panel_side_input, id: "input-panel-trigger")
ul(:autonym, class: 'three columns end')
ul(:autonym, class: "three columns end")
span(:panel_button_close, id: 'languagesettings-close')
button(:panel_button_apply, class: 'uls-settings-apply')
button(:panel_button_cancel, class: 'uls-settings-cancel')
span(:panel_button_close, id: "languagesettings-close")
button(:panel_button_apply, class: "uls-settings-apply")
button(:panel_button_cancel, class: "uls-settings-cancel")
button(:panel_disable_input_methods, class: 'uls-input-toggle-button')
button(:panel_enable_input_methods, class: 'uls-input-toggle-button')
button(:panel_disable_input_methods, class: "uls-input-toggle-button")
button(:panel_enable_input_methods, class: "uls-input-toggle-button")
select_list(:panel_content_font_selector, id: 'content-font-selector')
select_list(:panel_interface_font_selector, id: 'ui-font-selector')
select_list(:panel_content_font_selector, id: "content-font-selector")
select_list(:panel_interface_font_selector, id: "ui-font-selector")
# TODO: Rename to match convention
button(:other_language_button, class: 'button uls-language-button', index: 1)
button(:default_language_button, css: '.uls-language-button.down')
button(:other_language_button, class: "button uls-language-button", index: 1)
button(:default_language_button, css: ".uls-language-button.down")
# Triggers
span(:trigger_cog, class: 'uls-settings-trigger')
a(:trigger_personal, class: 'uls-trigger')
span(:trigger_cog, class: "uls-settings-trigger")
a(:trigger_personal, class: "uls-trigger")
select(:selected_content_font, id: 'content-font-selector')
select(:selected_interface_font, id: 'ui-font-selector')
select(:selected_content_font, id: "content-font-selector")
select(:selected_interface_font, id: "ui-font-selector")
select(:font_for_content, id: 'content-font-selector')
select(:font_for_content, id: "content-font-selector")
div(:uls_display_settings, class: 'uls-display-settings')
div(:uls_display_settings, class: "uls-display-settings")
radio_button(:ml_inscript2_radio, id: 'ml-inscript2')
radio_button(:ml_inscript2_radio, id: "ml-inscript2")
# Is there way to access the html element?
div(:interface, id: 'footer')
div(:interface, id: "footer")
def content_font
font('#mw-content-text')
font("#mw-content-text")
end
def interface_font
font('body')
font("body")
end
def uls_onscreen?

View File

@@ -2,11 +2,11 @@ class PreferencesPage
include PageObject
include URL
page_url URL.url('Special:Preferences')
page_url URL.url("Special:Preferences")
select(:set_interface_language, id: 'mw-input-wplanguage')
button(:save, id: 'prefcontrol')
select(:set_interface_language, id: "mw-input-wplanguage")
button(:save, id: "prefcontrol")
a(:editing_tab, id: 'preftab-editing')
select(:editing_font, id: 'mw-input-wpeditfont')
a(:editing_tab, id: "preftab-editing")
select(:editing_font, id: "mw-input-wpeditfont")
end

View File

@@ -4,15 +4,15 @@ class RandomPage
include PageObject
include URL
page_url URL.url('Special:Random')
page_url URL.url("Special:Random")
span(:cog, title: 'Language settings')
a(:create_a_book, text: 'Create a book')
a(:download_as_pdf, text: 'Download as PDF')
a(:download_the_file, text: 'Download the file')
li(:main_page, id: 'n-mainpage-description')
a(:malayalam_link, title: 'Malayalam')
a(:print_export, text: 'Print/export')
a(:printable_version, text: 'Printable version')
button(:search_button, id: 'searchButton')
span(:cog, title: "Language settings")
a(:create_a_book, text: "Create a book")
a(:download_as_pdf, text: "Download as PDF")
a(:download_the_file, text: "Download the file")
li(:main_page, id: "n-mainpage-description")
a(:malayalam_link, title: "Malayalam")
a(:print_export, text: "Print/export")
a(:printable_version, text: "Printable version")
button(:search_button, id: "searchButton")
end

View File

@@ -1,7 +1,7 @@
class ResetPreferencesPage
include PageObject
include URL
page_url URL.url('Special:Preferences/reset')
page_url URL.url("Special:Preferences/reset")
button(:submit, class: 'mw-htmlform-submit')
button(:submit, class: "mw-htmlform-submit")
end