bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid jquery filter for the region div for each language

Browse Source 
Keep it in an object and reuse.

Change-Id: I1a367132e9b99b4fc6b2b8ff4023f638e6bc183f
This commit is contained in:
Santhosh Thottingal
2012-08-21 17:56:22 +05:30
parent 5760df80d3
commit 79139e650d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/jquery.uls/src/jquery.uls.lcd.js
View File

@@ -26,6 +26,7 @@
this.$element = $( element ); this.$element = $( element );
this.options = $.extend( {}, $.fn.lcd.defaults, options ); this.options = $.extend( {}, $.fn.lcd.defaults, options );
this.$element.addClass( 'lcd' ); this.$element.addClass( 'lcd' );
this.regionDivs = {};
this.show(); this.show();
this.listen(); this.listen();
}; };
@@ -93,9 +94,9 @@
var $divRegionCode, $rowDiv, $ul; var $divRegionCode, $rowDiv, $ul;
forceNew = forceNew || false; forceNew = forceNew || false;
$divRegionCode = this.$element.find( 'div#' + regionCode ); $divRegionCode = this.regionDivs[regionCode];
$rowDiv = $divRegionCode.find( 'div.row:last' ); $rowDiv = $divRegionCode.find( 'div.row:last' );
$ul = $divRegionCode.find( 'ul:last' ); $ul = $rowDiv.find( 'ul:last' );
// Each column can have maximum 8 languages. // Each column can have maximum 8 languages.
if ( $ul.length === 0 || $ul.find( 'li' ).length >= 8 || forceNew ) { if ( $ul.length === 0 || $ul.find( 'li' ).length >= 8 || forceNew ) {
@@ -124,6 +125,7 @@
$section.append( $( '<h3>' ).addClass( 'eleven columns uls-lcd-region-section offset-by-one' ).html( regionCode ) ); $section.append( $( '<h3>' ).addClass( 'eleven columns uls-lcd-region-section offset-by-one' ).html( regionCode ) );
// FIXME this is regioncode(NA, EU etc). Should be proper localized region name. // FIXME this is regioncode(NA, EU etc). Should be proper localized region name.
that.$element.append( $section ); that.$element.append( $section );
that.regionDivs[regionCode] = $section;
} ); } );
}, },