From 791cefeec65c0b939bec5b0284dc319a45b75f45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Laxstr=C3=B6m?= Date: Mon, 30 May 2016 17:07:22 +0200 Subject: [PATCH] Remove redundant mw.loader.using The only caller is already loading the exact same modules right before calling these functions. Change-Id: I71bc682f88c45e8ff20e032c7e5ee2dc3f517baf --- resources/js/ext.uls.interface.js | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 65499feb..3802d02b 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -107,10 +107,7 @@ }; } $.extend( displaySettingsOptions, uls.position() ); - mw.loader.using( mw.uls.languageSettingsModules, function () { - $displaySettings.languagesettings( displaySettingsOptions ) - .click(); - } ); + $displaySettings.languagesettings( displaySettingsOptions ).click(); } mw.hook( 'mw.uls.settings.open' ).fire( 'uls' ); uls.hide(); @@ -131,16 +128,14 @@ languagesettings = $inputSettings.data( 'languagesettings' ); if ( !languagesettings ) { - mw.loader.using( mw.uls.languageSettingsModules, function () { - $inputSettings.languagesettings( { - defaultModule: 'input', - onClose: function () { - uls.show(); - }, - top: position.top, - left: position.left - } ).click(); - } ); + $inputSettings.languagesettings( { + defaultModule: 'input', + onClose: function () { + uls.show(); + }, + top: position.top, + left: position.left + } ).click(); } mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );