bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Validate the dirty flag before saving preferences in each modules

Browse Source 
Pressing apply button is applicable to all settings module, not only
for the one that is visible. Unless we do a validation before we save
preferences, other module can cause incorrect (old) preferences to be
saved.

Bug: 56885
Change-Id: I31df2ee0bf8b600a94e8fed1a784daf529186b16
This commit is contained in:
Santhosh Thottingal
2013-11-12 14:33:35 +05:30
committed by Nikerabbit
parent 037984a67f
commit 8b3d27a505
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
resources/js/ext.uls.displaysettings.js
View File

@@ -569,10 +569,18 @@
},
/**
* Handle the apply button press
* Handle the apply button press.
* Note that the button press may not be from the input settings module.
* For example, a user can change input settings and then go to display settings panel,
* do some changes and press apply button there. That press is applicable for all
* modules.
*/
apply: function () {
var displaySettings = this;
if ( !displaySettings.dirty ) {
// No changes to save in this module.
return;
}
// Save the preferences
mw.webfonts.preferences.save( function ( result ) {

11
resources/js/ext.uls.inputsettings.js
View File

@@ -500,7 +500,11 @@
},
/**
* Handle the apply button press
* Handle the apply button press.
* Note that the button press may not be from the input settings module.
* For example, a user can change input settings and then go to display settings panel,
* do some changes and press apply button there. That press is applicable for all
* modules.
*/
apply: function () {
var previousIM,
@@ -510,6 +514,11 @@
currentLanguage = $.ime.preferences.getLanguage(),
currentIM = $.ime.preferences.getIM( currentLanguage );
if ( !inputSettings.dirty ) {
// No changes to save in this module.
return;
}
if ( previousLanguage ) {
previousIM = inputSettings.savedRegistry.imes[previousLanguage];
}