Update jquery.uls from upstream

* Update linters

Updating to
d53beca719

Change-Id: Ia7886a13fc17e27344280449d0377e0fa5d0d9f5
This commit is contained in:
Amir Aharoni
2019-11-21 11:33:28 +02:00
parent f6e5d24941
commit 95912d438c
5 changed files with 30 additions and 24 deletions

View File

@@ -17,7 +17,13 @@
padding: 0 16px; padding: 0 16px;
} }
.uls-lcd--no-quicklist [data-region="all"] .uls-lcd-region-title { .uls-lcd-region-title {
color: #555;
font-size: 14px;
padding-left: 28px;
}
.uls-lcd--no-quicklist [ data-region='all' ] .uls-lcd-region-title {
display: none; display: none;
} }
@@ -25,12 +31,6 @@
margin-top: 10px; margin-top: 10px;
} }
.uls-lcd-region-title {
color: #555;
font-size: 14px;
padding-left: 28px;
}
/* /*
* We need to have this as a grid row to push rest of the content below it, but resetting * We need to have this as a grid row to push rest of the content below it, but resetting
* padding and margin so that calculating them for children is easier. * padding and margin so that calculating them for children is easier.

View File

@@ -1,5 +1,5 @@
/* stylelint-disable declaration-no-important */
@media only screen and ( max-width: 767px ) { @media only screen and ( max-width: 767px ) {
.uls-mobile.uls-menu { .uls-mobile.uls-menu {
width: 95%; width: 95%;
left: 2.5%; left: 2.5%;
@@ -248,6 +248,7 @@
.uls-mobile .hide-for-xlarge { .uls-mobile .hide-for-xlarge {
display: block !important; display: block !important;
} }
.uls-mobile .hide-for-small, .uls-mobile .hide-for-small,
.uls-mobile .show-for-medium, .uls-mobile .show-for-medium,
.uls-mobile .hide-for-medium-down, .uls-mobile .hide-for-medium-down,
@@ -274,6 +275,7 @@
.uls-mobile .hide-for-portrait { .uls-mobile .hide-for-portrait {
display: block !important; display: block !important;
} }
.uls-mobile .hide-for-landscape, .uls-mobile .hide-for-landscape,
.uls-mobile .show-for-portrait { .uls-mobile .show-for-portrait {
display: none !important; display: none !important;
@@ -285,6 +287,7 @@
.uls-mobile .hide-for-landscape { .uls-mobile .hide-for-landscape {
display: block !important; display: block !important;
} }
.uls-mobile .hide-for-portrait, .uls-mobile .hide-for-portrait,
.uls-mobile .show-for-landscape { .uls-mobile .show-for-landscape {
display: none !important; display: none !important;
@@ -297,6 +300,7 @@
display: none !important; display: none !important;
} }
/* stylelint-disable-next-line no-descending-specificity */
.uls-mobile .hide-for-touch, .uls-mobile .hide-for-touch,
.uls-mobile .touch .show-for-touch { .uls-mobile .touch .show-for-touch {
display: block !important; display: block !important;

View File

@@ -149,7 +149,7 @@
this.$menu.addClass( widthClasses[ this.menuWidth ] ); this.$menu.addClass( widthClasses[ this.menuWidth ] );
if ( !this.initialized ) { if ( !this.initialized ) {
$( 'body' ).prepend( this.$menu ); $( document.body ).prepend( this.$menu );
this.i18n(); this.i18n();
this.initialized = true; this.initialized = true;
} }
@@ -160,7 +160,7 @@
this.shown = true; this.shown = true;
if ( !this.isMobile() ) { if ( !this.isMobile() ) {
this.$languageFilter.focus(); this.$languageFilter.trigger( 'focus' );
} }
this.visible(); this.visible();
@@ -267,8 +267,8 @@
this.$languageFilter.on( 'resultsfound.uls', this.success.bind( this ) ); this.$languageFilter.on( 'resultsfound.uls', this.success.bind( this ) );
$( 'html' ).click( this.cancel.bind( this ) ); $( document.body ).on( 'click', this.cancel.bind( this ) );
$( window ).resize( $.fn.uls.debounce( this.resize.bind( this ), 250 ) ); $( window ).on( 'resize', $.fn.uls.debounce( this.resize.bind( this ), 250 ) );
}, },
resize: function () { resize: function () {
@@ -477,6 +477,7 @@
} else { } else {
scrollPosition = panelBottom - windowHeight; scrollPosition = panelBottom - windowHeight;
} }
// eslint-disable-next-line no-jquery/no-global-selector
$( 'html, body' ).stop().animate( { $( 'html, body' ).stop().animate( {
scrollTop: scrollPosition scrollTop: scrollPosition
}, 500 ); }, 500 );

View File

@@ -103,7 +103,7 @@
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
query = $.trim( this.$element.val() ).toLowerCase(); query = ( this.$element.val() || '' ).trim().toLowerCase();
if ( this.selectedLanguage ) { if ( this.selectedLanguage ) {
// this.selectLanguage will be populated from a matching search // this.selectLanguage will be populated from a matching search
@@ -126,7 +126,7 @@
this.$element.val( '' ); this.$element.val( '' );
if ( !$.fn.uls.Constructor.prototype.isMobile() ) { if ( !$.fn.uls.Constructor.prototype.isMobile() ) {
this.$element.focus(); this.$element.trigger( 'focus' );
} }
this.toggleClear(); this.toggleClear();
@@ -160,7 +160,7 @@
search: function () { search: function () {
var languages = Object.keys( this.options.languages ), var languages = Object.keys( this.options.languages ),
results = [], results = [],
query = $.trim( this.$element.val() ).toLowerCase(); query = ( this.$element.val() || '' ).trim().toLowerCase();
if ( query === '' ) { if ( query === '' ) {
this.options.lcd.setGroupByRegionOverride( null ); this.options.lcd.setGroupByRegionOverride( null );
@@ -189,6 +189,7 @@
var autofillLabel, var autofillLabel,
results = []; results = [];
// eslint-disable-next-line no-jquery/no-each-util
$.each( result.languagesearch, function ( apiCode, name ) { $.each( result.languagesearch, function ( apiCode, name ) {
var code, redirect; var code, redirect;

View File

@@ -57,7 +57,7 @@
this.$element.addClass( 'uls-lcd' ); this.$element.addClass( 'uls-lcd' );
this.regionLanguages = {}; this.regionLanguages = {};
this.renderTimeout = null; this.renderTimeout = null;
this.cachedQuicklist = null; this.$cachedQuicklist = null;
this.groupByRegionOverride = null; this.groupByRegionOverride = null;
this.render(); this.render();
@@ -327,17 +327,17 @@
buildQuicklist: function () { buildQuicklist: function () {
var quickList, $quickListSection, $quickListSectionTitle; var quickList, $quickListSection, $quickListSectionTitle;
if ( this.cachedQuicklist !== null ) { if ( this.$cachedQuicklist !== null ) {
return this.cachedQuicklist; return this.$cachedQuicklist;
} }
if ( $.isFunction( this.options.quickList ) ) { if ( typeof this.options.quickList === 'function' ) {
this.options.quickList = this.options.quickList(); this.options.quickList = this.options.quickList();
} }
if ( !this.options.quickList.length ) { if ( !this.options.quickList.length ) {
this.cachedQuicklist = $( [] ); this.$cachedQuicklist = $( [] );
return this.cachedQuicklist; return this.$cachedQuicklist;
} }
// Pick only the first elements, because we don't have room for more // Pick only the first elements, because we don't have room for more
@@ -363,8 +363,8 @@
$quickListSectionTitle.i18n(); $quickListSectionTitle.i18n();
this.cachedQuicklist = $quickListSection; this.$cachedQuicklist = $quickListSection;
return this.cachedQuicklist; return this.$cachedQuicklist;
}, },
show: function () { show: function () {
@@ -382,7 +382,7 @@
}, },
focus: function () { focus: function () {
this.$element.focus(); this.$element.trigger( 'focus' );
}, },
/** /**