From 9fc25cc862968dd730b14df0dedcb183c68f79f3 Mon Sep 17 00:00:00 2001 From: NikG Date: Tue, 12 Apr 2022 14:44:01 +0300 Subject: [PATCH] Require action menu items registry at the top of uls interface module "ext.uls.actions.menu.items.registry.js" should be required at the top of the "ext.uls.interface.js" file. The latter is the main file of the "ext.uls.interface" module, and it's the only one that is executed when the module is added as an external dependency. Since, the "mw.uls.ActionsMenuItemsRegistry" object is needed outside ULS extension (inside ContentTranslation), the corresponding file should be required at the top of the main file so that it's available. Bug: T289840 Change-Id: I70ced03c09b7907c6dbf2aa35a29d5fd14b790e6 --- resources/js/ext.uls.interface.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 1b7df873..9bab0c36 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -22,6 +22,8 @@ var languageSettingsModules = [ 'ext.uls.displaysettings' ], launchULS = require( './ext.uls.launch.js' ), ActionsMenu = require( './ext.uls.actions.menu.js' ); + require( './ext.uls.actions.menu.items.registry.js' ); + /** * Construct the display settings link * @@ -140,7 +142,6 @@ handler: openActionsMenuEventHandler }; - require( './ext.uls.actions.menu.items.registry.js' ); var actionItemsRegistry = mw.uls.ActionsMenuItemsRegistry; actionItemsRegistry.register( languageSettingsMenuItem ); // first hide #uls-settings-block div since it's unused, and it causes