From a6e0c10c54c3ad337c666aa34812c59fe3442283 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 15 Apr 2021 02:04:12 +0100 Subject: [PATCH] ext.uls.interface: remove unused "ulsPopup remove" code The ulsPopup variable is local to the showUndoTooltip() function. If it is called multiple times, then a previous assignment of an OO.ui.PopupWidget object would not be found here in subsequent calls. This check can only ever be false since it is the first statement in the function (after variable and function declarations, which don't do anything other than call `$()`). Change-Id: I7020c103428d01b5e48c65be695471401f588fc4 --- resources/js/ext.uls.interface.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index fad83150..71fae2f5 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -159,10 +159,6 @@ tipsyTimer = setTimeout( hideTipsy, timeout ); } - // remove any existing popups - if ( ulsPopup ) { - ulsPopup.$element.remove(); - } if ( ulsPosition === 'interlanguage' ) { if ( $ulsTrigger.offset().left > $( window ).width() / 2 ) { ulsPopupPosition = 'before';