From b086aebcc8fa2a49c49f8b88365bf5cec7ccdba4 Mon Sep 17 00:00:00 2001
From: thiemowmde <thiemo.kreuz@wikimedia.de>
Date: Thu, 4 Apr 2024 10:13:51 +0200
Subject: [PATCH] Avoid calling expensive ActionsMenuItemsRegistry.getItems

Change-Id: I6ba87ea91d1aca151882f96f4e164b07064bf040
---
 resources/js/ext.uls.interface.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js
index 870835c7..01e0e256 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -87,9 +87,7 @@
 		$emptyStateContainer.append( $header, $desc );
 		uls.$resultsView.append( $emptyStateContainer );
 
-		var actionItems = actionItemsRegistry.getItems();
-
-		if ( actionItems.length > 1 ) {
+		if ( actionItemsRegistry.size() > 1 ) {
 			// languageSettingsMenuItem will be always there.
 			// If other actions available, change text
 			$header.text( $.i18n( 'ext-uls-empty-state-header-actions-available' ) );
@@ -99,7 +97,7 @@
 		// Action menu items need OOUI widgets. Load them and register trigger event handler.
 		mw.loader.using( [ 'oojs-ui-widgets', 'oojs-ui.styles.icons-interactions' ] ).done( function () {
 			var $actionsList = $( '<ul>' ).addClass( 'uls-language-action-items' );
-			actionItems.forEach( function ( actionItem ) {
+			actionItemsRegistry.getItems().forEach( function ( actionItem ) {
 				var actionButton = new ActionsMenuItem(
 					actionItem.icon,
 					actionItem.text,
@@ -111,7 +109,6 @@
 
 			$emptyStateContainer.append( $actionsList );
 		} );
-
 	}
 
 	/**
@@ -185,7 +182,7 @@
 			} );
 		};
 
-		if ( actionItemsRegistry.getItems().length ) {
+		if ( actionItemsRegistry.size() ) {
 			prependAddLanguagesMenuButton();
 		}
 		function onActionItemAdded( itemName, item ) {