From b1563040ab03d8c5c245547d8342fe0f937bc2e2 Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Fri, 17 May 2013 09:43:29 +0530 Subject: [PATCH] Cog icon can be used to close the language settings panel Bug: 47971 Change-Id: I7b6d6142e113bf3f90feef1650bc384a5edc42cb --- resources/js/ext.uls.languagesettings.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index 7aced3f1..6e179546 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -65,7 +65,7 @@ listen: function () { var langSettings = this; // Register all event listeners to the ULS language settings here. - langSettings.$element.on( 'click', $.proxy( langSettings.show, langSettings ) ); + langSettings.$element.on( 'click', $.proxy( langSettings.click, langSettings ) ); langSettings.$window.find( '#languagesettings-close' ) .on( 'click', $.proxy( langSettings.close, langSettings ) ); @@ -219,7 +219,9 @@ }, click: function () { - if ( !this.shown ) { + if ( this.shown ) { + this.hide(); + } else { this.show(); } }