From b4f794f9fed47a770c6143e7272415008bd5af90 Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Mon, 30 Sep 2013 10:59:28 +0530 Subject: [PATCH] Reset language and font while preview If not reset, the font-family will persist for languages without font preferences Steps to reproduce: 1. Open language settings->Display settings. Switch language to English. Inspect the lang and font-family of uls-display-settings element. 2. Switch language to hi. Inspect the lang and font-family of uls-display-settings element. You can see Lohit Devanagari as font. 3. Switch the language back to English. You can still see font as Lohit Devanagari. With this patch, you should see font family reset for English. Change-Id: Ib3346d8b888c7dcfda16e8a10473c785a1ebd890 --- resources/js/ext.uls.displaysettings.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/js/ext.uls.displaysettings.js b/resources/js/ext.uls.displaysettings.js index d62cc6d1..5b282b3e 100644 --- a/resources/js/ext.uls.displaysettings.js +++ b/resources/js/ext.uls.displaysettings.js @@ -337,7 +337,9 @@ */ preview: function ( language ) { var displaySettings = this; - this.$template.attr( 'lang', language ); + // Reset the language and font for the panel. + this.$template.attr( 'lang', language ) + .css( 'font-family', '' ); $.i18n().locale = language; mw.uls.loadLocalization( language ).done( function () { displaySettings.i18n();