From b7e6aaa475ebac4d8b0fbbf96487f021981ec9fc Mon Sep 17 00:00:00 2001 From: Kartik Mistry Date: Tue, 1 Apr 2014 13:19:57 +0530 Subject: [PATCH] shellcheck fixes * Script: https://github.com/koalaman/shellcheck * Use $(..) instead of deprecated `..` * Use double quote to prevent globbing and word splitting. Change-Id: I68372d4e29ae34e0704e5a605447ad17bf0666d7 --- scripts/update-jquery-i18n.sh | 4 ++-- scripts/update-jquery-ime.sh | 4 ++-- scripts/update-jquery-uls.sh | 4 ++-- scripts/update-jquery-webfonts.sh | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/update-jquery-i18n.sh b/scripts/update-jquery-i18n.sh index 321e124b..537164be 100755 --- a/scripts/update-jquery-i18n.sh +++ b/scripts/update-jquery-i18n.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.i18n"; CLONEDIR="/tmp/jquery.i18n"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.i18n.git"; echo -e "Getting latest jquery.i18n from $UPSTREAM\n"; @@ -13,5 +13,5 @@ else git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/src/* $DEST diff --git a/scripts/update-jquery-ime.sh b/scripts/update-jquery-ime.sh index 1c01347d..bb5e8b2e 100755 --- a/scripts/update-jquery-ime.sh +++ b/scripts/update-jquery-ime.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.ime"; CLONEDIR="/tmp/jquery.ime"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.ime.git"; echo -e "Getting latest jquery.ime from $UPSTREAM\n"; @@ -16,5 +16,5 @@ fi cd $CLONEDIR; npm install; grunt copy concat; -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/dist/jquery.ime/{images,css,rules,jquery.ime.js} $DEST; diff --git a/scripts/update-jquery-uls.sh b/scripts/update-jquery-uls.sh index bf6282c0..8797d669 100755 --- a/scripts/update-jquery-uls.sh +++ b/scripts/update-jquery-uls.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.uls"; CLONEDIR="/tmp/jquery.uls"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.uls.git"; echo -e "Getting latest jquery.uls from $UPSTREAM\n"; @@ -13,5 +13,5 @@ else git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/{images,css,src,i18n} $DEST diff --git a/scripts/update-jquery-webfonts.sh b/scripts/update-jquery-webfonts.sh index c2c1e656..f2ff8115 100755 --- a/scripts/update-jquery-webfonts.sh +++ b/scripts/update-jquery-webfonts.sh @@ -2,7 +2,7 @@ DEST="../lib/"; CLONEDIR="/tmp/jquery.webfonts"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.webfonts.git"; echo -e "Getting latest jquery.webfonts from $UPSTREAM\n"; @@ -13,5 +13,5 @@ else git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/src/* $DEST