Merge "Simplify variables and clean up comments"

resources/js/ext.uls.preferences.js

@@ -27,8 +27,8 @@
 	/**
 	 * Post to options API with correct token.
 	 * If we have no token, get one and try to post.
-	 * If we have a cached token try using that, and if it fails, blank out the
+	 * If we have a cached token try using that,
-	 * cached token and start over.
+	 * and if it fails, blank out the cached token and start over.
 	 *
 	 * @param params {Object} API parameters
 	 * @param ok {Function} callback for success
@@ -36,21 +36,22 @@
 	 * @return {jqXHR}
 	 */
 	function saveOptionsWithToken( params, ok, err ) {
-		var useTokenToPost, getTokenIfBad;
 		if ( cachedOptionsToken === null ) {
 			// We don't have a valid cached token, so get a fresh one and try posting.
 			// We do not trap any 'badtoken' or 'notoken' errors, because we don't want
 			// an infinite loop. If this fresh token is bad, something else is very wrong.
-			useTokenToPost = function ( token ) {
+			return getOptionsToken( function ( token ) {
 				params.token = token;
 				new mw.Api().post( params, ok, err );
-			};
+			}, err );
-			return getOptionToken( useTokenToPost, err );
 		} else {
-			// We do have a token, but it might be expired. So if it is 'bad' then
-			// start over with a new token.
 			params.token = cachedOptionsToken;
-			getTokenIfBad = function ( code, result ) {
+
+			return new mw.Api().post( params, {
+				ok: ok,
+				err: function ( code, result ) {
+					// We do have a token, but it might be expired.
+					// So if it is 'bad', then start over with a new token.
 					if ( code === 'badtoken' ) {
 						// force a new token, clear any old one
 						cachedOptionsToken = null;
@@ -58,8 +59,8 @@
 					} else {
 						err( code, result );
 					}
-			};
+				}
-			return new mw.Api().post( params, { ok : ok, err : getTokenIfBad });
+			} );
 		}
 	}
 
@@ -75,13 +76,14 @@
 	 * @param err {Function} error callback
 	 * @return {jqXHR}
 	 */
-	function getOptionToken ( tokenCallback, err ) {
+	function getOptionsToken( tokenCallback, err ) {
-		var parameters = {
+		return new mw.Api().get( {
 			action: 'tokens',
 			type: 'options'
-			},
+		}, {
-			ok = function ( data ) {
+			ok: function ( data ) {
 				var token;
+
 				// If token type is not available for this user,
 				// key 'translationreviewtoken' is missing or can contain Boolean false
 				if ( data.tokens && data.tokens.optionstoken ) {
@@ -92,16 +94,12 @@
 					err( 'token-missing', data );
 				}
 			},
-			ajaxOptions = {
-				ok: ok,
 			err: err,
 			// Due to the API assuming we're logged out if we pass the callback-parameter,
 			// we have to disable jQuery's callback system, and instead parse JSON string,
 			// by setting 'jsonp' to false.
 			jsonp: false
-			};
+		} );
-
-		return new mw.Api().get( parameters, ajaxOptions );
 	}
 
 	ULSPreferences = function () {
@@ -155,11 +153,11 @@
 
 			callback = callback || $.noop;
 			if ( this.isAnon ) {
-				// Anonymous user- Save preferences in local storage
+				// Anonymous user. Save preferences in local storage
 				$.jStorage.set( this.preferenceName, this.preferences );
 				callback.call( this, true );
 			} else {
-				// Logged in user. Use MW apis to change preferences
+				// Logged in user. Use MW APIs to change preferences
 				saveOptionsWithToken( {
 					action: 'options',
 					optionname: ulsPreferences.preferenceName,