bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ResourceLoaderULSModule::getModifiedTime updates continuously

Browse Source 
Fix is simple: cache the hash of content per language

Added PHPUnit test for the same

Bug: 56856
Change-Id: I590b27af220d6e790c70728062d1a04c098b3d11
This commit is contained in:
Niklas Laxström
2013-11-11 09:04:59 +00:00
committed by Santhosh Thottingal
parent 6cd178359e
commit bd52ae0538
2 changed files with 75 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
includes/ResourceLoaderULSModule.php
View File

@@ -23,21 +23,19 @@
* Resource loader module for providing MediaWiki language names.
*/
class ResourceLoaderULSModule extends ResourceLoaderModule {
/**
* @var Language
*/
protected $language;
protected $targets = array( 'desktop', 'mobile' );
/**
* Get all the dynamic data for the content language to an array
* Get all the dynamic data for the content language to an array.
*
* @param string $languageCode Language code
* @return array
*/
protected function getData() {
protected function getData( $languageCode ) {
$vars = array();
$vars['wgULSLanguages'] = Language::fetchLanguageNames(
$this->language->getCode(), 'mwfile'
$languageCode,
'mwfile'
);
return $vars;
@@ -45,12 +43,12 @@ class ResourceLoaderULSModule extends ResourceLoaderModule {
/**
* @param $context ResourceLoaderContext
* @return string: JavaScript code
* @return string JavaScript code
*/
public function getScript( ResourceLoaderContext $context ) {
$this->language = Language::factory( $context->getLanguage() );
$languageCode = $context->getLanguage();
$out = '';
foreach ( $this->getData() as $key => $value ) {
foreach ( $this->getData( $languageCode ) as $key => $value ) {
$out .= Xml::encodeJsCall( 'mw.config.set', array( $key, $value ) );
}
@@ -58,15 +56,28 @@ class ResourceLoaderULSModule extends ResourceLoaderModule {
}
/**
* Gets the last modified time for this module depending on the given
* context.
*
* @param $context ResourceLoaderContext
* @return array|int|Mixed
* @return int Unix timestamp
*/
public function getModifiedTime( ResourceLoaderContext $context ) {
$this->language = Language::factory( $context->getLanguage() );
$cache = wfGetCache( CACHE_ANYTHING );
$key = wfMemcKey( 'resourceloader', 'ulsmodule', 'changeinfo' );
$languageCode = $context->getLanguage();
$data = $this->getData();
$cache = wfGetCache( CACHE_ANYTHING );
// Since we are updating the timestamp on hash change, we need to
// cache the hash per language to avoid updating the timestamp when
// different languages are being requested.
$key = wfMemcKey(
'resourceloader',
'modulemodifiedhash',
$this->getName(),
$languageCode
);
$data = $this->getData( $languageCode );
$hash = md5( serialize( $data ) );
$result = $cache->get( $key );