From c0804520135e3da7416b616691666dfbfe889f00 Mon Sep 17 00:00:00 2001
From: Ed Sanders <esanders@wikimedia.org>
Date: Wed, 13 Mar 2019 23:40:01 +0000
Subject: [PATCH] build: Update eslint-config-wikimedia to 0.11.0

Change-Id: Ic59891fab5f8e35420bddbed34072841883fa543
---
 .eslintrc.json                           | 3 +++
 .gitignore                               | 1 +
 Gruntfile.js                             | 4 ++++
 package.json                             | 4 ++--
 resources/js/ext.uls.compactlinks.js     | 2 +-
 resources/js/ext.uls.displaysettings.js  | 4 ++--
 resources/js/ext.uls.ime.js              | 6 +++---
 resources/js/ext.uls.inputsettings.js    | 7 ++++---
 resources/js/ext.uls.interface.js        | 8 ++++----
 resources/js/ext.uls.languagesettings.js | 8 ++++----
 resources/js/ext.uls.preferences.js      | 2 +-
 11 files changed, 29 insertions(+), 20 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 9c61cfda..0db901c6 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -10,5 +10,8 @@
 	"globals": {
 		"mw": false,
 		"OO": false
+	},
+	"rules": {
+		"no-jquery/no-global-selector": "off"
 	}
 }
diff --git a/.gitignore b/.gitignore
index 0a78e728..813fe4dc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,4 @@
 node_modules/
 composer.lock
 vendor/
+.eslintcache
diff --git a/Gruntfile.js b/Gruntfile.js
index 738cfaef..a3ed1f12 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -10,6 +10,10 @@ module.exports = function ( grunt ) {
 
 	grunt.initConfig( {
 		eslint: {
+			options: {
+				reportUnusedDisableDirectives: true,
+				cache: true
+			},
 			all: '.'
 		},
 		stylelint: {
diff --git a/package.json b/package.json
index dd6db1ea..35ad66dd 100644
--- a/package.json
+++ b/package.json
@@ -4,9 +4,9 @@
     "test": "grunt test"
   },
   "devDependencies": {
-    "eslint-config-wikimedia": "0.9.0",
+    "eslint-config-wikimedia": "0.11.0",
     "grunt": "1.0.3",
-    "grunt-banana-checker": "0.6.0",
+    "grunt-banana-checker": "0.7.0",
     "grunt-eslint": "21.0.0",
     "grunt-jsonlint": "1.1.0",
     "grunt-stylelint": "0.10.1",
diff --git a/resources/js/ext.uls.compactlinks.js b/resources/js/ext.uls.compactlinks.js
index c2ecfb82..d31b49f5 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -317,7 +317,7 @@
 			// Load the ULS now.
 			mw.loader.using( 'ext.uls.mediawiki' ).then( function () {
 				self.createSelector( self.$trigger );
-				self.$trigger.click();
+				self.$trigger.trigger( 'click' );
 			} );
 		} );
 	};
diff --git a/resources/js/ext.uls.displaysettings.js b/resources/js/ext.uls.displaysettings.js
index 7b28c7d7..2b6d5736 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -185,7 +185,7 @@
 						var deferred = new $.Deferred();
 
 						$loginCta.html( parsedCta ); // The parsed CTA is HTML
-						$loginCta.find( 'a' ).click( function ( event ) {
+						$loginCta.find( 'a' ).on( 'click', function ( event ) {
 							event.preventDefault();
 							// Because browsers navigate away when clicking a link,
 							// we are overriding the normal click behavior to allow
@@ -301,7 +301,7 @@
 						$back = $( '<div>' )
 							.addClass( 'uls-icon-back' );
 
-					$back.click( function () {
+					$back.on( 'click', function () {
 						uls.hide();
 						displaySettings.$parent.show();
 					} );
diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js
index 117777c7..653bcf1a 100644
--- a/resources/js/ext.uls.ime.js
+++ b/resources/js/ext.uls.ime.js
@@ -150,7 +150,7 @@
 				defaultModule: 'input',
 				onClose: function () {
 					// on close of input settings, keep focus in input area.
-					imeselector.$element.focus();
+					imeselector.$element.trigger( 'focus' );
 				},
 				top: imeselector.$element.offset().top
 			} );
@@ -291,7 +291,7 @@
 				$ulsTrigger.uls( {
 					onSelect: function ( language ) {
 						$input.data( 'imeselector' ).selectLanguage( language );
-						$input.focus();
+						$input.trigger( 'focus' );
 					},
 					languages: mw.ime.getLanguagesWithIME(),
 					ulsPurpose: 'ime-selector',
@@ -308,7 +308,7 @@
 						title: $.i18n( 'ext-uls-ime-help' )
 					} )
 					.addClass( 'ime-perime-help' )
-					.click( function ( event ) {
+					.on( 'click', function ( event ) {
 						event.stopPropagation();
 					} );
 			}
diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js
index f3d47733..fe22f9f6 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -173,7 +173,8 @@
 
 			$imeLabel = $( '<label>' ).attr( 'for', imeId );
 
-			$inputMethodItem = $( '<input type="radio">' ).attr( {
+			$inputMethodItem = $( '<input>' ).attr( {
+				type: 'radio',
 				name: 'ime',
 				id: imeId,
 				value: imeId
@@ -306,7 +307,7 @@
 				$button.on( 'click', buttonHandler( $button ) );
 
 				if ( language === selectedImeLanguage ) {
-					$button.click();
+					$button.trigger( 'click' );
 				}
 			}
 
@@ -339,7 +340,7 @@
 							.i18n()
 							.text( ' ' );
 
-					$back.click( function () {
+					$back.on( 'click', function () {
 						uls.hide();
 						inputSettings.$parent.show();
 					} );
diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js
index f6043623..89e8fa0a 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -79,7 +79,7 @@
 				};
 			}
 			$.extend( displaySettingsOptions, uls.position() );
-			$displaySettings.languagesettings( displaySettingsOptions ).click();
+			$displaySettings.languagesettings( displaySettingsOptions ).trigger( 'click' );
 		} );
 	}
 
@@ -104,7 +104,7 @@
 				},
 				top: position.top,
 				left: position.left
-			} ).click();
+			} ).trigger( 'click' );
 
 		} );
 	}
@@ -182,7 +182,7 @@
 					.text( previousAutonym )
 					.prop( {
 						href: '',
-						'class': 'uls-prevlang-link',
+						class: 'uls-prevlang-link',
 						lang: previousLang,
 						// We could get dir from uls.data,
 						// but we are trying to avoid loading it
@@ -311,7 +311,7 @@
 				};
 
 				mw.loader.using( mw.uls.languageSettingsModules, function () {
-					$ulsTrigger.languagesettings( languageSettingsOptions ).click();
+					$ulsTrigger.languagesettings( languageSettingsOptions ).trigger( 'click' );
 				} );
 
 				e.stopPropagation();
diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js
index 177a40e3..44bdd15f 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -81,7 +81,7 @@
 			this.$window.find( 'button.uls-settings-apply' )
 				.on( 'click', mw.hook( 'mw.uls.settings.apply' ).fire.bind( this ) );
 			// Hide the window when clicked outside
-			$( 'html' ).click( this.hide.bind( this ) );
+			$( 'html' ).on( 'click', this.hide.bind( this ) );
 
 			// ... but when clicked on window do not hide.
 			this.$window.on( 'click', function ( event ) {
@@ -189,18 +189,18 @@
 				this.initialized = true;
 			}
 			// Close other modal windows which listen to click events outside them
-			$( 'html' ).click();
+			$( 'html' ).trigger( 'click' );
 			this.i18n();
 			// Every time we show this window, make sure the current
 			// settings panels is up-to-date. So just click on active menu item.
-			this.$window.find( '.settings-menu-items > .active' ).click();
+			this.$window.find( '.settings-menu-items > .active' ).trigger( 'click' );
 
 			this.shown = true;
 			this.$window.show();
 			this.visible();
 			this.$window.scrollIntoView();
 			// For keyboard navigation, put the focus on an element inside the dialog
-			this.$window.find( '.menu-section.active' ).focus();
+			this.$window.find( '.menu-section.active' ).trigger( 'focus' );
 		},
 
 		/**
diff --git a/resources/js/ext.uls.preferences.js b/resources/js/ext.uls.preferences.js
index 0569fab4..8dd2236f 100644
--- a/resources/js/ext.uls.preferences.js
+++ b/resources/js/ext.uls.preferences.js
@@ -126,7 +126,7 @@
 		save: function ( callback ) {
 			var ulsPreferences = this;
 
-			callback = callback || $.noop;
+			callback = callback || function () {};
 			if ( this.isAnon ) {
 				// Anonymous user. Save preferences in local storage
 				preferenceStore().set( this.preferenceName, this.preferences );