From c1a36d34902d6469d5b7c81f5e3afce8fe6c707a Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sun, 21 Nov 2021 18:58:39 +0000 Subject: [PATCH] Don't call isCompactLinksEnabled() twice in the same function Store the result in a local variable. Change-Id: Ie45c22c3af370b0cdcbe614497691b0bd849393f --- includes/UniversalLanguageSelectorHooks.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/UniversalLanguageSelectorHooks.php b/includes/UniversalLanguageSelectorHooks.php index 559ea8bd..f310a1be 100644 --- a/includes/UniversalLanguageSelectorHooks.php +++ b/includes/UniversalLanguageSelectorHooks.php @@ -143,9 +143,10 @@ class UniversalLanguageSelectorHooks implements // Soft dependency to Wikibase client. Don't enable CLL if links are managed manually. $excludedLinks = $out->getProperty( 'noexternallanglinks' ); $override = is_array( $excludedLinks ) && in_array( '*', $excludedLinks ); + $isCompactLinksEnabled = $this->isCompactLinksEnabled( $out->getUser() ); $config = [ 'wgULSPosition' => $this->config->get( 'ULSPosition' ), - 'wgULSisCompactLinksEnabled' => $this->isCompactLinksEnabled( $out->getUser() ), + 'wgULSisCompactLinksEnabled' => $isCompactLinksEnabled, ]; // Load compact links if no mw-interlanguage-selector element is present in the page HTML. @@ -153,7 +154,7 @@ class UniversalLanguageSelectorHooks implements // using the class as the heuristic. // Note if the element is rendered by the skin, its assumed that no collapsing is needed. // See T264824 for more information. - if ( !$override && $this->isCompactLinksEnabled( $out->getUser() ) && + if ( !$override && $isCompactLinksEnabled && strpos( $out->getHTML(), 'mw-interlanguage-selector' ) === false ) { $out->addModules( 'ext.uls.compactlinks' );