From c9aa1f113065bb59d300223a5afb66214face439 Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Thu, 6 Jun 2013 11:56:43 +0530 Subject: [PATCH] Correct the loop logic for language buttons It is possible that the count reach more than SUGGESTED_LANGUAGES_NUMBER before it reach the languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER check. This will cause the loop to run for all languages. Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184 --- resources/js/ext.uls.displaysettings.js | 2 +- resources/js/ext.uls.inputsettings.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/ext.uls.displaysettings.js b/resources/js/ext.uls.displaysettings.js index e531325e..b45146b5 100644 --- a/resources/js/ext.uls.displaysettings.js +++ b/resources/js/ext.uls.displaysettings.js @@ -188,7 +188,7 @@ languagesForButtons.push( suggestedLanguages[lang] ); // No need to add more languages than buttons - if ( languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER ) { + if ( languagesForButtons.length >= SUGGESTED_LANGUAGES_NUMBER ) { break; } } diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index d5fcdd98..d21ad459 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -252,7 +252,7 @@ languagesForButtons.push( suggestedLanguages[lang] ); // No need to add more languages than buttons - if ( languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER ) { + if ( languagesForButtons.length >= SUGGESTED_LANGUAGES_NUMBER ) { break; } }