From cfd6d48bc149d25ac08296b1e55dee236d56eaae Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Mon, 6 Jun 2022 12:35:48 +0530 Subject: [PATCH] Load OOUI widgets only when ULS is opened OOUI widgets are required for the actions menu dialog, but no need to have them loaded unconditionally. Bug: T309793 Change-Id: Icc09b88aa70af1316bd67a56b13a411ebc8f7f8a --- extension.json | 4 +--- resources/js/ext.uls.interface.js | 6 ++++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extension.json b/extension.json index 491828d2..8cbe6d25 100644 --- a/extension.json +++ b/extension.json @@ -256,9 +256,7 @@ "mediawiki.jqueryMsg", "mediawiki.storage", "mediawiki.user", - "ext.uls.webfonts", - "oojs-ui-widgets", - "oojs-ui.styles.icons-interactions" + "ext.uls.webfonts" ], "messages": [ "uls-plang-title-languages", diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 9bab0c36..e1925238 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -180,8 +180,10 @@ } actionItemsRegistry.on( 'register', onActionItemAdded ); uls.$menu.append( $actionsMenuTrigger ); - - registerTriggerListener(); + // Action menu items need OOUI widgets. Load them and register trigger event handler. + mw.loader.using( [ 'oojs-ui-widgets', 'oojs-ui.styles.icons-interactions' ] ).done( function () { + registerTriggerListener(); + } ); } /**