bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Undefined offset notice

Browse Source 
Also removed some dead code that never ran, there is no variable named
"$buckets" so it'll never have an offset.

Bug: 45327
Change-Id: I1f70ef0ec4f2434f9f072e718140ff8050b81ba3
This commit is contained in:
Niklas Laxström
2013-04-25 12:45:40 +00:00
parent 74941191fc
commit da255cdc77
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
data/LanguageNameSearch.php
View File

@@ -28,11 +28,17 @@ class LanguageNameSearch {
if ( self::$languagenames === null ) { if ( self::$languagenames === null ) {
self::init(); self::init();
} }
// @todo: Shouldn't this be unicode aware?
$searchKey = strtolower( $searchKey ); $searchKey = strtolower( $searchKey );
$bucket = self::$languagenames[self::getIndex( $searchKey )]; $index = self::getIndex( $searchKey );
if ( !$bucket ) {
if ( !isset( self::$languagenames[$index] ) ) {
return array(); return array();
} }
$bucket = self::$languagenames[$index];
$results = array(); $results = array();
foreach ( $bucket as $name => $code ) { foreach ( $bucket as $name => $code ) {
// Prefix search // Prefix search
@@ -55,9 +61,6 @@ class LanguageNameSearch {
} else { } else {
$bucket = $codepoint % 1000; $bucket = $codepoint % 1000;
} }
if ( !isset( $buckets[$bucket] ) ) {
$buckets[$bucket] = array();
}
return $bucket; return $bucket;
} }