Remove unused code from ext.uls.interface.js
During the implementation of the “addEmptyState” method, a part of code was copied from the “addActionsMenuTrigger” method. This part is the rendering of the action menu items (Translate button, Open Language Settings button, etc) that is common for both the empty state and the actions menu. During this copy, two unused lines were also copied. These lines basically create the trigger for the actions menu (the “ellipsis” or “cog” icon button at the bottom right corner of non-empty ULS), which is not rendered for the ULS empty state. This patch removes these unused lines. Change-Id: I4776c2038cb6e1c74401c4caa6705e98181c6dca
This commit is contained in:
@@ -149,8 +149,6 @@
|
||||
var actionItemsRegistry = mw.uls.ActionsMenuItemsRegistry;
|
||||
actionItemsRegistry.register( languageSettingsMenuItem );
|
||||
|
||||
var $actionsMenuTrigger = createActionsMenuTrigger();
|
||||
setActionsMenuTriggerIconClass( $actionsMenuTrigger, actionItemsRegistry.size() );
|
||||
var $header = $( '<h3>' )
|
||||
.addClass( 'uls-empty-state__header' )
|
||||
.text( $.i18n( 'ext-uls-empty-state-header' ) );
|
||||
|
||||
Reference in New Issue
Block a user