bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix and enable feature Persistent settings

Browse Source 
* Reuse existing steps where possible
* Rename steps file to match convention
* Moved unrelated steps to a new file
* Added wait for saving

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Bug: 56885
Change-Id: I480058430696579947187265b940ea46156f1519
This commit is contained in:
Niklas Laxström
2013-11-21 11:06:18 +02:00
parent 6a7fe531d2
commit ded20c61f2
4 changed files with 20 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/browser/features/persistent_settings.feature
View File

@@ -1,23 +1,22 @@
@login @reset-preferences-after @commons.wikimedia.beta.wmflabs.org @login @reset-preferences-after
Feature: Persistent settings Feature: Persistent settings
This assumes wiki content language is English. This assumes wiki content language is English.
Background: Background:
Given I am logged in Given I am logged in
And I set interface language that is different from content language and has a font And I set "German" as the interface language
And I open the Universal Language Selector
And I open Display panel of language settings
And I open Fonts panel of language settings
And I select OpenDyslexic font for the interface language for the live preview
Scenario: Interface font sticks to another page Scenario: Interface font sticks to another page
When I open "Fonts" panel of language settings When I apply the changes
And I select a font for the interface language
And I apply the changes
And I visit a random page And I visit a random page
And I open "Fonts" panel of language settings Then the selected interface font must be OpenDyslexic
Then the selected interface font must be what I previously selected
Scenario: Discarding a live preview of a font keeps the previous font Scenario: Discarding a live preview of a font keeps the previous font
When I open "Fonts" panel of language settings When I close the panel to discard the changes
And I select a font for the interface language
And I close the panel to discard the changes
And I visit a random page And I visit a random page
Then the selected interface font must be "system" Then the selected interface font must be Systemschriftart

5
tests/browser/features/step_definitions/panel_steps.rb
View File

@@ -31,7 +31,10 @@ When(/^I close the panel to discard the changes$/) do
end end
When(/^I apply the changes$/) do When(/^I apply the changes$/) do
on(PanelPage).panel_button_apply_element.click on(PanelPage) do |page|
page.panel_button_apply_element.click
page.language_settings_dialog_element.wait_while_present
end
end end
Then(/^I can disable input methods$/) do Then(/^I can disable input methods$/) do

6
tests/browser/features/step_definitions/persistent_settings_steps.rb Normal file
View File

@@ -0,0 +1,6 @@
Then(/^the selected interface font must be (.*?)$/) do |font|
step 'I open the Universal Language Selector'
step 'I open Display panel of language settings'
step 'I open Fonts panel of language settings'
on(PanelPage).font_for_interface.should == font
end

15
tests/browser/features/step_definitions/persistent_steps.rb → tests/browser/features/support/pages/live_preview_of_display_language_steps.rb
View File

@@ -1,18 +1,3 @@
Given(/^I set interface language that is different from content language and has a font$/) do
visit(PreferencesPage) do |page|
page.set_interface_language_element.select_value 'de'
page.save_element.click
end
end
When(/^I select a font for the interface language$/) do
on(PanelPage).select_font_for_interface = 'OpenDyslexic'
end
Then(/^the selected interface font must be what I previously selected$/) do
on(PanelPage).select_font_for_interface.should == 'OpenDyslexic'
end
When(/^I set English font to System$/) do When(/^I set English font to System$/) do
on(PanelPage).select_font_for_content = 'System font' on(PanelPage).select_font_for_content = 'System font'
end end