From e58be7c4115ede62066302ed50e54db6fe512ed2 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 6 Sep 2018 22:45:23 +0100 Subject: [PATCH] ext.uls.eventlogger: Remove unused $.Callbacks() indirection It is created, unconditionally fired only once (right after creation), and then used only with add(), which becomes a synchronous self-call. I've searched in Wikimedia Git and Codesearch, and found no uses of `logEventQueue` or `mw.uls.eventlogger` outside this file. Change-Id: I3832bcb409fc919c2078e583d50e20413dede163 --- resources/js/ext.uls.eventlogger.js | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/resources/js/ext.uls.eventlogger.js b/resources/js/ext.uls.eventlogger.js index f87382b1..34f2c484 100644 --- a/resources/js/ext.uls.eventlogger.js +++ b/resources/js/ext.uls.eventlogger.js @@ -27,23 +27,18 @@ * @since 2013.08 */ function ULSEventLogger() { - this.logEventQueue = $.Callbacks( 'memory once' ); this.init(); this.listen(); } ULSEventLogger.prototype = { init: function () { - var eventLogger = this; - mw.eventLog.setDefaults( 'UniversalLanguageSelector', { version: 1, token: mw.user.id(), contentLanguage: mw.config.get( 'wgContentLanguage' ), interfaceLanguage: mw.config.get( 'wgUserLanguage' ) } ); - - eventLogger.logEventQueue.fire(); }, /** @@ -62,11 +57,9 @@ schema = schema || 'UniversalLanguageSelector'; - this.logEventQueue.add( function () { - mw.eventLog.logEvent( schema, event ) - .done( deferred.resolve ) - .fail( deferred.reject ); - } ); + mw.eventLog.logEvent( schema, event ) + .done( deferred.resolve ) + .fail( deferred.reject ); return deferred.promise(); },