bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use type hints for TypeError exception

Browse Source 
This change allows to replace the Assert::parameterType by a type hint
in Ie215179b4631fd9071b257772c5cb193547cb7d7.

Change-Id: I399a92d3fac0e0849fe3a403c703fe7d32f51257
This commit is contained in:
Fomafix
2019-10-30 17:17:32 +01:00
committed by jenkins-bot
parent 2c0be6be46
commit e7ab5faf2f
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
includes/ULSJsonMessageLoader.php
View File

@@ -26,7 +26,7 @@ class ULSJsonMessageLoader {
* @param string $language Language code. * @param string $language Language code.
* @return string[] * @return string[]
*/ */
public static function getFilenames( $language ) { public static function getFilenames( string $language ) {
$filenames = []; $filenames = [];
$languages = Language::getFallbacksFor( $language ); $languages = Language::getFallbacksFor( $language );
@@ -54,7 +54,7 @@ class ULSJsonMessageLoader {
* @param string $language Language code. * @param string $language Language code.
* @return array * @return array
*/ */
public static function getMessages( $language ) { public static function getMessages( string $language ) {
$contents = []; $contents = [];
foreach ( self::getFilenames( $language ) as $filename ) { foreach ( self::getFilenames( $language ) as $filename ) {

4
tests/phpunit/ULSJsonMessageLoaderTest.php
View File

@@ -15,14 +15,14 @@ class ULSJsonMessageLoaderTest extends \PHPUnit\Framework\TestCase {
public function testGetFilenamesWithBadInput() { public function testGetFilenamesWithBadInput() {
$instance = new ULSJsonMessageLoader(); $instance = new ULSJsonMessageLoader();
$this->expectException( \Exception::class ); $this->expectException( \TypeError::class );
$instance->getFilenames( null ); $instance->getFilenames( null );
} }
public function testGetMessagesWithBadInput() { public function testGetMessagesWithBadInput() {
$instance = new ULSJsonMessageLoader(); $instance = new ULSJsonMessageLoader();
$this->expectException( \Exception::class ); $this->expectException( \TypeError::class );
$instance->getMessages( null ); $instance->getMessages( null );
} }