Remove disabling of max-len rule and fix violations

Change-Id: I39ec2e572e569a05c11929dd17241653abf954ef

.eslintrc.json

@@ -6,8 +6,5 @@
 	"globals": {
 		"mw": false,
 		"OO": false
-	},
-	"rules": {
-		"max-len": 0
 	}
 }

resources/js/ext.uls.displaysettings.js

@@ -655,19 +655,17 @@
 		 * modules.
 		 */
 		apply: function () {
-			var displaySettings = this;
-
-			if ( !displaySettings.dirty ) {
+			if ( !this.dirty ) {
 				// No changes to save in this module.
 				return;
 			}
 
-			displaySettings.$parent.setBusy( true );
+			this.$parent.setBusy( true );
 			// Save the preferences
 			mw.webfonts.preferences.save( function ( result ) {
 				var newWebfontsEnable, oldWebfontsEnable, webfontsEvent,
 					newRegistry = mw.webfonts.preferences.registry,
-					oldRegistry = displaySettings.savedRegistry.registry,
+					oldRegistry = this.savedRegistry.registry,
 					newFonts = newRegistry.fonts || {},
 					oldFonts = oldRegistry.fonts || {};
 
@@ -684,25 +682,25 @@
 					mw.hook( webfontsEvent ).fire( 'displaysettings' );
 				}
 
-				if ( newFonts[ displaySettings.uiLanguage ] !== oldFonts[ displaySettings.uiLanguage ] ) {
+				if ( newFonts[ this.uiLanguage ] !== oldFonts[ this.uiLanguage ] ) {
 					mw.hook( 'mw.uls.font.change' ).fire(
-						'interface', displaySettings.uiLanguage, newFonts[ displaySettings.uiLanguage ]
+						'interface', this.uiLanguage, newFonts[ this.uiLanguage ]
 					);
 				}
 
-				if ( newFonts[ displaySettings.contentLanguage ] !== oldFonts[ displaySettings.contentLanguage ] ) {
+				if ( newFonts[ this.contentLanguage ] !== oldFonts[ this.contentLanguage ] ) {
 					mw.hook( 'mw.uls.font.change' ).fire(
-						'content', displaySettings.contentLanguage, newFonts[ displaySettings.contentLanguage ]
+						'content', this.contentLanguage, newFonts[ this.contentLanguage ]
 					);
 				}
 
 				// closure for not losing the scope
-				displaySettings.onSave( result );
-				displaySettings.dirty = false;
+				this.onSave( result );
+				this.dirty = false;
 				// Update the back-up preferences for the case of canceling
-				displaySettings.savedRegistry = $.extend( true, {}, mw.webfonts.preferences );
-				displaySettings.$parent.setBusy( false );
-			} );
+				this.savedRegistry = $.extend( true, {}, mw.webfonts.preferences );
+				this.$parent.setBusy( false );
+			}.bind( this ) );
 		},
 
 		/**

resources/js/ext.uls.interface.js

@@ -272,7 +272,10 @@
 					if ( !languagesettings.shown ) {
 						mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'interlanguage' );
 					}
-				} else {
+
+					return;
+				}
+
 				// Initialize the Language settings window
 				languageSettingsOptions = {
 					defaultModule: 'display',
@@ -312,7 +315,6 @@
 				} );
 
 				e.stopPropagation();
-				}
 			};
 		} else if ( anonMode ) {
 			clickHandler = function ( e, eventParams ) {