Fix: ULS popup moves to sidebar if opened from ime menu
Issues fixed: Incorrect position of ULS when accessed from more languages button of input/display settings, when language settings opened from ime menu. Arrow(callout) appearing for ULS when opened from more languages button of input/display settings, when language settings opened from ime menu. Used a class 'callout' to mark whether windows need callout arrow or not. Bug: 49060 Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
This commit is contained in:
committed by
Gerrit Code Review
parent
6a9b31ad26
commit
e9ab300889
@@ -288,6 +288,7 @@
|
||||
var left,
|
||||
ulsTriggerOffset = $ulsSettingsTrigger.offset();
|
||||
|
||||
this.$window.addClass( 'callout' );
|
||||
if ( rtlPage ) {
|
||||
left = ulsTriggerOffset.left - this.$window.width() - 30;
|
||||
} else {
|
||||
@@ -297,15 +298,12 @@
|
||||
this.left = left;
|
||||
this.top = ulsTriggerOffset.top - 50;
|
||||
this.position();
|
||||
this.$window.prepend(
|
||||
$( '<span>' ).addClass( 'caret-before' ),
|
||||
$( '<span>' ).addClass( 'caret-after' )
|
||||
);
|
||||
}
|
||||
} );
|
||||
|
||||
$( '.uls-menu' ).each( function () {
|
||||
$( this ).prepend(
|
||||
$( '<span>' ).addClass( 'caret-before' ),
|
||||
$( '<span>' ).addClass( 'caret-after' )
|
||||
);
|
||||
} );
|
||||
} else if ( anonMode ) {
|
||||
$ulsTrigger.languagesettings();
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user