From 5e7e8fe48e3ab977be927ba384c6b4dfdfb254a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Laxstr=C3=B6m?= Date: Mon, 15 Aug 2016 10:43:40 +0200 Subject: [PATCH] LanguageSettings: Do not render modules twice on initialization Change-Id: I25d939ffcabde394bb7a496ee8bc5df9a87c2573 --- resources/js/ext.uls.languagesettings.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index a27a67ec..8c48320c 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -139,6 +139,10 @@ $settingsText ); + if ( active ) { + $settingsLink.addClass( 'active' ); + } + $settingsMenuItems.append( $settingsLink ); $settingsLink.on( 'click', function () { @@ -151,10 +155,6 @@ $this.addClass( 'active' ); } ); - if ( active ) { - module.render(); - $settingsLink.addClass( 'active' ); - } this.modules[ moduleName ] = module; // Register cancel and apply hooks