bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactoring tests to make them more robust

Browse Source 
Fixed typo in feature description.
Merged two background steps since the last one did not have any actions
that could be done manually.
Removed assertions from a "given" (login) step. We already extensively
test logging in. If this extension needs login tests, they should go to
a separate feature file.
Moved methods from steps file to page file, following page object
pattern.

Change-Id: Ic5250970362718f5ed887c9ac8fd56948724b210
This commit is contained in:
Zeljko Filipin
2013-10-22 12:09:52 +02:00
committed by Niklas Laxström
parent afc5774ee2
commit f45d5bfcd5
5 changed files with 38 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/browser/features/step_definitions/panel_steps.rb
View File

@@ -2,11 +2,6 @@ Then(/^I see "(.*?)" as the name of the content language$/) do |text|
@browser.span(:text => "#{text}").should be_visible
end
Given(/^I inspect current fonts$/) do
@original_content_font = get_content_font()
@original_interface_font = get_interface_font()
end
When(/^I open "(.*?)" panel of language settings$/) do |panel|
on(PanelPage) do |page|
# Open the ULS panel if it's not open already
@@ -58,9 +53,9 @@ end
Then(/^the active (.*?) font must be the same as font prior to the preview$/) do |type|
case type
when "content"
get_content_font().should === @original_content_font
on(PanelPage).get_content_font.should === @original_content_font
when "interface"
get_interface_font().should === @original_interface_font
on(PanelPage).get_interface_font.should === @original_interface_font
else
pending
end
@@ -86,9 +81,9 @@ end
Then(/^the (.*) font must be changed to the "(.*?)" font$/) do |type, font|
case type
when "content"
get_content_font().should match("^#{font}")
on(PanelPage).get_content_font.should match("^#{font}")
when "interface"
get_interface_font().should match("^#{font}")
on(PanelPage).get_interface_font.should match("^#{font}")
else
pending
end
@@ -111,7 +106,7 @@ Then(/^a font selector for content language appears$/) do
end
When(/^I use the panel to change my interface language to "(.*?)"$/) do |language|
code = language_to_code(language)
code = on(PanelPage).language_to_code(language)
on(RandomPage).language_filter = code
# Because one browser wants :enter and other :return -- sigh
on(RandomPage).language_filter_element.send_keys [:enter, "\n"]