From f8487a54eb41e59affa7560a08c62f30abb036a0 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Sat, 5 Mar 2016 17:00:45 +0100 Subject: [PATCH] Use single quotes where possible Change-Id: I8c0098e4840d7eff16cf5818f2247b134946d77b --- data/LanguageNameIndexer.php | 2 +- tests/phpunit/LanguageSearchTest.php | 16 ++++++++-------- tests/phpunit/ResourceLoaderULSTest.php | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/data/LanguageNameIndexer.php b/data/LanguageNameIndexer.php index 0715d985..3e258791 100644 --- a/data/LanguageNameIndexer.php +++ b/data/LanguageNameIndexer.php @@ -49,7 +49,7 @@ class LanguageNameIndexer extends Maintenance { $buckets[$bucket][$name] = $code; } } - $this->output( "Total buckets: " . count( $buckets ) . "\n" ); + $this->output( 'Total buckets: ' . count( $buckets ) . "\n" ); file_put_contents( 'langnames.ser', serialize( $buckets ) ); } } diff --git a/tests/phpunit/LanguageSearchTest.php b/tests/phpunit/LanguageSearchTest.php index d74425f3..0fe3ed26 100644 --- a/tests/phpunit/LanguageSearchTest.php +++ b/tests/phpunit/LanguageSearchTest.php @@ -29,23 +29,23 @@ class LanguageSearchTest extends PHPUnit_Framework_TestCase { public function searchDataProvider() { return array( - array( "ഹിന്ദി", array( + array( 'ഹിന്ദി', array( 'hi' => 'ഹിന്ദി' ) ), - array( "മല", array( - 'ml' => "മലയാളം", + array( 'മല', array( + 'ml' => 'മലയാളം', 'mg' => 'മലഗാസി', 'ms' => 'മലെയ്', ) ), - array( "Φινλαν", array( + array( 'Φινλαν', array( 'fi' => 'Φινλανδικά', ) ), array( 'blah', array() ), - array( "الفرنسية", array( + array( 'الفرنسية', array( 'fr' => 'الفرنسية', 'fr-ca' => 'الفرنسية الكندية', 'fr-ch' => 'الفرنسية السويسرية', @@ -53,11 +53,11 @@ class LanguageSearchTest extends PHPUnit_Framework_TestCase { 'fro' => 'الفرنسية القديمة', ) ), - array( "മലയളം", array( - 'ml' => "മലയാളം", + array( 'മലയളം', array( + 'ml' => 'മലയാളം', ) ), - array( "finish", array( + array( 'finish', array( 'fi' => 'finnish' ) ), diff --git a/tests/phpunit/ResourceLoaderULSTest.php b/tests/phpunit/ResourceLoaderULSTest.php index cdc98be4..f567420e 100644 --- a/tests/phpunit/ResourceLoaderULSTest.php +++ b/tests/phpunit/ResourceLoaderULSTest.php @@ -30,20 +30,20 @@ class ResourceLoaderULSModuleMemcachedTest extends MediaWikiTestCase { $request->setVal( 'lang', 'hi' ); $context = new ResourceLoaderContext( new ResourceLoader(), $request ); $mtimeHindi = $module->getModifiedTime( $context ); - $this->assertGreaterThan( $mtimeHebrew, $mtimeHindi, "Hindi has recent timestamp than Hebrew" ); + $this->assertGreaterThan( $mtimeHebrew, $mtimeHindi, 'Hindi has recent timestamp than Hebrew' ); // sleep for 1 second sleep( 1 ); $request->setVal( 'lang', 'he' ); $context = new ResourceLoaderContext( new ResourceLoader(), $request ); $mtimeHebrewNew = $module->getModifiedTime( $context ); - $this->assertEquals( $mtimeHebrewNew, $mtimeHebrew, "Hebrew timestamp remained same" ); + $this->assertEquals( $mtimeHebrewNew, $mtimeHebrew, 'Hebrew timestamp remained same' ); // sleep for 1 second sleep( 1 ); $request->setVal( 'lang', 'hi' ); $context = new ResourceLoaderContext( new ResourceLoader(), $request ); $mtimeHindiNew = $module->getModifiedTime( $context ); - $this->assertEquals( $mtimeHindi, $mtimeHindiNew, "Hindi timestamp remained same" ); + $this->assertEquals( $mtimeHindi, $mtimeHindiNew, 'Hindi timestamp remained same' ); } }