diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index e91e2048..c8cbc86a 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -62,26 +62,24 @@ this.hide(); }, + // Register all event listeners to the ULS language settings here. listen: function () { - var langSettings = this; - // Register all event listeners to the ULS language settings here. - langSettings.$element.on( 'click', $.proxy( langSettings.click, langSettings ) ); - langSettings.$window.find( '#languagesettings-close' ) - .on( 'click', $.proxy( langSettings.close, langSettings ) ); - + this.$element.on( 'click', $.proxy( this.click, this ) ); + this.$window.find( '#languagesettings-close' ) + .on( 'click', $.proxy( this.close, this ) ); }, render: function () { - var modules, defaultModule, moduleName; + var moduleName, + defaultModule = this.options.defaultModule; // Get the name of all registered modules and list them in left side menu. - modules = $.fn.languagesettings.modules; - defaultModule = this.options.defaultModule; - for ( moduleName in modules ) { - if ( modules.hasOwnProperty( moduleName ) ) { + for ( moduleName in $.fn.languagesettings.modules ) { + if ( $.fn.languagesettings.modules.hasOwnProperty( moduleName ) ) { if ( !defaultModule ) { defaultModule = moduleName; } + // Call render function on the current setting module. this.renderModule( moduleName, defaultModule === moduleName ); } @@ -94,11 +92,11 @@ * @param active boolean Make this module active and show by default */ renderModule: function ( moduleName, active ) { - var $settingsMenuItems, module, $settingsText, $settingsTitle, $settingsLink, - languageSettings = this; + var $settingsTitle, $settingsText, $settingsLink, + languageSettings = this, + module = new $.fn.languagesettings.modules[moduleName]( languageSettings ), + $settingsMenuItems = languageSettings.$window.find( '.settings-menu-items' ); - $settingsMenuItems = languageSettings.$window.find( '.settings-menu-items' ); - module = new $.fn.languagesettings.modules[moduleName]( languageSettings ); $settingsTitle = $( '