bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make ULS trigger and settings more keyboard accessible

Browse Source 
It's now possible to tab to "display settings" and "input settings"
and access them with enter or space. Also escape can now be used
to close the settings screen.

The ULS trigger in interlanguage position is a button to get
native accessibility features.

Also removed `mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );` as
it didn't seem very useful and there wasn't immediately obvious
place to put it. The existing click handler could be removed because
the settings dialog themselves place event listeners.

The patch is a bit longer than strictly necessary because the CSS
was mess (rules in different modules, poorly organized) and I had
to bring related rules together to understand them.

Bug: T52793
Change-Id: Id37c2665b1c97b81ef57be27a1abfae0db6b34d5
This commit is contained in:
Niklas Laxström
2018-01-31 15:29:04 +01:00
committed by petarpetkovic
parent 75e80446cb
commit fca9b5c0e6
7 changed files with 151 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
resources/css/ext.uls.interlanguage.less
View File

@@ -2,12 +2,22 @@
@import 'mediawiki.mixins';
#p-lang .uls-settings-trigger {
background: transparent no-repeat right top;
background: transparent no-repeat center top;
.background-image-svg( '../images/cog-sprite.svg', '../images/cog-sprite.png' );
height: 16px;
width: 14px;
border: 0;
min-height: 16px;
min-width: 16px;
float: right;
cursor: pointer;
// Remove the dotted border for Firefox
&::-moz-focus-inner {
border: 0;
}
&:focus {
outline: 1px solid #36c;
}
}
.skin-vector #p-lang .uls-settings-trigger {
@@ -16,5 +26,5 @@
}
#p-lang .uls-settings-trigger:hover {
background-position: right -16px;
background-position: center -16px;
}