Commit Graph

15 Commits

Author SHA1 Message Date
NikG
a6a338c0f7 ULS: Use quick actions icon inside page language selector
Currently, inside the page language selector of multilingual wikis
(like Commons), the user can access the language settings by clicking
the display and input setting buttons that are provided at the bottom
of the language selector. However, instead of these buttons, the quick
actions trigger should be used instead for a consistent user experience.

The trigger will only provide access to the language settings, and other
quick action items won't have any effect in this case.

Bug: T314021
Change-Id: Iaaf61c85518b4d3d44d4a92dbf5dc7fdb96282fa
2023-03-30 05:52:06 +00:00
Umherirrender
e464c5ab31 stylelint: Enable selector-pseudo-element-colon-notation
Via stylelint --fix

Change-Id: I77f14cac83e4422c7962339d1177da9e65b6a28e
2023-03-30 01:03:16 +02:00
NikG
dde48f50ab Add separate buttons for 'add languages' and language settings menus
Bug: T323694
Change-Id: I23cb4687d841025905224a52b843572206fa9ddb
2023-01-25 11:47:24 +00:00
NikG
965ffc3b1a Add language settings button inside dropdown for non-content pages
NOTE: This patch is identical to patch with change-id:
Ifdf2a529b30e5a2df8867b606a525c9f7b3bdb6c

The above patch has been merged but reverted because of the usage
of '$skin->getTemplateDate()' method, which should be avoided. The
current patch replaces the usage of this method, with the usage of
the output page title ($out->getTitle()). All the rest of the code
has been kept the same.

Bug: T316559
Change-Id: Ibef9f6fd46d9055c3e0865905fb8aa8d031c1940
2023-01-11 18:05:29 +02:00
Jdlrobson
570a7d3b4e Revert "Add language settings button inside dropdown for non-content pages"
This reverts commit 5d576d05b4.

Reason for revert: Using Skin::getTemplateData method outside the
skin rendering layer is dangerous and likely a performance issue as
it means generating the rendering data twice and makes various hooks
execute multiple times.
It has caused T326538 and may be causing other issues.

Bug: T326538
Change-Id: Ie5d079deae414eb199d2a40b98d04b57439eaac4
2023-01-09 20:25:46 +00:00
NikG
5d576d05b4 Add language settings button inside dropdown for non-content pages
Bug: T316559
Change-Id: Ifdf2a529b30e5a2df8867b606a525c9f7b3bdb6c
2023-01-09 05:02:57 +00:00
Santhosh Thottingal
3450f90678 Add support for empty states to the current language selector
Bug: T290436
Change-Id: I42c5d44ec15e291d71723c9738ddb8f0d1cf0b09
2022-07-01 09:16:40 +00:00
Santhosh Thottingal
5e6838ebdf Add actions menu inside content language selector
This patch replaces the display and input settings menu bar at the
bottom of the content language selector, with a floating icon that
opens a menu containing all the available language actions. In case
that only the language settings action is available, the language
settings menu is being opened instead.

In order to provide extensibility and support the addition of new
action items from other extensions, a registry class that inherits
from OO.Registry class is created. This class is used to create a
singleton registry object that holds all action items that should
be rendered inside the menu. Other modules/extensions can use this
registry to add new actions items to the menu, by passing the item
as argument, in the following form:
{ name: "", icon: "", text: "", handler: function() {} }

Bug: T289840
Change-Id: Iee017a9e3e6a654145e9fdd2b7df35baa348697d
2022-04-11 05:24:08 +00:00
Niklas Laxström
0a692b227a Increase z-index for undo tooltip
When interface language selector is at the top, the undo tooltip
may appear under new Vector search box and other user tool links.

Change-Id: I36ac01511e590896afb0382c17ae90d01ba57314
2021-03-18 09:29:59 +00:00
Volker E
6ea7307df9 Amend Base10 color and remove (affected) PNG fallbacks
Amending Base10 to slightly darker `#202122` to fulfill WCAG
requirements in connection to Accent50.
Also removing all PNG fallbacks as they are only used in JS-only.

Bug: T248393
Change-Id: I07fa4e23320763a634e5340ab125634842b86454
2020-04-21 11:43:23 +00:00
Niklas Laxström
fca9b5c0e6 Make ULS trigger and settings more keyboard accessible
It's now possible to tab to "display settings" and "input settings"
and access them with enter or space. Also escape can now be used
to close the settings screen.

The ULS trigger in interlanguage position is a button to get
native accessibility features.

Also removed `mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );` as
it didn't seem very useful and there wasn't immediately obvious
place to put it. The existing click handler could be removed because
the settings dialog themselves place event listeners.

The patch is a bit longer than strictly necessary because the CSS
was mess (rules in different modules, poorly organized) and I had
to bring related rules together to understand them.

Bug: T52793
Change-Id: Id37c2665b1c97b81ef57be27a1abfae0db6b34d5
2018-02-12 17:57:04 +01:00
Ed Sanders
447c09d462 build: Update linters
Change-Id: I45540db95711b461ded3630894bd1f149c24ff19
2017-11-29 15:02:47 +00:00
Volker E
31477ad0ec Replace settings block rounded gradient with color
Replacing vertical background gradient with single color, as no
faux 3D gradients are part of current style guide.

Change-Id: If98a6cb22a9551a5d69d782759eadd5cec7e0efc
2017-11-01 13:38:52 -07:00
Volker E
dc99a4eb80 Align border-radius values with WikimediaUI
Aligning `border-radius` values with WikimediaUI design, which
sets value to `2px`.

Change-Id: I7fd7bc5290fe781bfa02c3d5b74071b68cb22660
2017-09-07 06:43:55 +00:00
Volker E
fd0bb2600b Replace outdated colors with WikimediaUI palette ones
Replacing all colors with current WikimediaUI palette ones.
Also:
- changing two files over to LESS in order to
 - make use of central gradient mixin instead of one with
   unnecessary vendor extensions and
 - concatenating selectors in one occurrence.

Bug: T174237
Change-Id: I5d302f29b079f6abdba5abf3b58d6ba254e1a4ac
2017-09-06 13:04:00 -07:00