Commit Graph

84 Commits

Author SHA1 Message Date
Željko Filipin
513cfb87cf Fixed Style/HashSyntax RuboCop offense
Bug: 117989
Change-Id: Iecdcc3202adf9458f11310d188ab93176b03194f
2015-11-18 12:04:04 +01:00
Željko Filipin
f2b53c04f8 Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense
Bug: 117989
Change-Id: I7f9704999047dd73b784aeb186a8298aba657b1c
2015-11-18 12:03:17 +01:00
Željko Filipin
022efbfa8a Fixed Style/SpaceInsideParens RuboCop offense
Bug: 117989
Change-Id: I3418ad3b0265903171e3ee7603eeea22569387b4
2015-11-18 12:02:38 +01:00
Željko Filipin
71707e11a9 Fixed Style/IndentationWidth RuboCop offense
Bug: 117989
Change-Id: Ifc6ca84cef432c1214acb0cd988146544895f400
2015-11-18 12:01:51 +01:00
Željko Filipin
22e8762cec Fixed Style/StringLiterals RuboCop offense
Bug: 117989
Change-Id: I82086ebd56ace9f85c521ef53b67e5e4bae9d607
2015-11-18 12:00:36 +01:00
Željko Filipin
81e918780a Fixed Style/Tab RuboCop offense
Bug: 117989
Change-Id: Ic4d9769df7c0ca459a7710b414d0738601107461
2015-11-18 11:59:32 +01:00
Željko Filipin
0aa649e084 Update mediawiki_selenium Ruby gem to the latest version
Bug: 117976
Change-Id: I567880afcf7dc5d70e6d4edef1db16d7923ae31c
2015-11-18 11:50:39 +01:00
Niklas Laxström
314e1c8c28 Update bugzilla references to phabricator and remove some excess links
Change-Id: I2cb920fd084a1ab333678e1e3c8f4524b39cc6cd
2014-12-06 22:09:23 +00:00
Željko Filipin
e9259b9766 Bug 61214 is resolved, removed pending block
Paired with: Amir E. Aharoni
Bug: 61214

Change-Id: I3345ee2130d09bd230a55e0c9c33da7a36247a09
2014-09-04 15:18:11 +02:00
Željko Filipin
5b39955df5 Made a scenario pending
It fails because of a known bug.

Paired with: Amir Aharoni
Bug: 61214

Change-Id: Id46d5c86e58c4e02bc491378b53c9b3f2f7a4141
2014-06-17 15:22:27 +02:00
Željko Filipin
249d064c53 Implemented missing Cucumber step
Used in ime.feature:50.

Change-Id: I0bf52456e687d7ff2b1d54fc990d4ed5d2803a47
2014-03-25 12:01:44 +01:00
Zeljko Filipin
76b1d87151 Using the new way of starting a custom browser
mediawiki_selenium Ruby gem is now able to start local and remote browsers with
optional browser setup.

Paired with Kartik Mistry.

Bug: 62512
Change-Id: I61e5b688711b1976e8df8be94972fe35f6eeb9aa
2014-03-21 10:34:44 +00:00
Zeljko Filipin
b4af650730 Removed random page
Using a dedicated page instead of a random page. Paired  with Amir
Aharoni.
Bug: 62479
Change-Id: I3750ecf972f52f205fd30855455ef6259b9c911d
2014-03-11 16:13:16 +01:00
Zeljko Filipin
30368d121e Running tests at language-browsertests.wmflabs.org
This will revert: https://gerrit.wikimedia.org/r/#/c/114457/

Change-Id: I53d7adc685820d421d774c196642bddc9e5f19b0
2014-02-21 12:50:54 +00:00
Kartik Mistry
efb1275fc7 Various fixes in font_selection tests.
1. Fixed comment in header comment (/s/disabled/enabled).
 2. Remove pending step for #56081 bug.

Change-Id: I9b1a74aa4c0305f529123f24dc05f8c8e5d4f58d
2014-02-18 11:27:01 +05:30
Zeljko Filipin
cf57dfbf69 Moved login and reset preferences to mediawiki_selenium Ruby gem
Bug: 56088
Change-Id: I3d4150295ec2f66e5ad20a90769b7bd4bb14763f
2014-02-11 14:51:37 +01:00
Santhosh Thottingal
27771fdeaf Restore enableWebfonts pref and remove uls-enable
This patch restores the enableWebfonts preference, stored inside
the uls-preferences blob. It existed as 'enable-webfonts' in
the past and was removed in
If735a733717596fae03042c5e277bd538bd8501f

Each wiki can be configured to load the fonts by default
using the new global variable $wgULSWebfontsEnabled.
Its default value is true (to load fonts).

This also removes the preference 'uls-enable', recently added in
I71b70d8ee7c3cad7f49b32e5dc494ef4fc1bdb2f

The initialization of ext.uls.webfonts.js is changed as well,
so that minimal webfonts JS library code is loaded,
and the rest is loaded only if a user requests it.

Bug: 60304
Change-Id: I49e812eae32266f165591c75fd67b86ca06b13f0
2014-02-10 17:40:30 +05:30
Kartik Mistry
473dc8536a Normalize the font-family name in browser test
Bug: 57101
Change-Id: I01a787f8576e309d313219bd560ce4be4469c438
2014-02-06 21:07:52 +05:30
Amir E. Aharoni
e9c4e63bc5 Fix the Autonym tests after the removal of the 'end' class
The end class was removed at
https://github.com/wikimedia/jquery.uls/pull/122

Change-Id: I548df1f14025cac0c4a89401474171d0558ff8b1
2013-12-31 12:03:22 +02:00
Zeljko Filipin
f647453a39 Removing pending block for a bug that was resolved
Had to increase timeout that waits for a div to disappear, the default
5 seconds was not enough. Increased timeout also fixes this test that
fails sometimes: http://goo.gl/YXBDAj

Bug: 56885
Change-Id: I2def25828865a21eb321d0d9ea2e57764d86c1a2
2013-12-17 11:50:39 +00:00
Niklas Laxström
b0efed428c Refactor another live preview scenario
But left it disabled because of bug 57967

Bug: 57967
Change-Id: I7b1543f526eac93c9a0200731a722332a7410b06
2013-12-04 12:22:15 +02:00
Niklas Laxström
cdb21c9c49 Refactor two live preview scenarios
Change-Id: I8e0dc62e24f9f86232af6b68dc4809e858aa2367
2013-12-04 12:05:15 +02:00
Niklas Laxström
b04c6f8de2 Refactoring live preview
Change-Id: I351094b8d746d991b1f1d92f3dd097f092e3f0f5
2013-12-03 10:02:22 +00:00
mayankmadan
78152b95c0 Prefer double-quoted strings in Ruby code
Bug: 57597
Change-Id: I12b96411abe255130e156e20fa41eef558460196
2013-11-28 14:25:55 +00:00
jenkins-bot
bbeb82f809 Merge "Remove unneeded () after visit" 2013-11-27 12:09:30 +00:00
Niklas Laxström
11fd508324 Remove unneeded () after visit
Change-Id: I34cccf69812be6e060d3f1dea1199da668e2ca31
2013-11-27 10:03:02 +00:00
Zeljko Filipin
0f331b5b03 Check that elements that do not need it do not use Autonym font
Change-Id: I2a865d61403b5556a8f6d69aa1fe3e10727e87ae
2013-11-27 11:33:44 +02:00
Niklas Laxström
35c4837816 Fixes to failing tests
Ambiguous match of "the selected interface font must be "Systemschriftart"":

Element is no longer attached to the DOM (Selenium::WebDriver::Error::StaleElementReferenceError)

Change-Id: I74d6c8245d413dbf2819a113a19476d9b998d3c4
2013-11-26 10:27:25 +01:00
Niklas Laxström
0f0198ded8 Use existing steps instead of execute_script
Change-Id: Ifb54a9162ac8b4b9c68aea1508081999ea7e7f6c
2013-11-22 12:30:00 +02:00
Amir E. Aharoni
cad5ec8dca A test for saving both ime and font preferences
Change-Id: I091f8db781bf7ea0fd8967c568604402a999356d
2013-11-22 15:43:47 +05:30
Amir E. Aharoni
2923accef7 Fix the autonym test with the new id for Input settings
Change-Id: I3ad6156761c8f4ab5a77165d07c56581a1b4edac
2013-11-22 04:40:25 +00:00
Niklas Laxström
77142fdfa6 Move the steps file back to correct folder
Change-Id: I8f4335c9886ae940645ead3d25f7f1c9381a33f4
2013-11-21 13:23:44 +02:00
jenkins-bot
d9173fa1a6 Merge "Regression test for bug 56913" 2013-11-21 11:16:41 +00:00
Zeljko Filipin
a0ab3a5526 Use page-object waiting API instead of Selenium waiting API
Fixes page-object deprecation warning.

More information:

http://watirwebdriver.com/waiting/
https://github.com/cheezy/page-object/wiki/Ajax-Calls

Change-Id: Ia18339e2fd6b23098b86dd96f3fa9c84f64c28c3
2013-11-21 11:25:24 +01:00
Niklas Laxström
2244518711 Regression test for bug 56913
Changed class to css because multiple classes don't seem to work.
Used _element.text because css selectors seem to return [] by default.

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Change-Id: Ide8c7bd22cc23bb84f24f99faf6b14c2d2ce91de
2013-11-21 11:44:20 +02:00
Niklas Laxström
ded20c61f2 Fix and enable feature Persistent settings
* Reuse existing steps where possible
* Rename steps file to match convention
* Moved unrelated steps to a new file
* Added wait for saving

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Bug: 56885
Change-Id: I480058430696579947187265b940ea46156f1519
2013-11-21 11:08:08 +02:00
Zeljko Filipin
06341f787f Refactored Autonym font feature
Removed old and ugly steps that are no longer used. Introduced one
small and beautiful step.

Fixes three failed Jenkins jobs:

https://wmf.ci.cloudbees.com/view/r-uls/job/UniversalLanguageSelector-co
mmons.wikimedia.beta.wmflabs.org-linux-firefox/128/testReport/(root)/Aut
onym%20font/

Change-Id: I68da4364592514d161996517875a06fd2942ff0f
2013-11-14 11:13:15 +01:00
jenkins-bot
767a6adb5a Merge "Refactor "Open language selector when logged in"" 2013-11-13 12:11:40 +00:00
Niklas Laxström
f884356c15 Refactor "Edit area should use the fonts selected by the user from ULS for a language"
* Removed step which different only in case of one letter
* Removed quotes from few steps
* Fixed the scenario, but marked it as pending due to a bug

Change-Id: Iab160782e73071b543ef550dc7d86171e3636d23
2013-11-13 12:45:46 +02:00
Niklas Laxström
cffbe79195 Refactor "Open language selector when logged in"
Removed tags @uls-in-sidebar-only and @uls-in-personal-only.
We will figure out a better solution.

Alterted the test so that it catches if the language selector is
not visible in the viewport to catch regressions like bug 56937.

Bug: 56937
Change-Id: Ie8a37bf4f38e9c82e0c14736f2bc29e8ec1331ff
2013-11-13 11:51:04 +02:00
Amir E. Aharoni
b0d905a554 Refactored scenario: Edit area fonts should not change on UI language change if the user preferences for edit area font are set
Started in a pairing session Amir and Željko, ended in session Niklas and Željko.

Change-Id: I30ef2b41cfdceda04818f16f06e0071c487b90b6
2013-11-11 10:22:17 +00:00
Niklas Laxström
967683c98e Refactoring Input method menu is not offscreen
Change-Id: Iff83160eb6c99d6109098e431341240a21274665
2013-10-31 13:47:04 +02:00
jenkins-bot
135d1bc2b7 Merge "Refactor Sticky input methods" 2013-10-31 11:42:09 +00:00
Kartik Mistry
ccbef283cd Autonym font integration tests.
Change-Id: I2fbedbf3b93c4410cc9fc765c3f4795d7986bf04
2013-10-31 10:02:56 +05:30
Niklas Laxström
3398a949e3 Refactor Sticky input methods
Change-Id: I20ee4e7b90ec9aaa3155fe2e357cf04388d0994c
2013-10-30 11:50:13 +02:00
Niklas Laxström
891b6977ce Refactoring Applying the live preview of interface font
We renamed get*font to just *font

Change-Id: Ib6992849a2bf927d2e2d465231df58857e506a62
2013-10-29 14:07:45 +00:00
Niklas Laxström
b47a8ac5d3 Refactoring Discarding live preview of interface font
Includes fix for content font as well

Change-Id: Ie97c5d45c6613889975ca6af59c6bd0856d331dc
2013-10-29 14:05:53 +00:00
Niklas Laxström
52372f5857 Refactoring ime tests
Scenarios:
* Input method menu
* Input method indicator is shown
* Unsupported input language (pending)

Added IMEPage

Change-Id: I1f68d177bd05baca6ae8da97364b81a4d851b8b6
2013-10-28 13:29:31 +02:00
Zeljko Filipin
e3c93d17fa Change the assertion back to original state
Bug: 56081
Change-Id: I16a8ee6c4d8aae8778f99f6e0cd0bfc7e0f32b4e
2013-10-25 12:24:57 +02:00
Zeljko Filipin
29ab2467f9 Mark a step as pending since it fails because of a known bug
Bug: 56081
Change-Id: Idfa0f67c95ab6ed2c6e6a3d8fa99d064a8eb871f
2013-10-25 12:19:39 +02:00