Commit Graph

14 Commits

Author SHA1 Message Date
Volker E
d5285655fd styles: Replace 'mediawiki.ui/variables' call with skin variables
- Replacing 'mediawiki.ui/variables.less' `@import`
  with new Codex design tokens as external library. We're using the
  legacy values as UniversalLanguageSelector has been a desktop first
  extension and those values are also used by Vector skin.
  The values replaced are anyways only touching colors, borders or
  transitions which are the same in normal and legacy.
  These will be replaced by skin-aware 'mediawiki.skin.variables.less'
  standard with dependency of UniversalLanguageSelector upped
  to MW 1.42.0.
- Replacing several static values with new Codex design token featuring
  skin variables, in categories `background-color`, `color`,
  `border-*`, `box-shadow`, `opacity` and `transition`.

Note, that this change should result in same rendering of the
extension, only properties that already have an equal token are
replaced.

Bug: T332541
Co-Authored-by: Volker E. <volker.e@wikimedia.org>
Change-Id: Ic563fa84bf8e76fd62f14487924d7d6fd5c1a065
2023-05-04 04:44:44 +00:00
jdlrobson
5890cf27f1 Disable language button background color on modern Vector
Limit this style to sidebar buttons. When skins are not placing it
inside the sidebar (e.g. modern Vector), we should defer to them for
all styling matters. This rule clashes with modern Vector's mw-ui-button
class.

Bug: T296323
Change-Id: I16bdbf8882e37b8727fbf693c904b9c9d1d8820c
2021-11-29 23:28:35 +00:00
jdlrobson
01c7a4fb0b Restrict compact language button styles to legacy Vector
These styles are causing the language button to move downwards
on page load in modern Vector

and legacy Vector.

See T191021#7231088.

Bug: T191021
Change-Id: I9d62ad8a79168bdaebace07fb82f22da4c534b5c
2021-07-22 23:47:01 +00:00
Niklas Laxström
dd8842517e Change ULS content language selector positioning
New Vector introduced a new content language selector trigger. This
code was hardcoding a behavior that works for compact language links
but is not so appropriate for other uses in the skin, which are out
of our control.

This patch aims to be a minimal change to allow other kinds of
behavior without changing the amount of tech debt. This changes
the default ULS dialog behavior to match the requirements shown
in the task. Compact language links specific behavior is retained but
only enabled for the compact language links trigger. The behavior
is chosen depending on the value of isUsingStandaloneLanguageButton().

For future changes, I propose that mw-interlanguage-selector class will
not have any styles attached to it. Whoever creates the trigger would
be in charge of styling it. Ideally that code would also define the
positioning and other behavior, but it is less clear how that can be
abstracted in a nice and decoupled way.

Bug: T276248
Change-Id: I52da6c2f5a1f25d64f322a3c8f6105da3b244b66
2021-03-16 22:36:18 +00:00
Volker E
f5c4fe1826 Remove unnecessary rules and properties
Active state is already covered with `mw-ui-button`. Color needs to
become darker for better contrast ratio when button is toggled.

Change-Id: If888a862c0b642aaa200e8207f3804f76f05b8b0
2020-11-03 13:56:05 +00:00
Volker E
8d54c3faf7 Amend compact links icon to use latest WikimediaUI version
Also amending `color` & `padding` to be closer to button standard appearance and
increase `margin-bottom` to make “Edit links” link not stick to button.

Bug: T170137
Change-Id: Iabb6abfdb8fa69c9f2634b190cb5fa6c005eb17c
2020-11-02 07:00:55 -08:00
Volker E
6ea7307df9 Amend Base10 color and remove (affected) PNG fallbacks
Amending Base10 to slightly darker `#202122` to fulfill WCAG
requirements in connection to Accent50.
Also removing all PNG fallbacks as they are only used in JS-only.

Bug: T248393
Change-Id: I07fa4e23320763a634e5340ab125634842b86454
2020-04-21 11:43:23 +00:00
Ed Sanders
447c09d462 build: Update linters
Change-Id: I45540db95711b461ded3630894bd1f149c24ff19
2017-11-29 15:02:47 +00:00
Volker E
fd0bb2600b Replace outdated colors with WikimediaUI palette ones
Replacing all colors with current WikimediaUI palette ones.
Also:
- changing two files over to LESS in order to
 - make use of central gradient mixin instead of one with
   unnecessary vendor extensions and
 - concatenating selectors in one occurrence.

Bug: T174237
Change-Id: I5d302f29b079f6abdba5abf3b58d6ba254e1a4ac
2017-09-06 13:04:00 -07:00
Isarra
86c636fd0a Fix directionality of ULS CLL and languageselect callouts
when appearing on right side of screen

Languageselect was mostly fixed in 354378, but I forgot the
settings ones, so the triangle just disappears when
switching dialogs currently. This follows up on that and
properly fixes it.

Sidebar callouts now appear toward content regardless of
where they're appearing from, or the language
directionality. Triangles are now consistently alligned to
the top of the callout (same position in languageselect and
compact language links) to avoid issues with it appearing
over a scrollbar.

Sideways callout triangles (carets) are consolidated into a
single rendering approach and mixin across compact language
links and toolbox language selector.

Bug: T161586
Change-Id: I7717e26525ac527ede486796f49083ed40ee7d4f
2017-08-10 23:48:34 -04:00
Santhosh Thottingal
26cfea8ef4 Compact language links: Use smaller callout arrow
Uses equilateral triangle with 16px side.

Bug: T138235
Change-Id: If81342876d59e3041d0ea4029e301c3cc76f6641
2016-07-12 12:17:33 +05:30
Ed Sanders
e6dcdb56c4 Introduce stylelint and make pass
Change-Id: Iaf12e7773f21d42ff59591680abdf248bf121224
2016-05-25 09:24:47 +02:00
Santhosh Thottingal
aca1545513 Compact links: The trigger kept pressed while the panel is open
Bug: T70078
Change-Id: Iaac9d7f2a5ec5da049b2b4c8e88a9f0bc2a91bda
2016-04-22 07:11:33 +02:00
Santhosh Thottingal
cac3e709de Compact links: Add png background image for trigger
Converted the css to less file too.

Change-Id: I2f01c170336b0d19f0dbac10ebd9a3eac769d104
2016-04-19 14:23:04 +02:00