Commit Graph

781 Commits

Author SHA1 Message Date
Santhosh Thottingal
d109bddf20 Compact links: Execute the compact strategies on need basis
We were executing all compacting strategies even when we have
more than enough items as candidates. If the strategy is expensive,
(performance wise) this is a problem.

In this commit, we execute them one by one and stop when we have enough
candidates.

The methods in CompactInterlanguageList class also arranged as
individual function declarations than comma seperated method list.

Change-Id: Idce6489387d139852125f4448d0e192f6a7e1353
2016-07-11 10:58:00 +02:00
Santhosh Thottingal
c4ce628768 Use navigator.languages as fallback for mw.uls.getAcceptLanguageList
Follow up: Ib603f836f59f7078ac5dbb7bbbb3b84ca358cb43
Bug: T137522
Change-Id: Ia5de997fe393ce99a91b16ed397811391a85bc59
2016-06-14 04:55:34 +00:00
Santhosh
09d4c149ca Merge "Show badges in ULS language list" 2016-06-09 12:01:04 +00:00
Niklas Laxström
2a6b4d0fc2 Show badges in ULS language list
Update jquery.uls to ae9dda23b71aa76fbbc13f5650

Bug: T131233
Change-Id: I7c7bafccc7d63c0a97c98b81a5b53b48c9afa527
2016-06-09 15:12:39 +05:30
Niklas Laxström
9fc215866a Have the background for input settings not run to the edge of the dialog
Bug: T136273
Change-Id: Iddc5233d840cd6f2c3e4393ea221b6882d03c531
2016-06-02 05:47:38 +00:00
Niklas Laxström
0b89c27678 Give language selection buttons more space
Let them assume normal size with regular padding. In the case that
the buttons do not fit one line, some will overflow to the second
line. In my opinion that looks less ugly than irregular padding
and truncated language names.

Bug: T136273
Change-Id: I26dd7745ac03e1b940348b318d74d0a2bd27e1a3
2016-06-02 05:47:25 +00:00
jenkins-bot
6585dc5285 Merge "Cleanup settings-* rules in ext.uls.css" 2016-06-02 04:05:07 +00:00
Niklas Laxström
0784540c40 Simplify code using .one
Change-Id: I84fb5e0ade474738ff6a05c2304de351a2476186
2016-05-31 09:21:51 +05:30
Niklas Laxström
791cefeec6 Remove redundant mw.loader.using
The only caller is already loading the exact same modules right
before calling these functions.

Change-Id: I71bc682f88c45e8ff20e032c7e5ee2dc3f517baf
2016-05-30 17:07:22 +02:00
jenkins-bot
31e41a1559 Merge "Remove border-radius: no border on this element" 2016-05-30 10:51:23 +00:00
jenkins-bot
7294c62c1e Merge "Remove excessive 5% left-padding and replace with consistent padding" 2016-05-30 10:51:20 +00:00
jenkins-bot
4672ba47c9 Merge "Remove unnecessary div specification from style rule" 2016-05-30 10:45:41 +00:00
jenkins-bot
2bf9ebabd8 Merge "Fix the border of font selectors" 2016-05-30 09:39:35 +00:00
jenkins-bot
9b3c20af30 Merge "Remove useless style rule" 2016-05-30 09:35:24 +00:00
jenkins-bot
dfc5b703b8 Merge "Set base font size for ULS dialogs to ensure consistent size" 2016-05-30 09:33:25 +00:00
jenkins-bot
229c3a7b2d Merge "Remove cursor: pointer for links." 2016-05-30 08:59:42 +00:00
Niklas Laxström
a0859320ea Cleanup settings-* rules in ext.uls.css
`font-size: 11pt` was always overrules by another style. Removed it
and moved rest of settings-* styles to languagesettings.css where
they belong.

Bug: T136273
Change-Id: I4d8fa6ff9f4fc2b6e2ee577d795a28cb8197b3cb
2016-05-30 06:22:30 +00:00
Niklas Laxström
4c3c0421ce Remove styles now in jquery.uls core
Bug: T136273
Change-Id: Ib65928b029a86eba91b1dfbc4527c9effa8d2449
2016-05-26 14:38:17 +02:00
Niklas Laxström
d04e49b891 Remove cursor: pointer for links.
This has no effect as far as I can see because that is the default.

Bug: T136273
Change-Id: I57c5aa9d102559d9086291f90c2a82e2b7a09ff4
2016-05-26 14:08:09 +02:00
Niklas Laxström
3ee9ff5720 Fix the border of font selectors
The top border was shorter than the others, fixed by using CSS
applied to the first element instead of the parent.

Bug: T136273
Change-Id: Ic894ef99ef2c88a23d6db65b68327fd903473038
2016-05-26 11:57:24 +02:00
Niklas Laxström
f6d06d9500 Remove useless style rule
Grid overrides the margin, so this had no effect.

Bug: T136273
Change-Id: I1f079eaf25c4798fe920cba9a97f56f6d5e307c6
2016-05-26 11:48:23 +02:00
Niklas Laxström
44f405cef1 Set base font size for ULS dialogs to ensure consistent size
The dialogs had tiny text in Monobook skin.

Bug: T136273
Change-Id: I8d00bbd6eb560e63dc4d64375ca0dbb279f6c9df
2016-05-26 09:38:11 +00:00
Niklas Laxström
2eb2c80264 Remove border-radius: no border on this element
Bug: T136273
Change-Id: I19c89db8ebc3ae2695bc44a6eff27e1c558fd049
2016-05-26 10:32:52 +02:00
Niklas Laxström
988372204b Remove excessive 5% left-padding and replace with consistent padding
This gives more space to display/input setting panels and is more
consistent with the padding on the left-side menu as well.

Bug: T136273
Change-Id: I5c0e5e351e370c4c0b19783edc8278250ca3ca76
2016-05-26 10:32:41 +02:00
Niklas Laxström
9f3e0860a9 Remove unnecessary div specification from style rule
Bug: T136273
Change-Id: Ib4677e578e8f5eb7da36bb166d77a210cf1d3313
2016-05-26 10:32:31 +02:00
Ed Sanders
e6dcdb56c4 Introduce stylelint and make pass
Change-Id: Iaf12e7773f21d42ff59591680abdf248bf121224
2016-05-25 09:24:47 +02:00
jenkins-bot
9eedc358e6 Merge "Separate ULS previous interface language from previously selected languages" 2016-05-25 06:13:13 +00:00
Niklas Laxström
5dc797617d Remove ext.uls.buttons
All users of this module have migrated to mediawiki.ui or equivalent.

Change-Id: I5579c012807d31fceb51b7ce0e687a128c791d72
2016-05-24 10:18:28 +02:00
Niklas Laxström
b2b75b15eb Drop eot from supported webfont formats
IE9+ which is lowest that MediaWiki still supports is supposed to
support both ttf and woff par some exceptions.

This reduces uncompressed repo size almost 4000 bytes.

Change-Id: If80f4ec898d86d5fd4cf873d0d86245e66da2f0b
2016-05-24 08:06:11 +02:00
jenkins-bot
7708b8d2ff Merge "Use FormatJson in font repo generator script" 2016-05-24 05:01:41 +00:00
jenkins-bot
756b80d8a6 Merge "Increase the number of stored previously selected languages to 9" 2016-05-24 04:43:34 +00:00
jenkins-bot
4b1056133f Merge "Make previous languages have most recent in the beginning" 2016-05-24 04:38:49 +00:00
Niklas Laxström
679f616fb2 Remove extra empty lines
Change-Id: I4f4e941dc12b4730bdacf35e6d80cd306a88cf01
2016-05-23 17:15:18 +02:00
Niklas Laxström
e3c2950c04 Separate ULS previous interface language from previously selected languages
Now that Compact Language Links also started to add to this list, ULS would
show incorrect language change tooltip notifications. ULS interface language
selection will still keep updating the list of previously selected languages.

Refactored the code a bit: 1) created minimal Store that wraps around plain
localStorage, since mediawiki.storage cannot be used yet. 2) Inlined the
userHasChangedLanguage function to new initTooltip function. 3) Split parts
of the huge initInterface to new initTooltip and initIme functions for
increased readability. 4) Solved a TODO for moving language change recording
out of the tooltip showing code.

Change-Id: If8478a59168d89264f4d46938ac865c0c9a04f25
2016-05-23 15:15:44 +02:00
Niklas Laxström
fa7f7e8b57 Increase the number of stored previously selected languages to 9
Discussion about the magic number in the task.

Bug: T135487
Change-Id: I5d0900f191cf277faa19d73de9cf393216d5e6ea
2016-05-23 12:50:06 +00:00
Niklas Laxström
4f82a8650a Make previous languages have most recent in the beginning
This is already expected by the callers. Added addPreviousLanguage
to make updating the list easier.

Change-Id: Ie4f888235ea4de4a2ce6bf5a9f24955e423e8c48
2016-05-23 14:50:02 +02:00
Niklas Laxström
e607466313 Use FormatJson in font repo generator script
The benefit of this is that '/' is no longer escaped, making
ext.uls.webfonts.repository.js file 376 bytes smaller. I expect
that the difference in compressed size is neglible.

Change-Id: I77c0b88fa23f2245f09615c354546b6a9ebf650c
2016-05-23 14:33:37 +02:00
jenkins-bot
43782e8635 Merge "Add some global fallbacks to compact language links" 2016-05-23 11:43:46 +00:00
jenkins-bot
384b109362 Merge "Update jquery.uls and adapt styling" 2016-05-23 11:09:01 +00:00
Niklas Laxström
e054af704c FontRepoCompiler now adds hash suffix to font paths
This is now new standard way of doing this in MediaWiki.

Since this makes the font repo bit longer, compensated by no
longer providing version information, which also simplifies the code.
Uncompressed increase is 542 bytes.

Depends on https://github.com/wikimedia/jquery.webfonts/pull/45

Bug: T135806
Change-Id: I1921115fc1abc20e6e756044c0a84a9fe4133884
2016-05-23 09:32:57 +02:00
Niklas Laxström
021ceadc85 Add some global fallbacks to compact language links
Bug: T135366
Change-Id: I75cc58f79cb818d8330120d996d67c6b183c0843
2016-05-20 14:51:47 +02:00
Niklas Laxström
4ff7d5adf8 Add tooltip to the "more languages" action to provide better context
Bug: T135224
Change-Id: I3c5d909ff334182e25b48fd3917260087ee276ef
2016-05-19 08:56:04 +00:00
Niklas Laxström
a19e8c0dba Update jquery.uls and adapt styling
jquery.uls.compact module is kept for now as some other
extensions depend on it. But it does not do anything
anymore.

There are some styles which should be in jquery.uls
upstream, but given the current state that is easiest
done in a follow-up later.

The main change is that language selection is now
compact by default: no heading etc.

Includes style changes for the dialogs, and especially
for the new position of the callout caret.

Bug: T85519
Change-Id: Iade8005439b4f58ab241752f69a5365d8bb88d2c
2016-05-18 11:40:58 +02:00
Santhosh Thottingal
cbb46f7451 Compact language links: Delay loading of jquery.uls module
Load jquery.uls only when the trigger is clicked.
Reduces the initial footprint by 63.9 KB (uncompressed)

Bug: T135210
Change-Id: I972cb6ea1794485917ea530f7abe68bdddc2014f
2016-05-17 14:55:51 +05:30
Santhosh Thottingal
a5034fa95f Avoid references to jquery.uls RL module from ext.uls.init
Checks to see if language is supported can be also done using
jquery.uls.data

Bug: T135210
Change-Id: Ib6b0d31b33be10b38aba713c3c4ba5370a27a8f4
2016-05-17 11:50:15 +05:30
Santhosh Thottingal
a2cfd0287f Add WOFF2 version of fonts
Modern browsers will use woff2, which has smaller size than woff

Updated the README in the font repository explaining how different
file formats are produced.

Bug: T128291
Change-Id: I81c5380fdbf0ff76142b67cf8fce9db20e8164fa
2016-05-11 10:31:01 +05:30
Niklas Laxström
146949ce43 Fix fail in 1bc3f3b
Assignment got lost, so caching did not work.

Change-Id: If7f6df5b6c6d6156894803670263f34f2850a29a
2016-05-09 20:12:46 +02:00
Santhosh Thottingal
1bc3f3b065 Compact links: Avoid duplicate call of filterByCommonLanguages
It re-triggers mw.uls.getFrequentLanguageList(),
getPreviousLanguages() and localstorage read.

In this patch the result was saved and reused.

Bug: T122341
Change-Id: I14839eb611cd3e995e8d8ab729ee3f714840f9ad
2016-05-09 14:31:34 +05:30
Nikerabbit
b490829957 Merge "Compact links: Simply use the widget pattern instead of plugin" 2016-05-03 08:32:14 +00:00
Santhosh Thottingal
4150d24e67 Compact links: Simply use the widget pattern instead of plugin
We don't need plugin pattern here since it is not meant for a use
in multiple contexts. Code simplified.

Change-Id: Iee86069aaa82f5a9ab3a856c19360e9ea89211ad
2016-05-03 08:53:58 +05:30