Commit Graph

37 Commits

Author SHA1 Message Date
Željko Filipin
513cfb87cf Fixed Style/HashSyntax RuboCop offense
Bug: 117989
Change-Id: Iecdcc3202adf9458f11310d188ab93176b03194f
2015-11-18 12:04:04 +01:00
Željko Filipin
22e8762cec Fixed Style/StringLiterals RuboCop offense
Bug: 117989
Change-Id: I82086ebd56ace9f85c521ef53b67e5e4bae9d607
2015-11-18 12:00:36 +01:00
Željko Filipin
81e918780a Fixed Style/Tab RuboCop offense
Bug: 117989
Change-Id: Ic4d9769df7c0ca459a7710b414d0738601107461
2015-11-18 11:59:32 +01:00
Željko Filipin
0aa649e084 Update mediawiki_selenium Ruby gem to the latest version
Bug: 117976
Change-Id: I567880afcf7dc5d70e6d4edef1db16d7923ae31c
2015-11-18 11:50:39 +01:00
Santhosh Thottingal
27771fdeaf Restore enableWebfonts pref and remove uls-enable
This patch restores the enableWebfonts preference, stored inside
the uls-preferences blob. It existed as 'enable-webfonts' in
the past and was removed in
If735a733717596fae03042c5e277bd538bd8501f

Each wiki can be configured to load the fonts by default
using the new global variable $wgULSWebfontsEnabled.
Its default value is true (to load fonts).

This also removes the preference 'uls-enable', recently added in
I71b70d8ee7c3cad7f49b32e5dc494ef4fc1bdb2f

The initialization of ext.uls.webfonts.js is changed as well,
so that minimal webfonts JS library code is loaded,
and the rest is loaded only if a user requests it.

Bug: 60304
Change-Id: I49e812eae32266f165591c75fd67b86ca06b13f0
2014-02-10 17:40:30 +05:30
Kartik Mistry
473dc8536a Normalize the font-family name in browser test
Bug: 57101
Change-Id: I01a787f8576e309d313219bd560ce4be4469c438
2014-02-06 21:07:52 +05:30
Amir E. Aharoni
e9c4e63bc5 Fix the Autonym tests after the removal of the 'end' class
The end class was removed at
https://github.com/wikimedia/jquery.uls/pull/122

Change-Id: I548df1f14025cac0c4a89401474171d0558ff8b1
2013-12-31 12:03:22 +02:00
Zeljko Filipin
f647453a39 Removing pending block for a bug that was resolved
Had to increase timeout that waits for a div to disappear, the default
5 seconds was not enough. Increased timeout also fixes this test that
fails sometimes: http://goo.gl/YXBDAj

Bug: 56885
Change-Id: I2def25828865a21eb321d0d9ea2e57764d86c1a2
2013-12-17 11:50:39 +00:00
Niklas Laxström
b0efed428c Refactor another live preview scenario
But left it disabled because of bug 57967

Bug: 57967
Change-Id: I7b1543f526eac93c9a0200731a722332a7410b06
2013-12-04 12:22:15 +02:00
mayankmadan
78152b95c0 Prefer double-quoted strings in Ruby code
Bug: 57597
Change-Id: I12b96411abe255130e156e20fa41eef558460196
2013-11-28 14:25:55 +00:00
Zeljko Filipin
0f331b5b03 Check that elements that do not need it do not use Autonym font
Change-Id: I2a865d61403b5556a8f6d69aa1fe3e10727e87ae
2013-11-27 11:33:44 +02:00
Niklas Laxström
35c4837816 Fixes to failing tests
Ambiguous match of "the selected interface font must be "Systemschriftart"":

Element is no longer attached to the DOM (Selenium::WebDriver::Error::StaleElementReferenceError)

Change-Id: I74d6c8245d413dbf2819a113a19476d9b998d3c4
2013-11-26 10:27:25 +01:00
jenkins-bot
d9173fa1a6 Merge "Regression test for bug 56913" 2013-11-21 11:16:41 +00:00
Zeljko Filipin
a0ab3a5526 Use page-object waiting API instead of Selenium waiting API
Fixes page-object deprecation warning.

More information:

http://watirwebdriver.com/waiting/
https://github.com/cheezy/page-object/wiki/Ajax-Calls

Change-Id: Ia18339e2fd6b23098b86dd96f3fa9c84f64c28c3
2013-11-21 11:25:24 +01:00
Niklas Laxström
2244518711 Regression test for bug 56913
Changed class to css because multiple classes don't seem to work.
Used _element.text because css selectors seem to return [] by default.

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Change-Id: Ide8c7bd22cc23bb84f24f99faf6b14c2d2ce91de
2013-11-21 11:44:20 +02:00
Niklas Laxström
ded20c61f2 Fix and enable feature Persistent settings
* Reuse existing steps where possible
* Rename steps file to match convention
* Moved unrelated steps to a new file
* Added wait for saving

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Bug: 56885
Change-Id: I480058430696579947187265b940ea46156f1519
2013-11-21 11:08:08 +02:00
Zeljko Filipin
06341f787f Refactored Autonym font feature
Removed old and ugly steps that are no longer used. Introduced one
small and beautiful step.

Fixes three failed Jenkins jobs:

https://wmf.ci.cloudbees.com/view/r-uls/job/UniversalLanguageSelector-co
mmons.wikimedia.beta.wmflabs.org-linux-firefox/128/testReport/(root)/Aut
onym%20font/

Change-Id: I68da4364592514d161996517875a06fd2942ff0f
2013-11-14 11:13:15 +01:00
Niklas Laxström
f884356c15 Refactor "Edit area should use the fonts selected by the user from ULS for a language"
* Removed step which different only in case of one letter
* Removed quotes from few steps
* Fixed the scenario, but marked it as pending due to a bug

Change-Id: Iab160782e73071b543ef550dc7d86171e3636d23
2013-11-13 12:45:46 +02:00
Amir E. Aharoni
b0d905a554 Refactored scenario: Edit area fonts should not change on UI language change if the user preferences for edit area font are set
Started in a pairing session Amir and Željko, ended in session Niklas and Željko.

Change-Id: I30ef2b41cfdceda04818f16f06e0071c487b90b6
2013-11-11 10:22:17 +00:00
Kartik Mistry
ccbef283cd Autonym font integration tests.
Change-Id: I2fbedbf3b93c4410cc9fc765c3f4795d7986bf04
2013-10-31 10:02:56 +05:30
Niklas Laxström
891b6977ce Refactoring Applying the live preview of interface font
We renamed get*font to just *font

Change-Id: Ib6992849a2bf927d2e2d465231df58857e506a62
2013-10-29 14:07:45 +00:00
Niklas Laxström
b47a8ac5d3 Refactoring Discarding live preview of interface font
Includes fix for content font as well

Change-Id: Ie97c5d45c6613889975ca6af59c6bd0856d331dc
2013-10-29 14:05:53 +00:00
Niklas Laxström
48a5772e9e More refactoring ULS font selection tests
Change-Id: I6595e279657948265c45407be2c01a4587fdbc94
2013-10-25 11:30:47 +02:00
Zeljko Filipin
f45d5bfcd5 Refactoring tests to make them more robust
Fixed typo in feature description.
Merged two background steps since the last one did not have any actions
that could be done manually.
Removed assertions from a "given" (login) step. We already extensively
test logging in. If this extension needs login tests, they should go to
a separate feature file.
Moved methods from steps file to page file, following page object
pattern.

Change-Id: Ic5250970362718f5ed887c9ac8fd56948724b210
2013-10-23 09:01:28 +00:00
Amir E. Aharoni
eff4f8960d Edit area monospace font test
bug: 53734
Change-Id: Ia4abf6a47a18605c5a28f6f57aa8841584285f37
2013-10-21 23:25:20 +03:00
Zeljko Filipin
7706d97c8a Renamed ULSPage to PanelPage
To make class name consistent with file name

Change-Id: If4d0f0a24d2534c9b73cc6cbb0ee14ab8c124ed9
2013-09-26 12:32:41 +02:00
Niklas Laxström
2d62e3e7f7 Simplify test code
Change-Id: I65c3edc85ee8619c7e77cca7622e7025799bdcad
2013-09-17 14:38:16 -07:00
jenkins-bot
a7904a6d01 Merge "Make more tests pass in sandbox.translatewiki.net" 2013-09-06 12:44:05 +00:00
cmcmahon
813271b8a9 Wait longer, so the preference is saved.
Reported as bug 53772.

Change-Id: I8a0d6ae9d3cec06f953e6bb35abb9370e5551eec
2013-09-05 21:09:59 +00:00
Niklas Laxström
bcb2dd8b82 Make more tests pass in sandbox.translatewiki.net
* When ULS is in personal, cancel opens the language selector
  again but apply doesn't.
* Created separate steps for testing the ULS trigger in personal
  position, different behavior with different configuration.

Change-Id: Ifb7f101f2bfacd32c11cba69e7f2c01fe9bd9bb7
2013-09-04 09:37:28 +03:00
Santhosh Thottingal
3af403fee5 Make the cancel and apply button applicable for all modules
If a user does changes in module A, does not save or cancel,
goes to module B, does some changes, moves to other modules,
and finally presses Apply, all changes should get saved.

Similarly, if a user cancels, all changes should get cancelled.

This required moving the cancel and apply button outside of modules
and managed by the language settings framework.

Modules get mw.uls.settings.apply or mw.uls.settings.cancel triggers
to do whatever they want to do on apply or save.

Includes some refactoring related to this.

Bug: 53256
Change-Id: I7d773d33a980a78604b36e39bf96a5686870124e
2013-09-02 17:03:13 +02:00
Niklas Laxström
34146ea023 (bug 49738) Use correct name for wiki content language
Happens when anonymous user cannot change language, and the
language of the translation differs from the content language.

Change-Id: Ie4f15f1813eec992cfe060baf9cd7dcb5f8a0d95
2013-08-30 12:45:02 +03:00
Niklas Laxström
53f19e9f70 Add test for language live preview cancellation
Change-Id: I4880667df23301f4235a05df575fb84554c17303
2013-08-30 10:47:01 +03:00
Niklas Laxström
773b8f42e6 Fix more tests for phantomjs
As a bonus got rid of JavaScript call.

Refactored uls-position code to a method.

Change-Id: I1df384a02909d430c12225525d5722a0520177ee
2013-08-30 10:47:01 +03:00
Niklas Laxström
a6e3ec586e Make tests pass in phantomjs
Change-Id: I0cb094b8a350b716cfb7b50ea6e370fd39fff1d6
2013-08-28 18:44:23 +03:00
Niklas Laxström
3bd4bb4f03 Refactor ULS tests to reduce duplication and repetition
Change-Id: I96f1594f1b4d1960da9a8bc21e2a5c4727497b10
2013-08-28 14:08:17 +03:00
Niklas Laxström
d695b21381 Add new scenarios for font changes
There is currently some duplication between the various page objects
and other code. Those should be cleaned up incrementally.

Change-Id: I592829a00ca65bbecd5399b773c885c764c1cc06
2013-08-27 16:35:23 +03:00