Commit Graph

981 Commits

Author SHA1 Message Date
Santhosh Thottingal
e9ab300889 Fix: ULS popup moves to sidebar if opened from ime menu
Issues fixed:
Incorrect position of ULS when accessed from more languages button
of input/display settings, when language settings opened from ime
menu.

Arrow(callout) appearing for ULS when opened from more languages
button of input/display settings, when language settings opened from ime
menu.

Used a class 'callout' to mark whether windows need callout arrow or not.

Bug: 49060
Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
2013-06-07 14:26:46 +00:00
Santhosh Thottingal
6a9b31ad26 Use smooth scrolling for the windows when not in viewport
Change-Id: I94591d17ba023d9a13e2436ddebfd0209e076845
2013-06-07 14:26:31 +00:00
Santhosh Thottingal
84355a422d On show of language settings, update the panel
Settings changed using other UIs will not be updated unless we refresh
the settings panel.

Bug: 49148
Change-Id: Ia7cd8c91e59360c80eb72fdf0a966bdb3ce52d27
2013-06-07 14:25:39 +00:00
Santhosh Thottingal
c9aa1f1130 Correct the loop logic for language buttons
It is possible that the count reach more than  SUGGESTED_LANGUAGES_NUMBER
before it reach the

languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER

check. This will cause the loop to run for all languages.

Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184
2013-06-06 06:36:36 +00:00
jenkins-bot
f16c42ef71 Merge "Workaround for border-radius due to bug 49074" 2013-06-04 13:08:24 +00:00
Santhosh Thottingal
18fe9e8b86 Fix: Uncaught TypeError: Cannot read property 'shown' of undefined
Bug: 49103
Change-Id: Iecaa078835777625eca5d35dbb6ece19de1e8b29
2013-06-04 17:25:16 +05:30
jenkins-bot
c3ee636c17 Merge "Hide ULS trigger from unsupported browsers" 2013-06-04 10:34:15 +00:00
jenkins-bot
c45100ca29 Merge "Introduce Api for loading jquery.i18n json files" 2013-06-04 10:31:52 +00:00
Niklas Laxström
0c53c38304 Hide ULS trigger from unsupported browsers
For position=sidebar, the dummy "in other languages" section is
visible in the same manner as it is to browsers without JavaScript.

Bug: 49028
Change-Id: I931a2e904b37c754f63bfe5feb2d98bfe6c2747b
2013-06-04 10:26:57 +00:00
Santhosh Thottingal
ec0ea0407d Introduce Api for loading jquery.i18n json files
To avoid CORS issue with old browsers

Bug: 45958
Change-Id: I37638e06f21ab573c9ce37a4e9fb20bc763ac98f
2013-06-04 10:21:32 +00:00
jenkins-bot
47019d27aa Merge "Huge icons in language settings" 2013-06-04 10:11:41 +00:00
Pau Giner
6075f79871 Huge icons in language settings
Graphic assets have been modified so hat they are of the size at which
they are displayed. This makes them safer for browsers not supporting
background-size property.

Bug: 49107
Change-Id: Ifdce9ff5034e2b11d3e1dd24ac649cb99a151312
2013-06-04 10:09:18 +00:00
jenkins-bot
b5ad1c0514 Merge "(bug 49106) Keyboard icon misaligned in Firefox" 2013-06-04 09:50:24 +00:00
Pau Giner
62385075c7 (bug 49106) Keyboard icon misaligned in Firefox
Fixed positioning to avoid the use of float which was problematic in Firefox.
The current solution uses absolute positioning.
Extra padding has been added to the label next to it to avoid the text to overlap.

Change-Id: I82c69fa524f05262b60928fc4ba09104c6d05c2c
2013-06-04 11:40:56 +02:00
Niklas Laxström
979c2da418 Workaround for border-radius due to bug 49074
Change-Id: I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c
2013-06-04 09:31:51 +00:00
Amir E. Aharoni
1a17ef392d Properly save back-up preferences for repeated canceling
Before this patch, this scenarios didn't yield the expected result:

1) Disable IME, click Apply 2) Enable IME, click Cancel

The expected result is that IME would be disabled, but it was enabled.

This patch re-stashes the preferences when they are saved, so
the last saved preferences are loaded when pressing Cancel.

Change-Id: Ic7abdab165e367d970e6568ba69b25bf7d4f675a
2013-06-04 12:00:21 +03:00
Amir E. Aharoni
361eb95f33 Make "Cancel" reset preferences and "Apply" save and close
Bug: 48898
Change-Id: I9f5444ffd57ddf46d197ebdb23a18c0c4600b196
2013-06-04 10:42:29 +03:00
Santhosh Thottingal
8640964f95 Clicking on the 'Apply Settings' does not close the ULS panel
Bug: 48898
Change-Id: I0c05a9a1be14c1036110f84c7a0080b98f93ee1d
2013-06-03 15:10:38 +05:30
jenkins-bot
56d719ec50 Merge "Make sure languages section is visible when adding ULS cog icon" 2013-06-03 09:01:06 +00:00
Santhosh Thottingal
d1988bb3c7 Blacklist old browsers
Blacklist browsers not supporting boxModel

Change-Id: I19bd7e3dbaec2454d8512e5d6f394c21fb6ce5cd
2013-06-03 08:51:04 +03:00
Santhosh Thottingal
2a6cb597f5 Position the language settings in RTL with interlanguage position
The left position of the window was wrong.

Change-Id: I3353d930cb8251021f206ed5f1a0821d17059fe8
2013-06-03 05:44:55 +00:00
Santhosh Thottingal
73716f3f67 Remove lot of scroll to view related code
Just use javascript scrollIntoView to do that.
Also remove duplication of code related to this

Change-Id: Ied1235a85f4fe2d99afa127737979c24d3591118
2013-06-03 05:44:17 +00:00
Santhosh Thottingal
11fc0347ea Make sure languages section is visible when adding ULS cog icon
Make sure element #p-lang shown.
Bug: 49005

Change-Id: I4cc238f87fdce0c5813b82516599ba3c0d3bf44c
2013-05-31 11:04:16 +05:30
jenkins-bot
44dbfbba4f Merge "Show input methods for selected language correctly" 2013-05-29 11:49:49 +00:00
Santhosh Thottingal
66e1fab8a8 Exclude does not apply if the editfont preference is default
'editfont' == 'default' means 'Browser default' font setting. We can
apply webfonts there.

Change-Id: Iff522e0016d8284dc785580e6eb3dd2967c58289
2013-05-29 15:23:34 +05:30
Santhosh Thottingal
931cb6dc22 Do not use "System" as a font
Regression from I62860f9d62538915628ad21e5d904e56bdcc9430
Bug: 48871

Change-Id: I72f5c40739928244cd402c000b48af9911c5b0c7
2013-05-28 21:15:47 +05:30
jenkins-bot
e7b010c917 Merge "Don't show anonymous users tipsy with setlang" 2013-05-28 13:43:37 +00:00
jenkins-bot
37dcbe5cd2 Merge "Clarify labels for input methods" 2013-05-28 13:34:41 +00:00
Amir E. Aharoni
30aaafcaaa Don't show anonymous users tipsy with setlang
Bug: 47970
Change-Id: Ib7744b2d5f826ed781fff8359b5a4482b0bda522
2013-05-28 06:14:55 +00:00
jenkins-bot
c4ba77a6f3 Merge "Allow ULS language settings accessed from user preference screen." 2013-05-28 06:14:13 +00:00
Siebrand Mazeland
fb459cfd88 Clarify labels for input methods
Bug: 48536
Change-Id: I12fa43a9402f64f6da7ba040ff37363a2cc027bb
2013-05-28 07:54:27 +02:00
Santhosh Thottingal
8b46d34004 Allow ULS language settings accessed from user preference screen.
Adds a link in 'personal/i18n' section of user preferences

Bug: 47240
Change-Id: I04d1ea7d36db45f9a0af04e11dade9ae0b524e8e
2013-05-27 16:33:40 +03:00
Santhosh Thottingal
65711c312d Fix cancel behaviour of display settings
Font selection becomes persistent despite cancelling it
Bug: 47976

Change-Id: Iea4b65a8a13da3cb4a86f5b6521d62cb1372b42a
2013-05-27 18:24:14 +05:30
Santhosh Thottingal
8655504371 Refactor interface integration code
Reduce document.ready code by moving functions outside and grouping
tooltip related code to a function.

Also remove window and document from wrapper anon function since
browser: true is defined in .jshintrc

Bug: 48156
Change-Id: I7228285cdcb33b915e96e7e2c59e4dbc90f5fc96
2013-05-27 12:35:49 +00:00
jenkins-bot
702197a8a7 Merge "Get the saved font using the fontSelector defined in mw.webfonts.setup" 2013-05-27 11:05:45 +00:00
jenkins-bot
4861ff1ea7 Merge "Remove document from anon cover function" 2013-05-27 11:02:34 +00:00
Amir E. Aharoni
282b6c7644 Show input methods for selected language correctly
Remove redundant calls to prepareInputmethods
and redundant button styling.

Rename firstLanguauge to the clearer currentLanguage.

Switch checking for imeLanguage and the prereferences language
to make sure that the last one is shown.

Done in pair programming with Santhosh.

Bug: 48163
Change-Id: Ie8441f29eb20caa05534c8589481a26cb415a27f
2013-05-27 13:38:32 +03:00
Santhosh Thottingal
540ada592d Access i18n json files from same domain for IE8 and IE9
IE8 and IE9 does not support ajax with CORS. So make sure they
load json files from same domain.
See http://bugs.jquery.com/ticket/8283

Bug: 45958
Change-Id: I8442a5efbd4ca7db0f0a407ff94772ea8e213b29
2013-05-27 09:54:03 +00:00
Santhosh Thottingal
f23666a15a Get the saved font using the fontSelector defined in mw.webfonts.setup
Also make sure that correct language is passed to the getFont
It was wrong in current version - UI language was passed always
(introduced in a refactoring to avoid code duplication for content
and ui language- commit: 98bb1c200c )

Change-Id: I62860f9d62538915628ad21e5d904e56bdcc9430
2013-05-27 14:43:30 +05:30
Santhosh Thottingal
164568e516 Remove document from anon cover function
jshintrc has browser:true setting

Change-Id: I30acfb63f132473611be9da4edf12c3b6ea42523
2013-05-27 13:59:36 +05:30
jenkins-bot
c4536a063c Merge "Remove webfonts enabling checkbox and associated preference" 2013-05-27 06:30:31 +00:00
jenkins-bot
c4e631512c Merge "Remove unused resources" 2013-05-27 06:08:07 +00:00
Amir E. Aharoni
2ef2376bfe Remove webfonts enabling checkbox and associated preference
Bug: 48535
Change-Id: If735a733717596fae03042c5e277bd538bd8501f
2013-05-27 07:59:45 +03:00
jenkins-bot
3066c79174 Merge "Display notification when disabling input methods from keyboard icon menu" 2013-05-26 14:15:41 +00:00
Niklas Laxström
d10f685eb9 Remove unused resources
Change-Id: I80eb3dc02e99fd0dda5990a3a690d897e054cfcd
2013-05-24 18:51:28 +00:00
Santhosh Thottingal
170be2068e Reset the dirty bit after preferences are saved.
Bug: 48703
Change-Id: I5768c455324396d503646a4c803e9d512f47c0e1
2013-05-23 15:36:33 +05:30
jenkins-bot
bba4896df1 Merge "Optimize images" 2013-05-23 06:49:28 +00:00
Santhosh Thottingal
cea4d81766 Display notification when disabling input methods from keyboard icon menu
Bug: 48534
Change-Id: Id6c1cb22cb09a226cfcc84d597724e5d803392f3
2013-05-23 12:15:49 +05:30
Amir E. Aharoni
4221b97ab2 Hide the ULS trigger for users who disabled JS
Bug: 42500
Change-Id: I297a8d3bb9d9031e21dd6842f5d27dd54f469c29
2013-05-22 16:04:20 +03:00
Santhosh Thottingal
3cdcd26b63 Do not show ULS in weird positions
ULS was shown relative to input field position. That will not work
always. Show it in default position - center of screen.

Change-Id: I5fd9f10d955322abd2623ce8b88792b391553dcd
2013-05-22 15:48:59 +03:00