Commit Graph

113 Commits

Author SHA1 Message Date
Santhosh Thottingal
7c4646a059 Remove href=#, to fix Bug 41988
Change-Id: I8eacaa452eb71d237fc671aa63c4707b8e14a83f
2012-11-19 10:59:26 +05:30
Santhosh Thottingal
0d11c4ef77 Updated repository with font variants
Change-Id: Iddb5dafd60a527b7ce4cb9a9a96e48f460d5fcdf
2012-11-14 15:28:58 +05:30
Santhosh
1c6876ba8b Merge changes I83625c21,I93b3329d
* changes:
  Remove empty @returns comment
  Fix possible variable pollution
2012-11-14 05:25:09 +00:00
Siebrand Mazeland
57a30afc55 Fix some JSHint issues
Change-Id: Iecb1f2d2d326260075755070882b7706c1ae7db4
2012-11-12 07:51:39 +01:00
Siebrand Mazeland
9ff4a4c343 Remove empty @returns comment
Change-Id: I83625c21a0de492004a1f20337a8288de0e49fd3
2012-11-12 07:46:38 +01:00
Fomafix
14aef6d7e1 Fixed the bug 42013 - 'class' as property name
Applied the patch given in bug report

Change-Id: I01ded82bd426edf630561b013d7cafe46130d697
2012-11-12 00:28:35 +05:30
Siebrand Mazeland
98d7a8d9f9 Reformat code.
Change-Id: Ic0a5b37fa01b4a13023e66af0518ea94919ee880
2012-11-11 10:34:10 +01:00
Ershad K
b37b33e02f Fixed Bug 39832 - Cancel / Apply button on Display settings
Change-Id: Ie536dbe1615db98c201b8c7fd1b5b58647bb1199
2012-11-11 12:35:40 +05:30
Niklas Laxström
3c9e7249a8 Geoclient fixes for https and WMF
* Don't call freegeoip on https, it wont work
* Use Geo instead of GEO like WMF

Change-Id: I9ebdd9f3518e15e70122a9c8c8d64240d5e44c5b
2012-11-10 07:15:07 +00:00
Santhosh Thottingal
c48b270dec Fix Bug 41804 - Display Settings shows dual labels for Font Selection
Change-Id: I46a9a67595840d0e67b95226f6d1fa17de1946e5
2012-11-08 14:48:31 +05:30
Santhosh
5f14b23bc4 Merge "Avoid contstructing html with concatenation" 2012-11-08 08:44:23 +00:00
Niklas Laxström
4b811a5997 Avoid contstructing html with concatenation
Fixes potential security issue, bug 41395.
Change-Id: I55c79e41de6084d18c49b8bb715a7f49e19dc7e9
2012-11-01 12:25:27 +00:00
Siebrand
cb78d33a0c Merge "Update jquery.i18n from upstream" 2012-11-01 12:00:16 +00:00
Niklas Laxström
25889d77b6 Avoid constructing html with concatenation
Change-Id: I6104ade6a9f9209df921577cd04d7fe9487e65d9
2012-11-01 17:26:10 +05:30
Santhosh Thottingal
63d98b05ea Update jquery.i18n from upstream
Change-Id: Id533eb69c2c192f2cb42749214e5bb23d379e404
2012-11-01 11:47:59 +00:00
Santhosh Thottingal
cccd49163b Correct the preference overriding for IME
Change-Id: I80eddfe7476b1c7ff1562f79bc14f497e4630862
2012-11-01 10:18:20 +05:30
pginer
833f8f63d6 Fix to reduce the ammount of settings text
Settings text on the main ULS view can grow longer for some languages running out of space.
This change does the following to avoid that:
* Removes setting section explanations and shows them as a tooltip on hover.
* Adjusts style for adjusting space between setting sections.
* Keyboard image has been adjusted to match the display settings image.

Change-Id: I42ec5cb35b3d4df977a6eff28ad55891f4135356
2012-10-31 18:37:06 +05:30
Santhosh Thottingal
fc29a7e587 Option for disabling the IME system
* It can be a user preference using the ULS Input method settings
* It can be a mediaWiki configuration $wgULSIMEEnabled

Change-Id: Ic5fb4932d62ab18db5d3b10ca81c0f6bfe9fd29e
2012-10-31 12:57:14 +05:30
Santhosh Thottingal
8069e530e7 i18n for input method settings
Change-Id: Id6cf3f24fe355a6757533d3b7f302e3d33cfa0c3
2012-10-30 19:50:35 +01:00
Santhosh Thottingal
427c94dbbf Avoid 404s in non-localized locales
* Update jquery.i18n - if messageLocationResolver returns false for
  a locale, no server hit will be attempted
* Refactor i18n preparation code to a new method
* Use the ULS RL hooks to find out to which locales it is localized,
  pass that list to js to avoid hitting server.
* Also avoid directory scanning in each request by putting
  the locale list in cache

Fixes Bug 41454

Change-Id: I0c923b35db01b884e2dd55873dd5fb7384434645
2012-10-30 13:53:47 +00:00
Santhosh Thottingal
4818545939 Add a more settings link instead of the help link
It opens the input settings panel of ULS

Change-Id: I6d22585f735073d3d7d3e59eba24befe72238786
2012-10-30 11:33:50 +05:30
Amire80
8a0845ee55 Merge "Move the IME customization code out of document.ready" 2012-10-29 10:31:46 +00:00
Amire80
c111f46c92 Merge "Remove unused settingspanel.js" 2012-10-29 09:39:27 +00:00
Santhosh Thottingal
87c7d50b01 Move the IME customization code out of document.ready
Change-Id: If358cb1639b4a7e847aefac8f4b7b1923209f76d
2012-10-29 14:32:44 +05:30
Santhosh Thottingal
1c72077c89 Cleanup
whitepace, unwanted fixmes, wrong comments, jshint

Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e
2012-10-29 14:27:40 +05:30
Santhosh Thottingal
3a621cbfea Remove unused settingspanel.js
This was added in the assumption that there will be common code between
input settings and font settings. After development of both, it turns out
that there is not much common code

Change-Id: Id424122e515e9fa1f74030b0077c35835e6f15fa
2012-10-29 14:19:11 +05:30
Santhosh Thottingal
fc4ca9f823 Callback for preference save action is optional
$.noop() was wrong. Changed it to $.noop as callback

Change-Id: Iff935e1a9c1b364efd947ce1bff785dacb81570e
2012-10-29 10:34:43 +05:30
Santhosh Thottingal
4adb53b01f Show languages with Input methods in the language selector
When accessed from ... of input settings.

Change-Id: I553f1052143c56d5e4e96a2d62d1c3bc35eb4a02
2012-10-26 15:10:56 +05:30
Amire80
66b2badb5c Merge "CSS, tooltip fixes for the more button in IME selector menu." 2012-10-26 08:51:56 +00:00
Santhosh Thottingal
3ef527960c CSS, tooltip fixes for the more button in IME selector menu.
Change-Id: Ic1ace1191ad9745c9f02be4e5938ce3fb53da8b9
2012-10-26 10:49:45 +02:00
Amire80
835e4f1dbd Merge "Avoid lazyloading when used for input method language selection." 2012-10-26 08:24:28 +00:00
Amir E. Aharoni
98bb1c200c (bug 40693) Refactor font selector creation code
Change-Id: Id9560ad326cbd5202553da872b5fb0254c074109
2012-10-26 07:11:53 +00:00
Santhosh Thottingal
2fb85713cb Avoid lazyloading when used for input method language selection.
That list is small and we can load all the languages initially.
Fixes the scroll not appearing issue. Also fixes English being
appended to America region on scroll

Change-Id: Ic70d3ea30dc0ccf33a172361e0b50c07ed8ff82b
2012-10-26 11:14:03 +05:30
Santhosh Thottingal
f13e474e43 Input method integration with ULS
The file ext.uls.settingspanel.js is a draft for common
code in the different settings panels.

Change-Id: I057274f16b27b2c18d43d41c1d43f485a18ef0bf
2012-10-26 11:14:02 +05:30
Santhosh Thottingal
90de05cb97 Make the setting item toggle on click
Selection was not removed from other items when clicked.

Change-Id: Ie460ecc6504ccbe2abc217ba2e0a027f407c31cc
2012-10-26 11:14:02 +05:30
Nikerabbit
4c26d822f2 Merge "Simplify the preference system" 2012-10-24 15:54:33 +00:00
Santhosh Thottingal
4b09afb2ba Simplify the preference system
* Just use key,value system and drop the concept of groups
* Abstract the preferences for each type of systems(display, input)
  to have meaningful APIs

Change-Id: I25423667adf6ca181a4027cdfc4ed378f36a94ba
2012-10-23 09:59:26 +05:30
Amir E. Aharoni
ebfc81d058 Make "system" the default font for Hebrew
"Miriam" was used for initial experimentation. It shouldn't be
the default, becase people complain repeatedly, and rightly, that
it's too small and hard to read.

Change-Id: Ie791ed66acdf71a20275884c39208602bddb06cc
2012-10-21 17:29:22 +02:00
Amire80
83b912d683 Merge "Use default font only if webfonts is enabled." 2012-10-16 12:07:50 +00:00
Amire80
c04b0a83ba Merge "JSHint fixes" 2012-10-16 11:56:17 +00:00
Amire80
b9f2ba105f Merge "More jshint fixes" 2012-10-16 11:54:21 +00:00
Santhosh Thottingal
b8b6cc7be7 More jshint fixes
Change-Id: I132133b183be28165067f2c023304c00a4cb8f76
2012-10-16 17:10:08 +05:30
Santhosh Thottingal
59da3610f4 Jshint fixes for displaysettings
Change-Id: I29549893fa9081f5af3d7108a7515963ecf6bfc9
2012-10-16 16:58:51 +05:30
Santhosh Thottingal
7b30aa7f1a JSHint fixes
* variables in one line
* double quote , single quote consistancy
* Unused variables

Change-Id: Id368190e7c4f46c8ef09deea88a0d5a7b32889ef
2012-10-16 16:55:53 +05:30
Santhosh Thottingal
2d18576bec Use default font only if webfonts is enabled.
Also contains fixes to make code jshint valid.

Change-Id: I40577acfc939512c71ffe607c14a9fe795760588
2012-10-16 16:26:59 +05:30
Amir E. Aharoni
0385ed8bfb (bug 39531) Only show the fonts dropdown if there are fonts
The Display settings template is wrapped in a new <div>
to allow easy $template.find() queries.

This change requires a change in jquery.webfonts, that makes
the lib function return an empty list when there are no fonts:
https://github.com/wikimedia/jquery.webfonts/pull/1

Change-Id: Ief5a920439df340360a44ca95de2a7f070b96d5d
2012-10-15 17:00:31 +02:00
Santhosh Thottingal
1276a35f31 Check for window.GEO in getCountryCode
Followup of Id8d7356e

Change-Id: Ib89d72d35e69742797ffb29c0eb10897c410cc83
2012-10-15 11:01:19 +05:30
Santhosh Thottingal
c19c0b4db7 Fix Bug 40714 - ULS geoclient needs proper interface
Change-Id: Id8d7356ec75e8652c75927736a60b916dd069c28
2012-10-13 20:02:32 +05:30
Amire80
702d45286e Merge changes I1e913e08,I898bcf6e
* changes:
  Update jquery.i18n from upstream
  Load the fallback locales
2012-10-13 11:12:48 +00:00
Amir E. Aharoni
2ad892ae81 Removed "Select prefered font" heading
It seems redundant to me: There are one or two dropdown menus for
selecting fonts, with pretty clear labels.

Change-Id: If6134997b7c34eeb32efed1dcee13c61d8af7750
2012-10-11 08:41:09 +02:00