Commit Graph

4 Commits

Author SHA1 Message Date
Kartik Mistry
b7e6aaa475 shellcheck fixes
* Script: https://github.com/koalaman/shellcheck
* Use $(..) instead of deprecated `..`
* Use double quote to prevent globbing and word splitting.

Change-Id: I68372d4e29ae34e0704e5a605447ad17bf0666d7
2014-04-01 07:58:24 +00:00
Kartik Mistry
f25fca0dcb Check if directory exists in a better manner
* This avoids warnings like: line 8: cd: /tmp/jquery.ime:
   No such file or directory.
 * Formatting fixes.

Change-Id: Icbc3f6f80314cae3ea9b5dfdc3e66c59af225621
2014-02-11 17:39:24 +05:30
Timo Tijhof
c6d71015ff Various clean up
Files:
* Consistently have one (1) new line at EOF
  (.gitignore, *.css, *.sh)

JSHint:
* Separate the common (general Wikimedia code conventions) from
  the local more stricter rules (nice work!).

Maintenance:
* Use simplified $IP definition where getenv is only called once.
  Based on http://git.io/ve-mw-36fc3b59-makeStaticLoader

JavaScript:
* Use the same closure in all files:
  - No need for "undefined".
  - One linebreak between license header and start of closure
    (sometimes there were 1 or 2 empty lines).
  - ext.uls.ime.js: No need for "document" (redundant in general,
    but especially as it wasn't used anywhere in this file).
  - Use "$, mw" for all ext.* modules (one of them used "mw, $").

Change-Id: Iba5dab14bbc3fbfc9f8fe96dd2d95529587a69aa
2014-02-08 00:11:50 -08:00
Santhosh Thottingal
eb7cb4ecd5 Add scripts to update js libraries from upstream
Change-Id: Ie2c7727afc5bd7c7d0ab44b50070e6ea49ee6e96
2013-11-25 14:35:05 +05:30