This reverts commit 30d26a4fd2.
Some issues in this patch were identified, see T52599.
Reverting so that MLEB can be released and issues fixed and
tested properly after the release.
Change-Id: I35c1eb2db5ead8ca75dc2724997d789c83c69b6d
Replaces many of the styles with the new standard ones in mw-ui, which is
present in v1.22 of Mediawiki, the current lowest supported version of
ULS.
Might require a follow-up to reduce the amount of redundant CSS present
Bug: T52599
Change-Id: Id186ece6513f154e0388bc4170c21bdabb59038a
This patch restores the enableWebfonts preference, stored inside
the uls-preferences blob. It existed as 'enable-webfonts' in
the past and was removed in
If735a733717596fae03042c5e277bd538bd8501f
Each wiki can be configured to load the fonts by default
using the new global variable $wgULSWebfontsEnabled.
Its default value is true (to load fonts).
This also removes the preference 'uls-enable', recently added in
I71b70d8ee7c3cad7f49b32e5dc494ef4fc1bdb2f
The initialization of ext.uls.webfonts.js is changed as well,
so that minimal webfonts JS library code is loaded,
and the rest is loaded only if a user requests it.
Bug: 60304
Change-Id: I49e812eae32266f165591c75fd67b86ca06b13f0
Files:
* Consistently have one (1) new line at EOF
(.gitignore, *.css, *.sh)
JSHint:
* Separate the common (general Wikimedia code conventions) from
the local more stricter rules (nice work!).
Maintenance:
* Use simplified $IP definition where getenv is only called once.
Based on http://git.io/ve-mw-36fc3b59-makeStaticLoader
JavaScript:
* Use the same closure in all files:
- No need for "undefined".
- One linebreak between license header and start of closure
(sometimes there were 1 or 2 empty lines).
- ext.uls.ime.js: No need for "document" (redundant in general,
but especially as it wasn't used anywhere in this file).
- Use "$, mw" for all ext.* modules (one of them used "mw, $").
Change-Id: Iba5dab14bbc3fbfc9f8fe96dd2d95529587a69aa
Pressing apply button is applicable to all settings module, not only
for the one that is visible. Unless we do a validation before we save
preferences, other module can cause incorrect (old) preferences to be
saved.
Bug: 56885
Change-Id: I31df2ee0bf8b600a94e8fed1a784daf529186b16
If a user does changes in module A, does not save or cancel,
goes to module B, does some changes, moves to other modules,
and finally presses Apply, all changes should get saved.
Similarly, if a user cancels, all changes should get cancelled.
This required moving the cancel and apply button outside of modules
and managed by the language settings framework.
Modules get mw.uls.settings.apply or mw.uls.settings.cancel triggers
to do whatever they want to do on apply or save.
Includes some refactoring related to this.
Bug: 53256
Change-Id: I7d773d33a980a78604b36e39bf96a5686870124e
Restore the language(ui, content), font values, input method values.
Rest of the UI resetting will be done by redrawing the settings
area whenever the language settings is accessed again.
Change-Id: Ia1488d1501f9c9f61726cea3637624f22a7ba135
This avoids mandate of having 'cancel' method defined in settings module.
Also avoids looping of all modules while cancel is happening.
Change-Id: I87d0975f2ef1bdee61f71d66eabe3040b81876b8
Separating event logging out of ULS functionality. Event logging
is now loosely coupled with ULS. ULS core modules can emit an event
whenever EventLogging is required. The eventlogger module will act
on the event if configured.
Change-Id: I59dfcfb25c1acb85376b56239f2355ee7c4aff1e
* Refactored the Cancel button handler code to cancel method in
display settings and input settings.
* When the user makes changes in multiple modules and clicks the Cancel
button or closes the language settings after that, cancel the changes in
all the modules. See bug 50564.
* The Apply button was always active in input methods module. Fixed the
logic for that.
* Renamed the enableApplyButton method to markDirty in both modules.
* Introduced isDirty attribute to the modules for optimizing the Cancel
method to avoid unnecessary restore actions.
* More minor cleanup and documentation.
Bug: 50564
Change-Id: I71f527bfb7dd7f6724e4365371ac3e4fc0723ed6
Because those windows are rendered later. The settings window inherits
fonts. But button in those panels doesn't inherit. Make sure all panel
elements have current font applied.
Change-Id: Ibb8b12b3d973023c49ef89a04d534081bf8ee87f
Renamed imeLanguage to UI language to make it correct.
And some logic corrections as per that change.
Bug: 49380
Change-Id: I1ed664623b23393e289bd817b88d7f326f6524be
Added input methods may increase the height of window.
Make sure the entire window is in view port.
Bug: 49427
Change-Id: I06194b7d51459a31247104b2113ef3212774f004
Issues fixed:
Incorrect position of ULS when accessed from more languages button
of input/display settings, when language settings opened from ime
menu.
Arrow(callout) appearing for ULS when opened from more languages
button of input/display settings, when language settings opened from ime
menu.
Used a class 'callout' to mark whether windows need callout arrow or not.
Bug: 49060
Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
It is possible that the count reach more than SUGGESTED_LANGUAGES_NUMBER
before it reach the
languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER
check. This will cause the loop to run for all languages.
Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184
Before this patch, this scenarios didn't yield the expected result:
1) Disable IME, click Apply 2) Enable IME, click Cancel
The expected result is that IME would be disabled, but it was enabled.
This patch re-stashes the preferences when they are saved, so
the last saved preferences are loaded when pressing Cancel.
Change-Id: Ic7abdab165e367d970e6568ba69b25bf7d4f675a
Remove redundant calls to prepareInputmethods
and redundant button styling.
Rename firstLanguauge to the clearer currentLanguage.
Switch checking for imeLanguage and the prereferences language
to make sure that the last one is shown.
Done in pair programming with Santhosh.
Bug: 48163
Change-Id: Ie8441f29eb20caa05534c8589481a26cb415a27f
