Commit Graph

1035 Commits

Author SHA1 Message Date
Santhosh Thottingal
1c72077c89 Cleanup
whitepace, unwanted fixmes, wrong comments, jshint

Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e
2012-10-29 14:27:40 +05:30
Santhosh Thottingal
3a621cbfea Remove unused settingspanel.js
This was added in the assumption that there will be common code between
input settings and font settings. After development of both, it turns out
that there is not much common code

Change-Id: Id424122e515e9fa1f74030b0077c35835e6f15fa
2012-10-29 14:19:11 +05:30
Santhosh Thottingal
fc4ca9f823 Callback for preference save action is optional
$.noop() was wrong. Changed it to $.noop as callback

Change-Id: Iff935e1a9c1b364efd947ce1bff785dacb81570e
2012-10-29 10:34:43 +05:30
Santhosh Thottingal
4adb53b01f Show languages with Input methods in the language selector
When accessed from ... of input settings.

Change-Id: I553f1052143c56d5e4e96a2d62d1c3bc35eb4a02
2012-10-26 15:10:56 +05:30
Amire80
66b2badb5c Merge "CSS, tooltip fixes for the more button in IME selector menu." 2012-10-26 08:51:56 +00:00
Santhosh Thottingal
3ef527960c CSS, tooltip fixes for the more button in IME selector menu.
Change-Id: Ic1ace1191ad9745c9f02be4e5938ce3fb53da8b9
2012-10-26 10:49:45 +02:00
Amire80
835e4f1dbd Merge "Avoid lazyloading when used for input method language selection." 2012-10-26 08:24:28 +00:00
Amir E. Aharoni
98bb1c200c (bug 40693) Refactor font selector creation code
Change-Id: Id9560ad326cbd5202553da872b5fb0254c074109
2012-10-26 07:11:53 +00:00
Santhosh Thottingal
2fb85713cb Avoid lazyloading when used for input method language selection.
That list is small and we can load all the languages initially.
Fixes the scroll not appearing issue. Also fixes English being
appended to America region on scroll

Change-Id: Ic70d3ea30dc0ccf33a172361e0b50c07ed8ff82b
2012-10-26 11:14:03 +05:30
Santhosh Thottingal
f13e474e43 Input method integration with ULS
The file ext.uls.settingspanel.js is a draft for common
code in the different settings panels.

Change-Id: I057274f16b27b2c18d43d41c1d43f485a18ef0bf
2012-10-26 11:14:02 +05:30
Santhosh Thottingal
90de05cb97 Make the setting item toggle on click
Selection was not removed from other items when clicked.

Change-Id: Ie460ecc6504ccbe2abc217ba2e0a027f407c31cc
2012-10-26 11:14:02 +05:30
Nikerabbit
4c26d822f2 Merge "Simplify the preference system" 2012-10-24 15:54:33 +00:00
Santhosh Thottingal
4b09afb2ba Simplify the preference system
* Just use key,value system and drop the concept of groups
* Abstract the preferences for each type of systems(display, input)
  to have meaningful APIs

Change-Id: I25423667adf6ca181a4027cdfc4ed378f36a94ba
2012-10-23 09:59:26 +05:30
Amir E. Aharoni
ebfc81d058 Make "system" the default font for Hebrew
"Miriam" was used for initial experimentation. It shouldn't be
the default, becase people complain repeatedly, and rightly, that
it's too small and hard to read.

Change-Id: Ie791ed66acdf71a20275884c39208602bddb06cc
2012-10-21 17:29:22 +02:00
Amire80
83b912d683 Merge "Use default font only if webfonts is enabled." 2012-10-16 12:07:50 +00:00
Amire80
c04b0a83ba Merge "JSHint fixes" 2012-10-16 11:56:17 +00:00
Amire80
b9f2ba105f Merge "More jshint fixes" 2012-10-16 11:54:21 +00:00
Santhosh Thottingal
b8b6cc7be7 More jshint fixes
Change-Id: I132133b183be28165067f2c023304c00a4cb8f76
2012-10-16 17:10:08 +05:30
Santhosh Thottingal
59da3610f4 Jshint fixes for displaysettings
Change-Id: I29549893fa9081f5af3d7108a7515963ecf6bfc9
2012-10-16 16:58:51 +05:30
Santhosh Thottingal
7b30aa7f1a JSHint fixes
* variables in one line
* double quote , single quote consistancy
* Unused variables

Change-Id: Id368190e7c4f46c8ef09deea88a0d5a7b32889ef
2012-10-16 16:55:53 +05:30
Santhosh Thottingal
2d18576bec Use default font only if webfonts is enabled.
Also contains fixes to make code jshint valid.

Change-Id: I40577acfc939512c71ffe607c14a9fe795760588
2012-10-16 16:26:59 +05:30
Amir E. Aharoni
0385ed8bfb (bug 39531) Only show the fonts dropdown if there are fonts
The Display settings template is wrapped in a new <div>
to allow easy $template.find() queries.

This change requires a change in jquery.webfonts, that makes
the lib function return an empty list when there are no fonts:
https://github.com/wikimedia/jquery.webfonts/pull/1

Change-Id: Ief5a920439df340360a44ca95de2a7f070b96d5d
2012-10-15 17:00:31 +02:00
Santhosh Thottingal
1276a35f31 Check for window.GEO in getCountryCode
Followup of Id8d7356e

Change-Id: Ib89d72d35e69742797ffb29c0eb10897c410cc83
2012-10-15 11:01:19 +05:30
Santhosh Thottingal
c19c0b4db7 Fix Bug 40714 - ULS geoclient needs proper interface
Change-Id: Id8d7356ec75e8652c75927736a60b916dd069c28
2012-10-13 20:02:32 +05:30
Amire80
702d45286e Merge changes I1e913e08,I898bcf6e
* changes:
  Update jquery.i18n from upstream
  Load the fallback locales
2012-10-13 11:12:48 +00:00
Amir E. Aharoni
2ad892ae81 Removed "Select prefered font" heading
It seems redundant to me: There are one or two dropdown menus for
selecting fonts, with pretty clear labels.

Change-Id: If6134997b7c34eeb32efed1dcee13c61d8af7750
2012-10-11 08:41:09 +02:00
Santhosh Thottingal
da05b4e305 Load the fallback locales
To avoid message keys appearing for non-translated strings in a locale

Change-Id: I898bcf6ee4085054ae956740ba8d87f8e5ebee27
2012-10-10 17:53:19 +05:30
Santhosh
c3b26001d0 Merge "(bug 39535) Fix the creation of language buttons" 2012-10-10 11:11:35 +00:00
Santhosh
d9885d1522 Merge "Refactor font selection HTML" 2012-10-10 11:01:46 +00:00
Amir E. Aharoni
3699095401 (bug 39535) Fix the creation of language buttons
Assure that the language buttons in the display settings always
show the content and the UI language and that all the buttons are
filled with some language (by assuming major world languages if
nothing more likely was found).

Also other fixes:
* Add lang and dir attributes for the languages.
* General refactoring and better variable names.

Change-Id: Ie6a93439237b389179ebc6c4a5df34c1566a5e12
2012-10-09 17:21:00 +02:00
Santhosh Thottingal
069d9e6915 Update jquery.uls
Also update the onReady callback as per the changes in jquery.uls

Change-Id: I9e4968af87258558f7a94900bd9bc735cb0d9662
2012-10-09 19:59:20 +05:30
Amir E. Aharoni
2991ed18f3 Refactor font selection HTML
Added whitespace for readability
and comments to understand the different parts of the HTML template.
Also removed an unneeded closing </span>.

The output is not supposed to change.

Change-Id: I43891170eb6fac03370cf1d71cd399d2de3c4da8
2012-10-09 12:44:59 +02:00
Amir E. Aharoni
8d31bf8c07 Updated util functions names after refactoring
jquery.uls.js is just updated from GitHub.

Change-Id: I506ab810d7136ba5d96dfdd469394a843110f8de
2012-10-08 20:50:49 +02:00
Santhosh Thottingal
d9215c0585 Fix Bug 40539 Add Opendyslexic font
Added it as non-default font for following languages
en,af,pt,es,sw,de,fi,sq,fr,hu,ca,da,fo,ga,is,ms,sv,wa,lb,gd,oc,tr,mi,it,et,cy

Change-Id: Ia4b18cf0429dc9e07c89b84cdae16a8325806618
2012-10-05 10:36:53 +05:30
Nikerabbit
4709c97fd4 Merge "Make the previous language link work" 2012-10-02 07:28:34 +00:00
amire80
a8399e210f Make the previous language link work
Refactored the showing and hiding functionality of tipsy tooltip.

Also made the class name clearer.

Change-Id: I54972e3c8039e97cceced9fce3abb10d34fbf098
2012-10-02 09:59:10 +05:30
Santhosh Thottingal
68c69fab6f Respect the system default font for languages
If the default font is 'system' do not apply fonts.
Required for languages like English

Change-Id: I4f798c62856d33220b3b1d2d87451bcf6dca41d8
2012-10-02 09:34:39 +05:30
Santhosh Thottingal
018f8418ad Internationalize Mediawiki ULS extension
Change-Id: I17d6c4d6322e30c96a48788dd34dc11530b809b5
2012-09-25 16:39:40 -07:00
Santhosh Thottingal
a13f9b739d Internationalize ULS
* Integrate jquery.i18n
* Update jquery.uls from upstream and use the build version

Change-Id: I523444b1f6b177f14a4799a455a16a14649b0e1b
2012-09-23 13:12:45 -07:00
Siebrand Mazeland
e1a4f7f0cb After training the PHPStorm code formatter.
See https://github.com/siebrand/MediaWiki-PHPStorm

Issue remains with anonymous functions in JavaScript.

Change-Id: I2b520f8df127452acf02deb659277a6465e6ca59
2012-09-17 17:10:59 -07:00
Santhosh Thottingal
569b09712c Wrong exclude selector for webfonts
* It is not textbox. It is textarea. :(

Change-Id: Ib6b170fe09101448ccf231c5c3244b7ad3f7b291
2012-09-17 09:25:48 -07:00
Siebrand
d4a46dccd2 Merge "Fix Bug 39560 - Monospace font setting overridden" 2012-09-16 16:53:50 +00:00
Santhosh Thottingal
ac79f8a205 Fix the broken default module rendering
defaultModule option for language settings is module name string
and not the module itself

Change-Id: Ief84cc723157df43c7ec57d6576a707df09b9e2d
2012-09-12 15:30:33 -07:00
Santhosh Thottingal
5c07275300 Fix Bug 39686 - Cancel button in settings should go to the previous context
* Add an onClose option for language settings
* Add a close method to language settings and display settings
* some documentation and cleanup

Change-Id: I3040e0740bd8a9f9f7d3ad508a3003415a24e7a9
2012-09-12 10:52:58 +05:30
Niklas Laxström
ceb1a80eea ext.uls.geoclient should not break if it runs before ext.uls.init
Change-Id: If4c8203bccd4287a94de6b22210f067852241614
2012-09-09 07:55:23 +00:00
Santhosh Thottingal
0b2b993b19 Correct selectors, and formatting
Fix the issues from Ib2c8cfed
And for ID based selectors removed the element name.

Change-Id: I0016246c3a32b2b3696a1da1c04f507275c2267c
2012-09-07 18:55:02 +05:30
Santhosh Thottingal
805482d9cd Fix Bug 39529 - Display settings section should be selected by default
* add a parameter acitve to renderModule so that it is highlighted
  and active
* move the default module render call to renderModule method

Change-Id: I5dca8586dddf1065b4e85642a40c3558f0b6586b
2012-09-07 17:25:02 +05:30
Santhosh Thottingal
5b3f7cc269 Whitespace cleanup, remove deprecated methods
* Fixed many white space issues- mainly whitespace missing before
  function start paranthesis eg: function()
* Removed the deprecated live methods and replaced with on
* Added file documentation for ext.uls.geoclient

Change-Id: Ib2c8cfed1a6ff3859495e707680d5c19882a33e8
2012-09-07 16:47:03 +05:30
Santhosh Thottingal
5ce0dac72d JsHint fixes - Move the invocation into the parens that contain the function.
Change-Id: I83d4808a9daeb6e0d52f77c718f9e384454d8ecc
2012-09-07 13:46:12 +05:30
Santhosh Thottingal
cc1cca33d7 Fix Bug 39560 - Monospace font setting overridden
* use the exclude option from jquery.webfonts

Change-Id: I5c35c848197ceae0def6cbc31249f887b962365b
2012-09-06 11:18:11 +05:30