Commit Graph

93 Commits

Author SHA1 Message Date
Siebrand Mazeland
1f9bf6f82c Update indentation and newlines
Change-Id: Iac833df12a00949d32f2ce2fc26a657bab3d8229
2013-06-17 16:36:34 +02:00
Santhosh Thottingal
34d4045c3b Validate imeId before rendering
Fix: TypeError: $.ime.sources[imeId] is undefined

Bug: 49584
Change-Id: I9f5615d8b6729d76feae04e195a5ec6f26676bda
2013-06-17 10:08:16 +05:30
jenkins-bot
dce0b387c7 Merge "Input settings - language selection cleanup" 2013-06-13 10:09:31 +00:00
Santhosh Thottingal
638ab5bb3d Input settings - language selection cleanup
Renamed imeLanguage to UI language to make it correct.
And some logic corrections as per that change.

Bug: 49380
Change-Id: I1ed664623b23393e289bd817b88d7f326f6524be
2013-06-12 11:41:56 +00:00
Santhosh Thottingal
43be2f274c Scroll to viewport after input methods list is rendered
Added input methods may increase the height of window.
Make sure the entire window is in view port.

Bug: 49427
Change-Id: I06194b7d51459a31247104b2113ef3212774f004
2013-06-12 06:53:27 +00:00
Santhosh Thottingal
f0b3e6524c Cleanup
Minor whitespace, coding convention cleanup

Change-Id: Ibb10ce64ad4c35bfd6f924665243961c80b81714
2013-06-11 10:24:13 +05:30
Santhosh Thottingal
ae27298bee Fix: new language is not added to button on the display panel
Bug: 49377
Change-Id: Ibfec48d84ecc166628d2bc0b052688f19967491f
2013-06-10 12:02:26 +05:30
Santhosh Thottingal
9bc9aa7238 Avoid duplicate language buttons in input settings panel
Bug: 49141
Change-Id: Ibf076e6049e87e1398c87d2a264343f32eaddf28
2013-06-07 14:28:17 +00:00
Santhosh Thottingal
e9ab300889 Fix: ULS popup moves to sidebar if opened from ime menu
Issues fixed:
Incorrect position of ULS when accessed from more languages button
of input/display settings, when language settings opened from ime
menu.

Arrow(callout) appearing for ULS when opened from more languages
button of input/display settings, when language settings opened from ime
menu.

Used a class 'callout' to mark whether windows need callout arrow or not.

Bug: 49060
Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
2013-06-07 14:26:46 +00:00
Santhosh Thottingal
6a9b31ad26 Use smooth scrolling for the windows when not in viewport
Change-Id: I94591d17ba023d9a13e2436ddebfd0209e076845
2013-06-07 14:26:31 +00:00
Santhosh Thottingal
c9aa1f1130 Correct the loop logic for language buttons
It is possible that the count reach more than  SUGGESTED_LANGUAGES_NUMBER
before it reach the

languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER

check. This will cause the loop to run for all languages.

Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184
2013-06-06 06:36:36 +00:00
Amir E. Aharoni
1a17ef392d Properly save back-up preferences for repeated canceling
Before this patch, this scenarios didn't yield the expected result:

1) Disable IME, click Apply 2) Enable IME, click Cancel

The expected result is that IME would be disabled, but it was enabled.

This patch re-stashes the preferences when they are saved, so
the last saved preferences are loaded when pressing Cancel.

Change-Id: Ic7abdab165e367d970e6568ba69b25bf7d4f675a
2013-06-04 12:00:21 +03:00
Amir E. Aharoni
361eb95f33 Make "Cancel" reset preferences and "Apply" save and close
Bug: 48898
Change-Id: I9f5444ffd57ddf46d197ebdb23a18c0c4600b196
2013-06-04 10:42:29 +03:00
Santhosh Thottingal
73716f3f67 Remove lot of scroll to view related code
Just use javascript scrollIntoView to do that.
Also remove duplication of code related to this

Change-Id: Ied1235a85f4fe2d99afa127737979c24d3591118
2013-06-03 05:44:17 +00:00
jenkins-bot
44dbfbba4f Merge "Show input methods for selected language correctly" 2013-05-29 11:49:49 +00:00
Siebrand Mazeland
fb459cfd88 Clarify labels for input methods
Bug: 48536
Change-Id: I12fa43a9402f64f6da7ba040ff37363a2cc027bb
2013-05-28 07:54:27 +02:00
Amir E. Aharoni
282b6c7644 Show input methods for selected language correctly
Remove redundant calls to prepareInputmethods
and redundant button styling.

Rename firstLanguauge to the clearer currentLanguage.

Switch checking for imeLanguage and the prereferences language
to make sure that the last one is shown.

Done in pair programming with Santhosh.

Bug: 48163
Change-Id: Ie8441f29eb20caa05534c8589481a26cb415a27f
2013-05-27 13:38:32 +03:00
Santhosh Thottingal
bf270812f5 Fix all jshint errors
Change-Id: Ib8fb350132bb34c1e063eb644af5aeff833f95e8
2013-05-20 15:07:42 +05:30
Santhosh Thottingal
bb3e72f5a0 Simplify the language settings display
Directly show language settings instead of showing ULS language selector
and then simulating click on language settings

Change-Id: Iafb15ac9a7140fcce9e71ed933be6c55be81dc7e
2013-05-20 10:21:38 +05:30
jenkins-bot
394f4ab943 Merge "Set the position of display settings to match ULS" 2013-05-16 09:52:15 +00:00
Amir E. Aharoni
07465bf20c Set the position of display settings to match ULS
Bug: 47822
Change-Id: I7b04a831b2c5d7932564a3cdde94be0e233f7a7b
2013-05-16 09:48:44 +00:00
Amir E. Aharoni
977b36ade6 Replace id uls-more-languages with class
Change-Id: I51f74f0b3bcec1b45dd5588638346a6d02a44e52
2013-05-15 10:45:35 +03:00
Niklas Laxström
2f4e9cfff9 Reduce rerenderings in input settings
Change-Id: Ia929bbbb2cd6be18e37d9b73b4eea199bd0ad4b8
2013-05-09 16:28:21 +03:00
Niklas Laxström
aee1fcff19 Join some appends to one call
Change-Id: Iccf4c7653aff775a6ea0ddc211135dab8b1d99d1
2013-04-29 12:20:42 +00:00
Niklas Laxström
d309c687e9 Rename confusingly named function
Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
2013-04-29 12:20:42 +00:00
Amir E. Aharoni
3471158dec Avoid null in the IME languages buttons
Change-Id: Ic64763fdba34bdcebde33104f7e6130d93a84e02
2013-04-29 14:52:37 +03:00
Amir E. Aharoni
f47b54819b Make disabling input methods work
Mark isDirty correctly.

Change-Id: I1c5219c9f63dec15272dd97341295e346cdabcb3
2013-01-17 18:35:03 +00:00
Amir E. Aharoni
e0e4ffa950 (bug 42375) Show current IME language in ULS input settings
Change-Id: I5240b1cb42b98ecb5dec96be838fbcf7736f81e6
2013-01-07 23:54:05 +02:00
Amir E. Aharoni
80ce8e068b (bug 42440) Fix button state when canceling
Also changed class names to make finding cancel buttons easier.

Change-Id: Ieaf242eb03add06038307d913a87a196d41ba01d
2013-01-02 08:04:50 +00:00
Amir E. Aharoni
e8ed043352 (bug 42382) Indicate context in input settings/more languages
1. Fix a regression introduced in
27039e1141
- a change in a class name caused the back link not to appear.
Now the link is back.

2. Copy the same logic to the input settings panel.

Change-Id: Ie80032ee2e14853f96cfb3b48dec5c85398c8373
2012-12-10 21:50:36 +02:00
Santhosh Thottingal
ea8bbfd35d (bug 42374) Provide clear indication of lack of IME support for a language
Change-Id: Id637eed3544a66aac4185f9e9d967691fe481331
2012-11-23 12:38:52 +00:00
Amir E. Aharoni
ac32e53fe6 (bug 39685) Disable the Apply button until there are changes
This commit completes the solution of this bug for Input settings.

Change-Id: Iebabb08bdd4138cff278b811a681d684363ecc12
2012-11-22 15:44:19 +02:00
pginer
4edd874d2e Visually connect input language and available methods.
Adds a tooltip-like panel to clearly indicate that input methods displayed
are related to the input language selection.

Change-Id: Ib4e9bca48f1f18cfd09a32c25f7ebf404af228e8
2012-11-22 14:01:20 +02:00
Amir E. Aharoni
f410f5d99a Consistent name for the inputSettings variable
Rename various names of "that = this" to "inputSettings = this".

Change-Id: If547a1e8da102c755019b50a5bc35f9c2cc4ab6a
2012-11-22 09:57:46 +02:00
Santhosh Thottingal
ad094f459f Just hide the whole window after apply button pressed
Change-Id: I6fe8675bddc7fa5fa8e3ac56cdbb3604cc695e22
2012-11-19 15:11:54 +05:30
Santhosh Thottingal
e3e0be19f2 Update the inputmethod settings as per design
Design: http://dl.dropbox.com/u/30377416/i18n/visual/input-settings.pdf

Do not show the language list and input methods if IME is disabled
And do not show descriptive text if IME is enabled.

Change-Id: I49e07cbadf7e253e4fb0d5a59029d9884308c06a
2012-11-19 09:20:41 +02:00
Santhosh Thottingal
7c4646a059 Remove href=#, to fix Bug 41988
Change-Id: I8eacaa452eb71d237fc671aa63c4707b8e14a83f
2012-11-19 10:59:26 +05:30
Siebrand Mazeland
98d7a8d9f9 Reformat code.
Change-Id: Ic0a5b37fa01b4a13023e66af0518ea94919ee880
2012-11-11 10:34:10 +01:00
Santhosh Thottingal
fc29a7e587 Option for disabling the IME system
* It can be a user preference using the ULS Input method settings
* It can be a mediaWiki configuration $wgULSIMEEnabled

Change-Id: Ic5fb4932d62ab18db5d3b10ca81c0f6bfe9fd29e
2012-10-31 12:57:14 +05:30
Santhosh Thottingal
4818545939 Add a more settings link instead of the help link
It opens the input settings panel of ULS

Change-Id: I6d22585f735073d3d7d3e59eba24befe72238786
2012-10-30 11:33:50 +05:30
Santhosh Thottingal
1c72077c89 Cleanup
whitepace, unwanted fixmes, wrong comments, jshint

Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e
2012-10-29 14:27:40 +05:30
Santhosh Thottingal
4adb53b01f Show languages with Input methods in the language selector
When accessed from ... of input settings.

Change-Id: I553f1052143c56d5e4e96a2d62d1c3bc35eb4a02
2012-10-26 15:10:56 +05:30
Santhosh Thottingal
f13e474e43 Input method integration with ULS
The file ext.uls.settingspanel.js is a draft for common
code in the different settings panels.

Change-Id: I057274f16b27b2c18d43d41c1d43f485a18ef0bf
2012-10-26 11:14:02 +05:30