Commit Graph

10 Commits

Author SHA1 Message Date
jenkins-bot
a7904a6d01 Merge "Make more tests pass in sandbox.translatewiki.net" 2013-09-06 12:44:05 +00:00
cmcmahon
813271b8a9 Wait longer, so the preference is saved.
Reported as bug 53772.

Change-Id: I8a0d6ae9d3cec06f953e6bb35abb9370e5551eec
2013-09-05 21:09:59 +00:00
Niklas Laxström
bcb2dd8b82 Make more tests pass in sandbox.translatewiki.net
* When ULS is in personal, cancel opens the language selector
  again but apply doesn't.
* Created separate steps for testing the ULS trigger in personal
  position, different behavior with different configuration.

Change-Id: Ifb7f101f2bfacd32c11cba69e7f2c01fe9bd9bb7
2013-09-04 09:37:28 +03:00
Santhosh Thottingal
3af403fee5 Make the cancel and apply button applicable for all modules
If a user does changes in module A, does not save or cancel,
goes to module B, does some changes, moves to other modules,
and finally presses Apply, all changes should get saved.

Similarly, if a user cancels, all changes should get cancelled.

This required moving the cancel and apply button outside of modules
and managed by the language settings framework.

Modules get mw.uls.settings.apply or mw.uls.settings.cancel triggers
to do whatever they want to do on apply or save.

Includes some refactoring related to this.

Bug: 53256
Change-Id: I7d773d33a980a78604b36e39bf96a5686870124e
2013-09-02 17:03:13 +02:00
Niklas Laxström
34146ea023 (bug 49738) Use correct name for wiki content language
Happens when anonymous user cannot change language, and the
language of the translation differs from the content language.

Change-Id: Ie4f15f1813eec992cfe060baf9cd7dcb5f8a0d95
2013-08-30 12:45:02 +03:00
Niklas Laxström
53f19e9f70 Add test for language live preview cancellation
Change-Id: I4880667df23301f4235a05df575fb84554c17303
2013-08-30 10:47:01 +03:00
Niklas Laxström
773b8f42e6 Fix more tests for phantomjs
As a bonus got rid of JavaScript call.

Refactored uls-position code to a method.

Change-Id: I1df384a02909d430c12225525d5722a0520177ee
2013-08-30 10:47:01 +03:00
Niklas Laxström
a6e3ec586e Make tests pass in phantomjs
Change-Id: I0cb094b8a350b716cfb7b50ea6e370fd39fff1d6
2013-08-28 18:44:23 +03:00
Niklas Laxström
3bd4bb4f03 Refactor ULS tests to reduce duplication and repetition
Change-Id: I96f1594f1b4d1960da9a8bc21e2a5c4727497b10
2013-08-28 14:08:17 +03:00
Niklas Laxström
d695b21381 Add new scenarios for font changes
There is currently some duplication between the various page objects
and other code. Those should be cleaned up incrementally.

Change-Id: I592829a00ca65bbecd5399b773c885c764c1cc06
2013-08-27 16:35:23 +03:00