Commit Graph

221 Commits

Author SHA1 Message Date
Željko Filipin
a780bcfcc1 Fixed Style/CaseIndentation RuboCop offense
Bug: 117989
Change-Id: Ifa93b8f3c2f8d6be991b1564c4c9253c4452c55f
2015-11-18 12:05:52 +01:00
Željko Filipin
513cfb87cf Fixed Style/HashSyntax RuboCop offense
Bug: 117989
Change-Id: Iecdcc3202adf9458f11310d188ab93176b03194f
2015-11-18 12:04:04 +01:00
Željko Filipin
f2b53c04f8 Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense
Bug: 117989
Change-Id: I7f9704999047dd73b784aeb186a8298aba657b1c
2015-11-18 12:03:17 +01:00
Željko Filipin
022efbfa8a Fixed Style/SpaceInsideParens RuboCop offense
Bug: 117989
Change-Id: I3418ad3b0265903171e3ee7603eeea22569387b4
2015-11-18 12:02:38 +01:00
Željko Filipin
71707e11a9 Fixed Style/IndentationWidth RuboCop offense
Bug: 117989
Change-Id: Ifc6ca84cef432c1214acb0cd988146544895f400
2015-11-18 12:01:51 +01:00
Željko Filipin
22e8762cec Fixed Style/StringLiterals RuboCop offense
Bug: 117989
Change-Id: I82086ebd56ace9f85c521ef53b67e5e4bae9d607
2015-11-18 12:00:36 +01:00
Željko Filipin
81e918780a Fixed Style/Tab RuboCop offense
Bug: 117989
Change-Id: Ic4d9769df7c0ca459a7710b414d0738601107461
2015-11-18 11:59:32 +01:00
Željko Filipin
0aa649e084 Update mediawiki_selenium Ruby gem to the latest version
Bug: 117976
Change-Id: I567880afcf7dc5d70e6d4edef1db16d7923ae31c
2015-11-18 11:50:39 +01:00
Amir E. Aharoni
3a45a6ae1e Reset the preferences after each browser test scenario
Change-Id: I9ee64cc789c36a3bf726e10fb9ded40c496862da
2015-04-02 14:00:39 +03:00
Amir E. Aharoni
4c74d905f2 Fix Rubocop offense Extra empty line
Change-Id: Id87b41bb4dd82bf6665fc28582d319db6f155d6e
2015-04-02 14:00:03 +03:00
Amir E. Aharoni
4fd44df761 Disable failing Cucumber scenarios
Bug: T94158
Change-Id: Ie30260efea0a7b9df7b66f89fc732848c5d289a7
2015-03-30 12:46:44 +03:00
Santhosh Thottingal
a6beeff043 Correct a language name to make all phpunit tests pass
CLDR had updated the language name for ms

Change-Id: I661128c1d237bb169e17ee605e6fa19054a476fe
2014-12-09 11:48:11 +05:30
Niklas Laxström
314e1c8c28 Update bugzilla references to phabricator and remove some excess links
Change-Id: I2cb920fd084a1ab333678e1e3c8f4524b39cc6cd
2014-12-06 22:09:23 +00:00
Željko Filipin
1b52b14cda Prepare repository for running RuboCop after every push to Gerrit
For now ignoring all problems.

Bug: 69245
Change-Id: I16c3edf47d6bb6470f5b71754fa99fe177b65797
2014-10-21 16:45:42 +02:00
Kartik Mistry
4e56af85fa Fix permission to fonts and Gemfile to 644
Bug: 71934
Change-Id: I65781f8d0fe012a4befbcd033574a91c74b30565
2014-10-11 11:49:10 +05:30
jenkins-bot
18fe41ccf7 Merge "Fix ULS QUnit tests" 2014-09-18 11:41:00 +00:00
Niklas Laxström
d25f7f3307 Fix ULS QUnit tests
Tests were failing for two reasons: wrong modules as dependencies of the
test module and test timing out due to incorrect usage of QUnit.asyncTest
and QUnit.start() and QUnit.Stop.

While at it, did some small cleanups and converted the number of
assertions to use non-deprecated QUnit.expect() instead.

Options are saved using postWithToken of mw.API. This also rises minimum
MediaWiki version to 1.22. This allowed removing hundred lines of code.
MLEB is already 1.22 and above.

Change-Id: I46a1674e4ede48a0e331c8d201d1d847db51d9dd
2014-09-18 11:40:39 +00:00
Željko Filipin
e9259b9766 Bug 61214 is resolved, removed pending block
Paired with: Amir E. Aharoni
Bug: 61214

Change-Id: I3345ee2130d09bd230a55e0c9c33da7a36247a09
2014-09-04 15:18:11 +02:00
Željko Filipin
70363d6d85 No longer running a scenario that fails
Paired with: Amir Aharoni

Change-Id: Ic8b5771f59f84c83e345a04227188158e5b50080
2014-06-17 15:31:36 +02:00
Željko Filipin
5b39955df5 Made a scenario pending
It fails because of a known bug.

Paired with: Amir Aharoni
Bug: 61214

Change-Id: Id46d5c86e58c4e02bc491378b53c9b3f2f7a4141
2014-06-17 15:22:27 +02:00
Željko Filipin
3782c8c3a5 Page element id attributes now have "uls-" prefix
Fixes failing Selenium tests.

Also:
- updated Ruby to version 2.1.2,
- updated all Ruby gems.

Paired with: Kartik Mistry

Change-Id: I1c614cb77f0760d6a84310ce602b0934f07445de
2014-06-06 12:20:55 +02:00
Antoine Musso
46e10abc6d bump mediawiki_selenium to 0.2.22
Change-Id: I468fbb840f37b0ecb720e8a529e5bff2e864338b
2014-04-25 20:26:19 +02:00
Željko Filipin
cd38e6a576 Features should have unique names
Paired with: Antoine Musso

Change-Id: Ic62b93f35aebd5b420a9e8a7525acb3a49e932a8
2014-04-23 12:29:57 +02:00
Zeljko Filipin
834b7aff49 Updated Ruby gems
mediawiki_selenium 0.2.21 does not display link to Sauce Labs when
running a local browser.

Paired with: Amir Aharoni
Bug: 58040

Change-Id: If5c7b480ee77c9341a15b5ad02b74f2413d04983
2014-04-22 15:22:04 +02:00
Željko Filipin
ff4bc9ba21 Changed Cucumber tags according to the convention
* Replaced @phantomjs-bug with browser specific tags (@firefox
@internet_explorer_10 @phantomjs).
* Replaced @custom-browser tag with @clean tag.
* Deleted cucumber.yml file since it is no longer used.
* Replaced old (no longer implemented) step names with new ones

The convention:

https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Requir
ed_tags

Paired with: Kartik Mistry
Bug: 60335
Bug: 62477

Change-Id: I54f9ccbaaeb843293fbc1608d53f0e12b6d74cbe
2014-04-11 17:19:42 +02:00
Željko Filipin
249d064c53 Implemented missing Cucumber step
Used in ime.feature:50.

Change-Id: I0bf52456e687d7ff2b1d54fc990d4ed5d2803a47
2014-03-25 12:01:44 +01:00
Zeljko Filipin
76b1d87151 Using the new way of starting a custom browser
mediawiki_selenium Ruby gem is now able to start local and remote browsers with
optional browser setup.

Paired with Kartik Mistry.

Bug: 62512
Change-Id: I61e5b688711b1976e8df8be94972fe35f6eeb9aa
2014-03-21 10:34:44 +00:00
Kartik Mistry
ab55d96031 Fixed spacing in return
Change-Id: I9ea35dc2c64526c0804706126ebe6db7b663fee6
2014-03-16 19:20:22 +05:30
Zeljko Filipin
b4af650730 Removed random page
Using a dedicated page instead of a random page. Paired  with Amir
Aharoni.
Bug: 62479
Change-Id: I3750ecf972f52f205fd30855455ef6259b9c911d
2014-03-11 16:13:16 +01:00
Kartik Mistry
3797187998 Autonym font browser tests refactoring
* Tofu detection selects system fonts over Autonym font.
 * Interlanguage Autonym font is blacklisted.
 * phantomjs bug is fixed.

Change-Id: I5c7433b917b8d7f79f706a4a7a97a6c6a9a6afa2
2014-03-11 10:45:50 +00:00
Zeljko Filipin
fd92954e1c Updated to mediawiki_selenium 0.2.9 to fix log in problems
Paired with Amir Aharoni.

Change-Id: Ie802ec65c0893bf3a40357d3e4292ce891fe178c
2014-03-06 15:39:31 +01:00
Zeljko Filipin
d38b431d2b Using @custom-browser Cucumber tag instead of @user_agent
Implementing the convention:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Option
al_tags

Bug: 61458
Change-Id: Iac411401a08eadfb04fd43f1d93ce2fd36fbea4a
2014-03-06 14:47:32 +01:00
vikassy
64ea5e05da Updated Ruby version from 2.1.0 to 2.1.1
Bug: 62152
Change-Id: I2f73432017b90af70fb2fb453b02f832a8bcb196
2014-03-04 03:32:22 +00:00
Zeljko Filipin
35f2a42e8e Cloudbees Jenkins jobs are now created using Jenkins Job Builder
All Jenkins jobs will fail until this commit is merged:

https://wmf.ci.cloudbees.com/view/uls/

Bug: 61778
Change-Id: Idc36a03291497fefa8aa4464004f423c7a07c90e
2014-02-22 11:59:16 +00:00
Zeljko Filipin
30368d121e Running tests at language-browsertests.wmflabs.org
This will revert: https://gerrit.wikimedia.org/r/#/c/114457/

Change-Id: I53d7adc685820d421d774c196642bddc9e5f19b0
2014-02-21 12:50:54 +00:00
Amir E. Aharoni
0be71e418e Remove failing tests from Commons
These tests fail because no Wikimedia has webfonts
enabled by default.
This will be addressed more thoroughly by rewriting
the tests to support the new setting, and by enabling
the feature by default on a new testing wiki.

Change-Id: Id197e0b2535097cf5e583e51427ca6130839e1ff
2014-02-20 17:58:23 +04:00
Amir E. Aharoni
05ab9f30dc Don't run the Autonym scenarios in beta sites, because they fail
This is supposed to be addressed more thoroughly in
I5c7433b917b8d7f79f706a4a7a97a6c6a9a6afa2
but until that is merged, they shouldn't run and cause failures.

Change-Id: Ie4e96f2cb0846b9117a26e9bfd902bbcab04eafd
2014-02-20 17:50:57 +04:00
Amir E. Aharoni
1ad4bf197c Don't run a feature with enabled webfonts on Beta Commons
This will fail because webfonts are currently disabled by default
on all Wikimeida wikis.

When a suitable wiki for running these tests will be created,
we'll make this feature run there.

Change-Id: Ia51c5d12bcd49621e85c83166faf855e3476bf5f
2014-02-20 17:30:36 +04:00
Kartik Mistry
efb1275fc7 Various fixes in font_selection tests.
1. Fixed comment in header comment (/s/disabled/enabled).
 2. Remove pending step for #56081 bug.

Change-Id: I9b1a74aa4c0305f529123f24dc05f8c8e5d4f58d
2014-02-18 11:27:01 +05:30
Antoine Musso
a97d2886e7 bump mediawiki_selenium to 0.2.3
mediawiki_selenium 0.2.3 let us specify the destination of screenshots
via SCREENSHOT_FAILURES_PATH env variable.

Change-Id: I199ce712f7e062bac613c66ac5fdcd5a83d3422f
2014-02-13 16:21:44 +01:00
Zeljko Filipin
cf57dfbf69 Moved login and reset preferences to mediawiki_selenium Ruby gem
Bug: 56088
Change-Id: I3d4150295ec2f66e5ad20a90769b7bd4bb14763f
2014-02-11 14:51:37 +01:00
Santhosh Thottingal
27771fdeaf Restore enableWebfonts pref and remove uls-enable
This patch restores the enableWebfonts preference, stored inside
the uls-preferences blob. It existed as 'enable-webfonts' in
the past and was removed in
If735a733717596fae03042c5e277bd538bd8501f

Each wiki can be configured to load the fonts by default
using the new global variable $wgULSWebfontsEnabled.
Its default value is true (to load fonts).

This also removes the preference 'uls-enable', recently added in
I71b70d8ee7c3cad7f49b32e5dc494ef4fc1bdb2f

The initialization of ext.uls.webfonts.js is changed as well,
so that minimal webfonts JS library code is loaded,
and the rest is loaded only if a user requests it.

Bug: 60304
Change-Id: I49e812eae32266f165591c75fd67b86ca06b13f0
2014-02-10 17:40:30 +05:30
Cmcmahon
4081163aa5 Merge "Normalize the font-family name in browser test" 2014-02-07 16:18:21 +00:00
Zeljko Filipin
de11d83b6f Renamed mediawiki-selenium Ruby gem to mediawiki_selenium
Bug: 60820
Change-Id: I5fb2db6b2da94b0554e324b39de631b4117be7eb
2014-02-07 13:38:57 +01:00
Kartik Mistry
473dc8536a Normalize the font-family name in browser test
Bug: 57101
Change-Id: I01a787f8576e309d313219bd560ce4be4469c438
2014-02-06 21:07:52 +05:30
jenkins-bot
086ad49f6a Merge "ci and default profiles are no longer needed" 2014-01-30 12:32:57 +00:00
Zeljko Filipin
22198ba467 ci and default profiles are no longer needed
Bug: 56085
Change-Id: If3e66ee47a5cef700e6a3f3699ef8b969837cd6d
2014-01-30 13:10:32 +01:00
Zeljko Filipin
0390c0b534 Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem
Bug: 56085
Change-Id: Ib3807bf61292beafb51faef307d0abd67c960995
2014-01-28 18:54:16 +01:00
Amir E. Aharoni
cf3f1564c5 Move a pending step to the end to get more passing steps
Change-Id: I2bfd0ed60838cc4f75b1e3340aabe7654bebb9ff
2014-01-23 14:50:01 +02:00
Santhosh Thottingal
6d8a889f79 Test a conservative sans-serif font-stack with Autonym font
To check how it renders in different platforms.

Change-Id: I5cf7b2e53a0f711fef32014cb72f7f4850857ac7
2014-01-15 17:18:14 +05:30