Commit Graph

1158 Commits

Author SHA1 Message Date
Roan Kattouw
d6ae72eb9c Don't trigger namespaced events, it breaks VisualEditor
Code like $input.trigger( 'focus.ime' ); doesn't make any sense. Event
namespaces exist for binding and unbinding and are irrelevant when
triggering. However, there's a bug in the version of jQuery that we
use (1.8.3) that causes .trigger( 'focus.ime' ) to perform a native
focus and call natively bound focus handlers, but only call jQuery
event handlers bound to 'focus.ime', not handlers bound to 'focus'.
This bug is fixed in jQuery 1.9+. http://jsfiddle.net/WGy9h/3/
demonstrates this bug.

The way ULS broke VE with this went like this:
* VE initializes and creates two contentEditable divs, the
  pasteTarget and the documentNode. It then focuses the documentNode.
* ULS loads jQuery.ime
* Once jQuery.ime loads, it first calls .trigger( 'focus.ime' ) on
  the pasteTarget
* jQuery focuses the pasteTarget, which means a blur is emitted on the
  documentNode
* In response to this blur event, VE disables the SurfaceObserver
* jQuery.ime then calls .trigger( 'focus.ime' ) on the documentNode
* jQuery focuses the documentNode, but does not call VE's focus handler
  because it's bound to 'focus' rather than 'focus.ime'
* This means VE's SurfaceObserver is not reenabled
* If the user then focuses something else then focuses VE again, a
  native focus event fires and the SurfaceObserver does get reenabled

Change-Id: I7c590599df4cf62418403bc1d1dccfc3c6db5fd3
2013-09-27 16:34:19 -07:00
Amir E. Aharoni
d501ad89de Replace deprecated method
Change-Id: I1b79c172d032d96651d5b5c36cbf0c662081da28
2013-09-26 23:08:53 -07:00
Kartik Mistry
039c91d1d5 Integration tests for live preview of display language
Bug: 53255

Change-Id: I1506ddd0ef68217ac114bdf4c29c62cd071b1900
2013-09-26 22:51:37 -07:00
Zeljko Filipin
7706d97c8a Renamed ULSPage to PanelPage
To make class name consistent with file name

Change-Id: If4d0f0a24d2534c9b73cc6cbb0ee14ab8c124ed9
2013-09-26 12:32:41 +02:00
Santhosh Thottingal
2d8522d1ba Keep correct lang attribute when display settings closed
Bug: 54594
Change-Id: I15b12e17b5a922cce6717577bc0d56dfd80ccfee
2013-09-26 07:36:13 +00:00
Zeljko Filipin
fb56c5f12c Fixed "Unsupported input language" scenario
Tested on my machine, it now works on both Firefox and Chrome. 

Change-Id: I8c810b355ed1407307b57699f8427f487ab1a08a
2013-09-25 16:13:11 +00:00
Zeljko Filipin
b085d38b13 Updated Ruby gems
Change-Id: Ic71cbcc10ca0b5a3b79933d9e0cf9f155c1b17d3
2013-09-25 17:37:28 +02:00
Zeljko Filipin
e72a38e73f Cleanup: removed ULS from file names and feature names
Change-Id: Id45289ba710b9b543744655f8fbd0f9483923956
2013-09-25 17:18:39 +02:00
Translation updater bot
0be0fcdd95 Localisation updates from http://translatewiki.net.
Change-Id: I4344955bde19655756089fb9b028ceab1086474c
2013-09-21 19:41:40 +00:00
Translation updater bot
883ec472e4 Localisation updates from http://translatewiki.net.
Change-Id: Ide785ae88cc6047396b7f9dc290758841789b0cd
2013-09-19 19:32:41 +00:00
Santhosh Thottingal
3fbbf05c26 Optionally exclude elements from applying webfonts
* Updates jquery.webfonts from upstream
* Introduces wgULSNoWebfontsSelectors configuration variable. It
  takes an array of jquery selector to which webfonts will not be
  applied if defined.

Change-Id: I0dc263f84620af4077f52e18eeb0f986ff0f13b9
2013-09-19 10:17:54 -07:00
Niklas Laxström
06a386fa83 This scenario does not work with anon language selection
Change-Id: Ia54d6de807e81ccbbd062633a49ec7313c869fa7
2013-09-18 00:41:46 +00:00
Niklas Laxström
12f7f84edd Fix the test I broke
Change-Id: I3f8181f84b387ab811f5efc16c734800e3639a15
2013-09-17 16:40:52 -07:00
Niklas Laxström
3fc1c3299c Simplify tests
Change-Id: Ide435d4d11e9ab03c953ed91e949d55e46c5137e
2013-09-17 15:16:52 -07:00
Niklas Laxström
2d62e3e7f7 Simplify test code
Change-Id: I65c3edc85ee8619c7e77cca7622e7025799bdcad
2013-09-17 14:38:16 -07:00
jenkins-bot
f1ab048beb Merge "Updated: Integration tests for off-screen IME selector" 2013-09-17 06:57:21 +00:00
Kartik Mistry
74e6ac4fc0 Updated: Integration tests for off-screen IME selector
1. Removed sleep 1.0, not needed,
2. Removed ascii_vector.rb and ascii_mono.rb as we use, using_params
now.

Change-Id: Ieeb0eb3a58805fcbfdfd0a3349a427d4757472cb
2013-09-17 12:18:51 +05:30
Niklas Laxström
f43a00d5b8 Refactoring tests
Collaboratively

Change-Id: I6c5417a0681f9bb8596c36600a569df2ddd7bf9e
2013-09-16 15:55:51 -07:00
Translation updater bot
6338d73c0e Localisation updates from http://translatewiki.net.
Change-Id: I0ffaacae675278f24001f7ab66f43869c90b3cf1
2013-09-15 19:25:47 +00:00
jenkins-bot
6cc358ffa9 Merge "Integration tests for off-screen IME selector." 2013-09-14 06:23:53 +00:00
Kartik Mistry
e53f9176ce Integration tests for off-screen IME selector.
Change-Id: I0b3253ba9cb19afae41612435ef0a9604814f3ed
2013-09-13 23:23:14 -07:00
Kartik Mistry
9db73d2a11 Update jquery.ime from upstream
Version: v0.1.0+20130914

Changes:
1. Improved Persian keyboard.
2. Show the menu correctly if it goes off-screen.
3. Removed unneeded code.
4. Ability to customise time out for IME selector widget.

Bug: 52154
Change-Id: Id87dee11456de0499450083f434b64e188b6d33f
2013-09-14 10:51:31 +05:30
Santhosh Thottingal
e0fa027b9f Fix typo in the fontname of Estrangelo Edessa
It was Estarngelo Edessa
Bug: 47229

Change-Id: I941c8c09bedcf58428f93231936f168f993cde8f
2013-09-11 18:09:22 -07:00
Translation updater bot
d2bfe31ead Localisation updates from http://translatewiki.net.
Change-Id: Ib9fe7b42b15a910b82a3f98f60d3117b93e77db1
2013-09-11 19:39:41 +00:00
Translation updater bot
ab138b61a3 Localisation updates from http://translatewiki.net.
Change-Id: Ice3eb63137e34a22d791704b09be8053971c6d97
2013-09-10 20:07:53 +00:00
Translation updater bot
b90a8fc02a Localisation updates from http://translatewiki.net.
Change-Id: I37b18a891d3597a35b1b475cfc875f655fc91bdc
2013-09-07 20:04:55 +00:00
jenkins-bot
a7904a6d01 Merge "Make more tests pass in sandbox.translatewiki.net" 2013-09-06 12:44:05 +00:00
jenkins-bot
438e745c46 Merge "Wait longer, so the preference is saved." 2013-09-05 21:11:03 +00:00
cmcmahon
813271b8a9 Wait longer, so the preference is saved.
Reported as bug 53772.

Change-Id: I8a0d6ae9d3cec06f953e6bb35abb9370e5551eec
2013-09-05 21:09:59 +00:00
Translation updater bot
9a6f05fe9e Localisation updates from http://translatewiki.net.
Change-Id: Ic5ee38507dc3f95c1cc0cbe3594505e2a501b627
2013-09-05 20:29:41 +00:00
Translation updater bot
3ced6e24a0 Localisation updates from http://translatewiki.net.
Change-Id: I70727242eb132b5422b134bbca32c9052cfb14ff
2013-09-04 19:48:51 +00:00
jenkins-bot
38e3a403bf Merge "Regression: Using [...] to change language does not activate apply button" 2013-09-04 11:07:23 +00:00
Niklas Laxström
e36d9b1cc3 Regression: Using [...] to change language does not activate apply button
Bug: 53736
Change-Id: If52beb73f9f3f74cde63bd846974540682066ab6
2013-09-04 07:00:53 +00:00
Santhosh Thottingal
8250d94625 Update jquery.ime from upstream
Version: v0.1.0+20130904
Changes:
1. Add Persian keyboard
2. In a ltr page with rtl input, if menu has no space in left,
flip it right

Bug: 50690
Change-Id: Id84fa09b93bd0e31d328bbdaedc4219ea6a9e75d
2013-09-04 12:28:13 +05:30
Niklas Laxström
bcb2dd8b82 Make more tests pass in sandbox.translatewiki.net
* When ULS is in personal, cancel opens the language selector
  again but apply doesn't.
* Created separate steps for testing the ULS trigger in personal
  position, different behavior with different configuration.

Change-Id: Ifb7f101f2bfacd32c11cba69e7f2c01fe9bd9bb7
2013-09-04 09:37:28 +03:00
Translation updater bot
ba065b586c Localisation updates from http://translatewiki.net.
Change-Id: Id0fa6b8fa377b1e1ba2cde0b2f0edf61aeac3df1
2013-09-03 20:59:35 +00:00
Translation updater bot
172c184615 Localisation updates from http://translatewiki.net.
Change-Id: If74a36af22c799e5b0c0780045a430a9f1090a48
2013-09-02 19:25:58 +00:00
Santhosh Thottingal
3af403fee5 Make the cancel and apply button applicable for all modules
If a user does changes in module A, does not save or cancel,
goes to module B, does some changes, moves to other modules,
and finally presses Apply, all changes should get saved.

Similarly, if a user cancels, all changes should get cancelled.

This required moving the cancel and apply button outside of modules
and managed by the language settings framework.

Modules get mw.uls.settings.apply or mw.uls.settings.cancel triggers
to do whatever they want to do on apply or save.

Includes some refactoring related to this.

Bug: 53256
Change-Id: I7d773d33a980a78604b36e39bf96a5686870124e
2013-09-02 17:03:13 +02:00
jenkins-bot
375c676fba Merge "Cleanup and add documentation for tags" 2013-09-02 14:40:54 +00:00
Niklas Laxström
975e69d880 Cleanup and add documentation for tags
* Fixed one scenario to work with the default setting
* Fixed one typo in scenario
* Removed unused tags
* Documented the tags currently in use

Change-Id: I14687782857daf79dcd497b934dff99fc45a3997
2013-09-02 17:14:25 +03:00
jenkins-bot
faf07138fd Merge changes Ie4f15f18,I4dbd9026
* changes:
  (bug 49738) Use correct name for wiki content language
  New scenario: Discarding a live preview of a font keeps the previous font
2013-09-02 10:50:19 +00:00
jenkins-bot
f6ca5376c2 Merge "Add test for language live preview cancellation" 2013-09-02 10:33:58 +00:00
Translation updater bot
a7daed7303 Localisation updates from http://translatewiki.net.
Change-Id: I4a3bdfa41509514a023a4de0b051cc1d4b661b06
2013-09-01 19:28:46 +00:00
Niklas Laxström
34146ea023 (bug 49738) Use correct name for wiki content language
Happens when anonymous user cannot change language, and the
language of the translation differs from the content language.

Change-Id: Ie4f15f1813eec992cfe060baf9cd7dcb5f8a0d95
2013-08-30 12:45:02 +03:00
Niklas Laxström
b90208affc New scenario: Discarding a live preview of a font keeps the previous font
Change-Id: I4dbd90263be5a35c654b850e6c3632959e8a3915
2013-08-30 12:18:26 +03:00
Niklas Laxström
53f19e9f70 Add test for language live preview cancellation
Change-Id: I4880667df23301f4235a05df575fb84554c17303
2013-08-30 10:47:01 +03:00
Niklas Laxström
773b8f42e6 Fix more tests for phantomjs
As a bonus got rid of JavaScript call.

Refactored uls-position code to a method.

Change-Id: I1df384a02909d430c12225525d5722a0520177ee
2013-08-30 10:47:01 +03:00
Niklas Laxström
54afab7ffc Assert that the login succeeded for more helpful error messages
Change-Id: I9f985d31de86fe2a062d10ca3f51fb2d7c727798
2013-08-30 10:47:01 +03:00
jenkins-bot
8472382a75 Merge "Make tests pass in phantomjs" 2013-08-30 07:38:51 +00:00
Translation updater bot
7801673c37 Localisation updates from http://translatewiki.net.
Change-Id: I009498a642aab4d36ef31d4881320ecb2a611cff
2013-08-29 19:23:15 +00:00