Our logEvent wrapper now returns jQuery.Promise too.
Added timeout out parameter to our logEvent wrapper. Unlike
GettingStarted, I didn't create separate logUnlessTimeout
function.
Chrome apparently emulates enter on links as a click, so
this catches enters, left and middle clicks, but not if
the link is opened via right click menu. Might not catch
enter in all browsers.
Change-Id: I4b0eb56e7c7d6e56f8fd99d536f9b60b94a2e09e
* Refactored the Cancel button handler code to cancel method in
display settings and input settings.
* When the user makes changes in multiple modules and clicks the Cancel
button or closes the language settings after that, cancel the changes in
all the modules. See bug 50564.
* The Apply button was always active in input methods module. Fixed the
logic for that.
* Renamed the enableApplyButton method to markDirty in both modules.
* Introduced isDirty attribute to the modules for optimizing the Cancel
method to avoid unnecessary restore actions.
* More minor cleanup and documentation.
Bug: 50564
Change-Id: I71f527bfb7dd7f6724e4365371ac3e4fc0723ed6
In Iddef0805ab a custom message store was introduced for ULS, but
there were updates in jquery.i18n that allows us to use default
message store again.
(see https://github.com/wikimedia/jquery.i18n/pull/40)
Change-Id: I86cb7a44efa83e5811824cd1104c6be11b1e2925
Because those windows are rendered later. The settings window inherits
fonts. But button in those panels doesn't inherit. Make sure all panel
elements have current font applied.
Change-Id: Ibb8b12b3d973023c49ef89a04d534081bf8ee87f
Issues fixed:
Incorrect position of ULS when accessed from more languages button
of input/display settings, when language settings opened from ime
menu.
Arrow(callout) appearing for ULS when opened from more languages
button of input/display settings, when language settings opened from ime
menu.
Used a class 'callout' to mark whether windows need callout arrow or not.
Bug: 49060
Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
It is possible that the count reach more than SUGGESTED_LANGUAGES_NUMBER
before it reach the
languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER
check. This will cause the loop to run for all languages.
Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184
Also make sure that correct language is passed to the getFont
It was wrong in current version - UI language was passed always
(introduced in a refactoring to avoid code duplication for content
and ui language- commit: 98bb1c200c )
Change-Id: I62860f9d62538915628ad21e5d904e56bdcc9430
Directly show language settings instead of showing ULS language selector
and then simulating click on language settings
Change-Id: Iafb15ac9a7140fcce9e71ed933be6c55be81dc7e
* Add a caret for the ULS in the sidebar.
* Adjust the panel's position.
* Immediately show the Display settings instead of the language list.
Also added documentation.
Change-Id: I6635092e9e020cb1f5b51f437abde4e81c31ae48
Disabling was not working actually. If disabled donot call
webfonts() on body. Also addresses Bug 39992.
Change-Id: I8e4d466dd9271604be6ae722c49357b192651950
1. Fix a regression introduced in
27039e1141
- a change in a class name caused the back link not to appear.
Now the link is back.
2. Copy the same logic to the input settings panel.
Change-Id: Ie80032ee2e14853f96cfb3b48dec5c85398c8373
When the user selects a UI language in the display settings dialog, the UI of
the dialog should preview immediately to the selected language. The change will
be only persisted if the user selects "apply changes".
Change-Id: I362e75c38c9d4a9921319f510653e2152d50fbb4
Make the button disabled initially.
Change the disabled property to false on every possible change.
For now this is only for display settings.
Change-Id: Ifea533a9606f66b5dfeb38075186ddec596330a6
* It can be a user preference using the ULS Input method settings
* It can be a mediaWiki configuration $wgULSIMEEnabled
Change-Id: Ic5fb4932d62ab18db5d3b10ca81c0f6bfe9fd29e
* Just use key,value system and drop the concept of groups
* Abstract the preferences for each type of systems(display, input)
to have meaningful APIs
Change-Id: I25423667adf6ca181a4027cdfc4ed378f36a94ba
