Commit Graph

134 Commits

Author SHA1 Message Date
Santhosh Thottingal
3d6e4a007f jquery.i18n message store for ULS
Bug: 49935
Change-Id: Iddef0805abbf9b4ff0e606fc311c57e9dfa7107d
2013-07-08 06:55:21 +00:00
Santhosh Thottingal
acbc10c494 After rendering input and display settings, refresh webfonts
Because those windows are rendered later. The settings window inherits
fonts. But button in those panels doesn't inherit. Make sure all panel
elements have current font applied.

Change-Id: Ibb8b12b3d973023c49ef89a04d534081bf8ee87f
2013-07-02 10:53:21 +00:00
Siebrand Mazeland
1f9bf6f82c Update indentation and newlines
Change-Id: Iac833df12a00949d32f2ce2fc26a657bab3d8229
2013-06-17 16:36:34 +02:00
jenkins-bot
f0eca06c1c Merge "Set the language for the settings panel for correct webfonts" 2013-06-13 09:51:16 +00:00
Santhosh Thottingal
d36f6c516e Set the language for the settings panel for correct webfonts
Change-Id: Ia404f5e0b50d5b9114255c2e1e7daca39c79d414
2013-06-13 11:22:32 +05:30
Santhosh Thottingal
f0b3e6524c Cleanup
Minor whitespace, coding convention cleanup

Change-Id: Ibb10ce64ad4c35bfd6f924665243961c80b81714
2013-06-11 10:24:13 +05:30
Santhosh Thottingal
e9ab300889 Fix: ULS popup moves to sidebar if opened from ime menu
Issues fixed:
Incorrect position of ULS when accessed from more languages button
of input/display settings, when language settings opened from ime
menu.

Arrow(callout) appearing for ULS when opened from more languages
button of input/display settings, when language settings opened from ime
menu.

Used a class 'callout' to mark whether windows need callout arrow or not.

Bug: 49060
Change-Id: Ic4c0a1e386918494a0d006a02dd0cf93ef269163
2013-06-07 14:26:46 +00:00
Santhosh Thottingal
c9aa1f1130 Correct the loop logic for language buttons
It is possible that the count reach more than  SUGGESTED_LANGUAGES_NUMBER
before it reach the

languagesForButtons.length === SUGGESTED_LANGUAGES_NUMBER

check. This will cause the loop to run for all languages.

Change-Id: Ie6190d1c80c2a7152af490db2bc115ecdfde4184
2013-06-06 06:36:36 +00:00
Santhosh Thottingal
73716f3f67 Remove lot of scroll to view related code
Just use javascript scrollIntoView to do that.
Also remove duplication of code related to this

Change-Id: Ied1235a85f4fe2d99afa127737979c24d3591118
2013-06-03 05:44:17 +00:00
Santhosh Thottingal
65711c312d Fix cancel behaviour of display settings
Font selection becomes persistent despite cancelling it
Bug: 47976

Change-Id: Iea4b65a8a13da3cb4a86f5b6521d62cb1372b42a
2013-05-27 18:24:14 +05:30
Santhosh Thottingal
f23666a15a Get the saved font using the fontSelector defined in mw.webfonts.setup
Also make sure that correct language is passed to the getFont
It was wrong in current version - UI language was passed always
(introduced in a refactoring to avoid code duplication for content
and ui language- commit: 98bb1c200c )

Change-Id: I62860f9d62538915628ad21e5d904e56bdcc9430
2013-05-27 14:43:30 +05:30
Amir E. Aharoni
2ef2376bfe Remove webfonts enabling checkbox and associated preference
Bug: 48535
Change-Id: If735a733717596fae03042c5e277bd538bd8501f
2013-05-27 07:59:45 +03:00
Santhosh Thottingal
bb3e72f5a0 Simplify the language settings display
Directly show language settings instead of showing ULS language selector
and then simulating click on language settings

Change-Id: Iafb15ac9a7140fcce9e71ed933be6c55be81dc7e
2013-05-20 10:21:38 +05:30
jenkins-bot
ee9fe23599 Merge "Scroll language settings on all changes" 2013-05-16 09:52:35 +00:00
jenkins-bot
394f4ab943 Merge "Set the position of display settings to match ULS" 2013-05-16 09:52:15 +00:00
Amir E. Aharoni
07465bf20c Set the position of display settings to match ULS
Bug: 47822
Change-Id: I7b04a831b2c5d7932564a3cdde94be0e233f7a7b
2013-05-16 09:48:44 +00:00
Amir E. Aharoni
73e6e01c22 Scroll language settings on all changes
Change-Id: I550f309d713cb6aac6b18b326379b879dc0b9589
2013-05-15 15:33:26 +03:00
Amir E. Aharoni
977b36ade6 Replace id uls-more-languages with class
Change-Id: I51f74f0b3bcec1b45dd5588638346a6d02a44e52
2013-05-15 10:45:35 +03:00
Niklas Laxström
f275dbeb98 I18n for System font
Bug: 47819
Change-Id: I9244aab0ec32c27bfc56dd5a441f02a9783e5fb1
2013-05-03 08:43:08 +00:00
Amir E. Aharoni
03546744ba Changes to show the display settings in the sidebar
* Add a caret for the ULS in the sidebar.
* Adjust the panel's position.
* Immediately show the Display settings instead of the language list.

Also added documentation.

Change-Id: I6635092e9e020cb1f5b51f437abde4e81c31ae48
2013-05-02 07:51:49 +03:00
Amir E. Aharoni
422371f688 Don't let anonymous users change interface language
Language selector is still opened by default

Change-Id: Iee7d83179e71b4546d8f3cd4f6fb053262ce05e2
2013-04-29 10:47:27 +00:00
Amir E. Aharoni
cfc66213f1 Cleanup for jslint and coding conventions
Change-Id: I6884759d9622220721840f44220648dce7838ff6
2013-04-28 23:42:47 +03:00
Pau Giner
8ca0733607 Styling for the Language settings panel
CSS adjustments for the font and input dialogs.

Change-Id: I75049afc7a71ed78edb6e17970699a28f2f2d04e
2013-04-26 18:51:38 +02:00
jenkins-bot
74941191fc Merge "Add help text above the buttons" 2013-04-25 12:26:40 +00:00
Amir E. Aharoni
c61ff7d376 Add help text above the buttons
Change-Id: I73dfb7e9386f965a49ae8734d136972286f82605
2013-04-25 00:53:38 +03:00
Amir E. Aharoni
b27d0a902b Show the web fonts selectors only if they are enabled
Change-Id: I70b9f9468154b542a80a9717afdb414530bd0d37
2013-04-23 18:54:11 +03:00
Amir E. Aharoni
865ac4d380 Split language settings view into two tabs
Change-Id: I539b9794227e0aeac9a759b7e4aa3daf8b73a5c8
2013-04-23 14:33:48 +00:00
Amir E. Aharoni
d0a340374e Fix variable name
Change-Id: Ic3e39197e62ddbd25da006d660dc10135bf1218e
2013-01-15 17:40:07 +02:00
Siebrand
ca9a7e6f3c Merge "Fix the webfonts preferences" 2013-01-02 15:21:19 +00:00
Amir E. Aharoni
80ce8e068b (bug 42440) Fix button state when canceling
Also changed class names to make finding cancel buttons easier.

Change-Id: Ieaf242eb03add06038307d913a87a196d41ba01d
2013-01-02 08:04:50 +00:00
Santhosh Thottingal
086ee5ff1d Fix the webfonts preferences
Disabling was not working actually. If disabled donot call
webfonts() on body. Also addresses Bug 39992.

Change-Id: I8e4d466dd9271604be6ae722c49357b192651950
2013-01-01 08:49:26 +02:00
Amir E. Aharoni
e8ed043352 (bug 42382) Indicate context in input settings/more languages
1. Fix a regression introduced in
27039e1141
- a change in a class name caused the back link not to appear.
Now the link is back.

2. Copy the same logic to the input settings panel.

Change-Id: Ie80032ee2e14853f96cfb3b48dec5c85398c8373
2012-12-10 21:50:36 +02:00
Amir E. Aharoni
c81419cc9e that -> displaySettings
Change-Id: I7233f7703bf6a9f2d79ed9e3cb4b744c703e09ef
2012-12-10 15:25:30 +02:00
Santhosh Thottingal
442561663c Fix Bug 39684 - UI language change preview in display settings
When the user selects a UI language in the display settings dialog, the UI of
the dialog should preview immediately to the selected language. The change will
be only persisted if the user selects "apply changes".

Change-Id: I362e75c38c9d4a9921319f510653e2152d50fbb4
2012-11-26 08:49:41 +00:00
Amir E. Aharoni
d912fbccfe (bug 39685) Disable the Apply button until there are changes
Make the button disabled initially.
Change the disabled property to false on every possible change.

For now this is only for display settings.

Change-Id: Ifea533a9606f66b5dfeb38075186ddec596330a6
2012-11-22 15:03:02 +02:00
Santhosh Thottingal
7c4646a059 Remove href=#, to fix Bug 41988
Change-Id: I8eacaa452eb71d237fc671aa63c4707b8e14a83f
2012-11-19 10:59:26 +05:30
Siebrand Mazeland
98d7a8d9f9 Reformat code.
Change-Id: Ic0a5b37fa01b4a13023e66af0518ea94919ee880
2012-11-11 10:34:10 +01:00
Ershad K
b37b33e02f Fixed Bug 39832 - Cancel / Apply button on Display settings
Change-Id: Ie536dbe1615db98c201b8c7fd1b5b58647bb1199
2012-11-11 12:35:40 +05:30
Santhosh Thottingal
c48b270dec Fix Bug 41804 - Display Settings shows dual labels for Font Selection
Change-Id: I46a9a67595840d0e67b95226f6d1fa17de1946e5
2012-11-08 14:48:31 +05:30
Niklas Laxström
4b811a5997 Avoid contstructing html with concatenation
Fixes potential security issue, bug 41395.
Change-Id: I55c79e41de6084d18c49b8bb715a7f49e19dc7e9
2012-11-01 12:25:27 +00:00
Santhosh Thottingal
fc29a7e587 Option for disabling the IME system
* It can be a user preference using the ULS Input method settings
* It can be a mediaWiki configuration $wgULSIMEEnabled

Change-Id: Ic5fb4932d62ab18db5d3b10ca81c0f6bfe9fd29e
2012-10-31 12:57:14 +05:30
Santhosh Thottingal
1c72077c89 Cleanup
whitepace, unwanted fixmes, wrong comments, jshint

Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e
2012-10-29 14:27:40 +05:30
Amir E. Aharoni
98bb1c200c (bug 40693) Refactor font selector creation code
Change-Id: Id9560ad326cbd5202553da872b5fb0254c074109
2012-10-26 07:11:53 +00:00
Santhosh Thottingal
4b09afb2ba Simplify the preference system
* Just use key,value system and drop the concept of groups
* Abstract the preferences for each type of systems(display, input)
  to have meaningful APIs

Change-Id: I25423667adf6ca181a4027cdfc4ed378f36a94ba
2012-10-23 09:59:26 +05:30
Santhosh Thottingal
59da3610f4 Jshint fixes for displaysettings
Change-Id: I29549893fa9081f5af3d7108a7515963ecf6bfc9
2012-10-16 16:58:51 +05:30
Amir E. Aharoni
0385ed8bfb (bug 39531) Only show the fonts dropdown if there are fonts
The Display settings template is wrapped in a new <div>
to allow easy $template.find() queries.

This change requires a change in jquery.webfonts, that makes
the lib function return an empty list when there are no fonts:
https://github.com/wikimedia/jquery.webfonts/pull/1

Change-Id: Ief5a920439df340360a44ca95de2a7f070b96d5d
2012-10-15 17:00:31 +02:00
Amir E. Aharoni
2ad892ae81 Removed "Select prefered font" heading
It seems redundant to me: There are one or two dropdown menus for
selecting fonts, with pretty clear labels.

Change-Id: If6134997b7c34eeb32efed1dcee13c61d8af7750
2012-10-11 08:41:09 +02:00
Santhosh
c3b26001d0 Merge "(bug 39535) Fix the creation of language buttons" 2012-10-10 11:11:35 +00:00
Santhosh
d9885d1522 Merge "Refactor font selection HTML" 2012-10-10 11:01:46 +00:00
Amir E. Aharoni
3699095401 (bug 39535) Fix the creation of language buttons
Assure that the language buttons in the display settings always
show the content and the UI language and that all the buttons are
filled with some language (by assuming major world languages if
nothing more likely was found).

Also other fixes:
* Add lang and dir attributes for the languages.
* General refactoring and better variable names.

Change-Id: Ie6a93439237b389179ebc6c4a5df34c1566a5e12
2012-10-09 17:21:00 +02:00