If a user does changes in module A, does not save or cancel, goes to module B, does some changes, moves to other modules, and finally presses Apply, all changes should get saved. Similarly, if a user cancels, all changes should get cancelled. This required moving the cancel and apply button outside of modules and managed by the language settings framework. Modules get mw.uls.settings.apply or mw.uls.settings.cancel triggers to do whatever they want to do on apply or save. Includes some refactoring related to this. Bug: 53256 Change-Id: I7d773d33a980a78604b36e39bf96a5686870124e
38 lines
1.4 KiB
Gherkin
38 lines
1.4 KiB
Gherkin
@commons.wikimedia.beta.wmflabs.org @en.wikipedia.beta.wmflabs.org
|
|
Feature: ULS trigger in personal toolbar
|
|
|
|
@uls-in-personal-only
|
|
Scenario: Open language selector
|
|
Given I visit a random page
|
|
When I click language selector trigger element
|
|
Then I should see the Language selector
|
|
|
|
@login @uls-in-sidebar-only
|
|
Scenario Outline: Opening language settings from sidebar
|
|
Given I am <user status>
|
|
And I am on <page type>
|
|
When I click the cog icon by Languages in the sidebar
|
|
Then I see the <user status> language settings panel
|
|
|
|
Examples:
|
|
| user status | page type |
|
|
| logged out | a page without interlanguage links |
|
|
| logged in | a page with interlanguage links |
|
|
| logged out | a talk page without interlanguage links |
|
|
| logged out | a talk page with interlanguage links |
|
|
|
|
@login @uls-in-sidebar-only
|
|
Scenario Outline: Closing language settings without saving
|
|
Given I am <user status>
|
|
And I am on a page without interlanguage links
|
|
When I click the cog icon by Languages in the sidebar
|
|
And <close method>
|
|
Then I do not see the Language Settings panel
|
|
And I click the cog icon by Languages in the sidebar
|
|
And I see the <user status> language settings panel
|
|
|
|
Examples:
|
|
| user status | close method |
|
|
| logged in | I click X |
|
|
| logged out | I click Cancel |
|