Commit Graph

388 Commits

Author SHA1 Message Date
Kartik Mistry
27c21219b4 Update package.json and fix eslint issues (#322) 2018-09-06 15:41:27 +05:30
Amir Aharoni
9ab4deeb4e Update language-data from upstream
Add Montenegrin (cnr).
2018-09-05 17:05:18 +03:00
Amir Aharoni
248e43a76a Update language-data from upstream
* Remove capital letter from the  Armenian autonym
* Update Santali autonym to the Ol Chiki script
* Add Eastern Pwo (kjp)
* Add Fula language to several countris in regions data

Updating to
5e8bf8b95f6123ab7522ec7876c8399ffd3f6e04
2018-09-03 09:07:53 +03:00
Niklas Laxström
9ff574c8cf Update language data to 9384a83
Add cak
2018-08-29 18:40:12 +05:30
jhsoby
61fa235e84 Update language-data from upstream
* Adding Fang (fan)
* Adding Bunun (bnn)
* Adding Garhwali (gbm)

Updating to
wikimedia/language-data@9e30563
2018-08-07 11:45:11 +02:00
Amire80
37651ed7c1 Update language-data from upstream
* Fixing the Fon autonym
* Adding Kaqchikel
* Fixing es-419 spelling

Updating to
d52eb59fd8
2018-06-24 21:54:53 +03:00
Pl217
44bd07f038 Fix onInputChange being called twice
ULS input element had onInputChange() handler attached to
change, textInput and input events.

That caused onInputChange() to be called twice when there is user
input and ULS gets closed, since 'change' event fires when
<input type="text"> element loses focus.

Registering handler only for 'input' is sufficient for the intent.
2018-05-29 15:21:11 +03:00
Pl217
5dfca5fd8a Replace jQuery.proxy() with Function.prototype.bind() 2018-05-28 12:06:38 +03:00
Amire80
2c1b2dd1b8 Group languages in each region by script group
sortByScriptGroup and getLanguagesByScriptGroup are updated from language-data.
(jquery.uls.data.utils should be merged to language-data.)

This resolves downstream bug
https://phabricator.wikimedia.org/T189090
2018-05-22 17:50:44 +03:00
Amire80
4088411430 Update language-data with the Fon language 2018-05-18 20:03:10 +03:00
Amire80
f4f2808f49 Update language-data from upstream
* Add gor and btm
* Update autonym for brx

Updating to
057affa5a1
2018-04-30 13:51:03 +05:30
Amir E. Aharoni
e5ec92f35c Update language-data from upstream (#311)
Add the following languages:
* Northern Ndebele (nd)
* Okanagan (oka)

Update autonyms for the following languages:
* Kurdish (ku)
* Korean (DPRK variant, ko-kp)

Updating to
aab40a4f6f
2018-04-02 14:25:37 +05:30
Amire80
31696b4074 Add maxlength to the languagefilter input
This input field is only for language names. There's no reason for it
to have something longer. Looking at the logs of searches,
people sometimes write very long things there: gibberish,
URLs, inappropriate search strings, mistaken pastes from other places,
and so on.

So it should be limited by maxlength.

It's practically never useful after 20 characters, but setting at 40
just to be on the safe side. The longest language name in langdb is 34.
2018-03-26 15:13:15 +03:00
Amire80
274f7b15a1 Add documentation for the event argument 2018-03-26 11:41:54 +03:00
Amire80
119f3565f1 Pass the event to ULS core select()
Follow up to #305.
2018-03-26 11:41:54 +03:00
Amire80
99c979edcf Update options defaults and documentation
* Add ulsPurpose to README
* Add default undefined for noResultsTemplate
* Reorder options in the README according to defaults in jquery.uls.core.js
2018-03-21 11:04:43 +02:00
Niklas Laxström
798e200b56 Merge pull request #305 from amire80/T189582
Pass the event object when calling the click handler
2018-03-15 18:15:50 +02:00
Amire80
1120ab276c Update the argument for noResults in lcd
Follow up to #306.
2018-03-15 17:05:01 +02:00
Amire80
970d073efa Send a data object in $.trigger
There was a mistake in #299: the $.trigger() must take only one argument
for extraParameters. Sending another parameter causes NULL to be logged in
EventLogging for ulsPurpose.
2018-03-15 11:57:02 +02:00
Amire80
f11634e6d3 Pass the event object when calling the click handler
This will allow distinguishing Click and Ctrl/Command-Click.
See downstream bug https://phabricator.wikimedia.org/T189582
2018-03-13 14:34:11 +02:00
Niklas Laxström
c9c2056d04 Update language-data to 9a506b9 2018-03-05 18:56:02 +05:30
Amire80
00ff49e190 Convert ulsPurpose from a data attribute to an languagefilter option 2018-03-05 12:58:00 +02:00
Amire80
ddb691a918 Allow identifying the context of the different ULS panels within one app
Add the ulsPurpose option. Empty string by default.

This is useful for web application that use ULS in several different context,
and need to distinguish what was the purpose of the particular ULS panel.

An example of usage can be found at
https://phabricator.wikimedia.org/T179402
2018-03-04 23:01:35 +02:00
Santhosh Thottingal
1f900843fe i18n for the noResultsTemplate
See https://phabricator.wikimedia.org/T187390
2018-02-16 09:34:54 +05:30
Pl217
4cb4fe2370 Merge pull request #275 from wikimedia/srpski
Fix "srpski" not finding results in Wikipedia compact links
2018-02-08 15:52:03 +01:00
Niklas Laxström
eccd0e1945 Change code structure a bit per code review comments 2018-02-08 15:26:15 +02:00
Santhosh Thottingal
c2eb7a7850 Use Array.prototype.indexOf instead of $.inArray
All our supported browsers now have this ES5 method.
2018-02-08 17:23:12 +05:30
Niklas Laxström
0352b3df0d Fix to avoid displaying duplicate results caused by redirects 2018-02-07 15:24:15 +02:00
Pl217
819b3b0414 Make ULS responsive
* Make ULS responsive
* Depend on both screen size and number of languages when calculating
ULS menu width.
* Introduce resize listener to responsively recreate ULS when screen
size changes.
2018-02-07 17:30:52 +05:30
Niklas Laxström
9fba3ab728 Fix my broken merge conflict result 2018-02-06 16:41:26 +02:00
Niklas Laxström
2b1cc8678f Merge branch 'master' into srpski 2018-02-06 16:31:46 +02:00
Pl217
54a466ee52 Merge pull request #283 from santhoshtr/keydown-simplify
Simplify key press event handlers
2018-02-06 11:19:45 +01:00
Santhosh Thottingal
3161b34b2b language-data update: Add Western Armenian to known languages 2018-02-02 11:55:54 +05:30
Niklas Laxström
bb8b48aa38 Stop rendering languages twice on initial display
The resultHandler is responsible for updating the `LanguageCategoryDisplay`, so we should not call `render` separately in `search` when there is no search query.

https://phabricator.wikimedia.org/T185086
2018-01-31 16:52:23 +05:30
Santhosh Thottingal
081310b45e Style adjustments for no-results
* 20px spacing above and below the "No results found" message.
* 12px spacing above and below the search indications ("You can search by...")
* Adjusting the text color to use Base20 (#54595D)
* Adjust the background to use the same background color as the area above it (#FCFCFC).
* Add a top border in Base80 (#EAECF0) to separate both areas.

See https://phabricator.wikimedia.org/T175235
2018-01-30 12:52:47 +05:30
Niklas Laxström
d349937772 Do not group search results by region
* Documentation updates
* Do not group search results by region
* Disable grouping by script when region grouping is disabled
* Add docs, clarify names per code review
* Fix bool -> boolean for consistency
2018-01-16 17:04:29 +05:30
Santhosh Thottingal
2aa43148bb Custom no-results message support (#286)
* Custom no-results message support
* Refactoring and clean up for LanguageCategoryDisplay class
* Document the options for LanguageCategoryDisplay class
* Reduce the spreading of no results handler code
* Add an option to accept no results template
* Remove unwanted, unused constructor too
* Use CSS to hide or show the no-results view
* Remove the unwanted noresults method in jquery.uls.core, directly
  call the same method of lcd.
* Add an example
* Support a function returning jquery element as the no-result handler
2018-01-12 16:05:11 +02:00
Santhosh Thottingal
37c9d66a2b Use .siblings to locate the suggestions, clear elements for efficiency (#285) 2018-01-10 09:13:56 +02:00
Santhosh Thottingal
bccf103900 Removing assigned ids to elements that are not guaranteed to be unique (#284)
It is a bad practice to assign id attributes when there is no guarantee
about the uniqueness of element. ULS should function even if there are
more than one instance of it is present in a page.
2018-01-09 09:47:47 +02:00
Santhosh Thottingal
f46aad0a01 Use .on('event', handler) pattern instead of .event(handler) 2018-01-08 12:22:02 +05:30
Santhosh Thottingal
e67e1e42ee Simplify key press event handlers
Remove eventSupported checks and just rely on jquery.keydown
2018-01-05 15:00:31 +05:30
Santhosh Thottingal
2a77df6c41 Use eslint and stylelint, fix all errors (#282)
* Use eslint and stylelint, fix all errors

* Remove jshint, jsbeautify
* Use Object.keys directly since that is available in all major browsers
* Fixes for eslint, stylelint errors
* stylelint is not included in grunt test yet because jquery.uls.mobile.css
  has so many !important and need to figure out whether they are really needed
2018-01-04 15:58:35 +02:00
Santhosh Thottingal
63e1b06514 Update language data
* Make Spanish available under the Oceania region
* Add the Kumyk language
2017-12-07 16:05:33 +05:30
Niklas Laxström
7119bdff5c Ensure autofillLabel is undefined if searchApi fails 2017-11-29 10:31:55 +02:00
Niklas Laxström
82eee93dbd Improve search code
* Always use searchAPI if provided
* Clean up code flow to be easier to follow

https://phabricator.wikimedia.org/T73891
2017-11-27 14:22:01 +01:00
Niklas Laxström
1dcb533b42 Fix "srpski" not finding results in Wikipedia compact links
See also https://phabricator.wikimedia.org/T178996
2017-10-27 12:12:49 +03:00
Niklas Laxström
2fd96dd684 Merge pull request #271 from santhoshtr/language-data-node-module
Use wikimedia/language-data node module for data
2017-10-12 14:48:27 +03:00
Niklas Laxström
ca550e22cd Improve how "no search results" is handled
* Drop the ugly height: 100% hack and do it properly and remove TODO
* after( $suggestions.show() ) seems to not work as expected in recent
  jQuery versions. Changed it to manipulate the presence of 'hide'
  class properly.
* Consistency fix in a comment
* Fixed a bug where creating multiple ULS instances would break the
  "no search results" functionality. This is because we were appending
  a jQuery element wrapped in a $(). This is obviously a no-op and a
  regression when the template actually was a string and not jQuery.
  Fixed by using clone() on it.

https://phabricator.wikimedia.org/T175233
2017-09-07 11:22:26 +02:00
Santhosh Thottingal
6d6a1326b5 Use wikimedia/language-data node module for data
Now that we have this node module, let us use that as upstream
for data
2017-08-28 17:46:09 +05:30
Amire80
c6c08537f7 Redirect skr to skr-arab in langdb
This language is being added to MediaWiki, so we need to make
sure it will be identified.
2017-07-22 10:46:13 +03:00