Commit Graph
7 Commits
Author SHA1 Message Date
Bartosz DziewońskiandNiklas Laxström f00cf295d3 Optimize all SVGs
Passed with svgo 0.4.2 <https://github.com/svg/svgo>, then prepended
'<?xml version="1.0" encoding="UTF-8"?>' prolog to each file since
svgo sees it fit to remove it and that breaks file type detection.
svgo truncated all numerical values to a maximum of 3 decimal places
of precision.

world_map.svg: Removed very tiny separated path segments (by
insetting and then outsetting the path). Scaled down to the size at
which the image is used. This makes the image smaller than 32 KiB so
it will now be inlined be resource loader instead of beign requested
separately.

Image            orig     new
clear            1268     298
close            1370     369
icon-language    2560    1816
search           1025     480
world_map       71624   19488
2014-02-20 08:47:09 +00:00
MatmaRex 5c6c24d314 RegionSelector: Scroll to appropriate area instead of rebuilding the list
This has been suggested on bug 39925.
2013-07-09 17:07:02 +02:00
MatmaRexandSanthosh Thottingal c78371ff68 Use .detach() to keep jQuery events and data associated with elements
.remove() helpfully kills them all.
2013-06-27 16:35:02 +05:30
MatmaRexandSanthosh Thottingal 148d43bf44 Restore the events jQuery helpfully removes 2013-06-27 16:34:49 +05:30
MatmaRexandSanthosh Thottingal 8a1e3eb18e Remove lazyload functionality entirely
It was merely a stopgap solution to the problem of the dialog taking
forever to load. With that problem solved all of this awful code is no
longer needed.
2013-06-27 16:31:50 +05:30
MatmaRexandSanthosh Thottingal 8341bb8e21 Disable lazyload for language list
The loading should be fast enough now after Id9397631 is merged,
taking no more than a second or two to render entirely. We could
consider showing a spinner while it's loading, but it doesn't seem
necessary.

This makes bug 39923 invalid.
2013-06-27 16:30:17 +05:30
MatmaRexandSanthosh Thottingal e1d65006dd RegionSelector: Avoid reflows when generating the list
Every time an item is added to the list - 387 times for me - we
shuffle elements around and add at least one new one. This causes
browsers to trigger style recalculation (to figure out which styles
apply to elements with such and such classes) and content reflows
(how the text and elements are wrapped to fit available width).

We can avoid this by simply detaching the parent element from the DOM
tree and attaching it back once we're done - this make it only trigger
one recalculation and one reflow.

In my profiling on Opera on a Thinkpad T60 (with lazy-loading
disabled), these two steps took respectively around 600ms and 400ms.
Now they're down to around 50ms each.
2013-06-27 16:28:04 +05:30