build: Update eslint-config-wikimedia to 0.22.1

Change-Id: I02692eeabb23c5b99997faa7a17d42f019148ed1

.eslintrc.json

@@ -1,14 +1,6 @@
 {
 	"root": true,
 	"extends": [
-		"wikimedia/client-es5",
-		"wikimedia/jquery",
-		"wikimedia/mediawiki"
-	],
-	"rules": {
-		"no-jquery/no-global-selector": "off",
-		"mediawiki/class-doc": "warn",
-		"no-shadow": "warn",
-		"compat/compat": "warn"
-	}
+		"wikimedia/server"
+	]
 }

Gruntfile.js

@@ -1,6 +1,7 @@
-/* eslint-env node, es6 */
+'use strict';
+
 module.exports = function ( grunt ) {
-	var conf = grunt.file.readJSON( 'extension.json' );
+	const conf = grunt.file.readJSON( 'extension.json' );
 
 	grunt.loadNpmTasks( 'grunt-banana-checker' );
 	grunt.loadNpmTasks( 'grunt-eslint' );

package.json

@@ -5,10 +5,10 @@
 		"test": "grunt test"
 	},
 	"devDependencies": {
-		"eslint-config-wikimedia": "0.20.0",
-		"grunt": "1.4.0",
+		"eslint-config-wikimedia": "0.22.1",
+		"grunt": "1.4.1",
 		"grunt-banana-checker": "0.9.0",
-		"grunt-eslint": "23.0.0",
+		"grunt-eslint": "24.0.0",
 		"grunt-stylelint": "0.17.0",
 		"postcss-less": "6.0.0",
 		"stylelint-config-wikimedia": "0.11.1",

resources/js/.eslintrc.json

@@ -0,0 +1,11 @@
+{
+	"root": true,
+	"extends": [
+		"wikimedia/client-es5",
+		"wikimedia/jquery",
+		"wikimedia/mediawiki"
+	],
+	"rules": {
+		"no-jquery/no-global-selector": "off"
+	}
+}

resources/js/ext.uls.common.js

@@ -192,6 +192,7 @@
 	};
 
 	mw.uls.getAcceptLanguageList = function () {
+		// eslint-disable-next-line compat/compat
 		return mw.config.get( 'wgULSAcceptLanguageList' ) || window.navigator.languages || [];
 	};
 

resources/js/ext.uls.dialog.js

@@ -117,7 +117,6 @@
 			switch ( event.key ) {
 				case 'Esc':
 				case 'Escape':
-					// eslint-disable-next-line no-use-before-define
 					close();
 					event.preventDefault();
 					break;

resources/js/ext.uls.displaysettings.js

@@ -119,6 +119,8 @@
 
 		/**
 		 * Loads the webfonts module sets the `webfonts` property when its safe to do so
+		 *
+		 * @return {jQuery.Promise}
 		 */
 		setupWebFonts: function () {
 			var d = $.Deferred();
@@ -133,7 +135,7 @@
 					d.resolve();
 				}.bind( this ), 1 );
 			}.bind( this ) );
-			return d;
+			return d.promise();
 		},
 		/**
 		 * Render the module into a given target

resources/js/ext.uls.inputsettings.js

@@ -271,16 +271,16 @@
 
 			function buttonHandler( button ) {
 				return function () {
-					var language = button.data( 'language' );
+					var selectedLang = button.data( 'language' );
 
-					if ( language !== $.ime.preferences.getLanguage() ) {
+					if ( selectedLang !== $.ime.preferences.getLanguage() ) {
 						inputSettings.markDirty();
-						$.ime.preferences.setLanguage( language );
+						$.ime.preferences.setLanguage( selectedLang );
 					}
 					// Mark the button selected
 					$( '.uls-ui-languages .mw-ui-button' ).removeClass( 'mw-ui-pressed' );
 					button.addClass( 'mw-ui-pressed' );
-					inputSettings.prepareInputmethods( language );
+					inputSettings.prepareInputmethods( selectedLang );
 				};
 			}
 

resources/js/ext.uls.interface.js

@@ -221,7 +221,7 @@
 	/**
 	 * Adds display and input settings to the ULS dialog after loading their code.
 	 *
-	 * @param {ULS} uls instance
+	 * @param {Object} uls The ULS instance
 	 * @return {jQuery.Promise}
 	 */
 	function loadDisplayAndInputSettings( uls ) {

tests/qunit/.eslintrc.json

@@ -1,6 +1,6 @@
 {
 	"extends": [
-		"wikimedia/qunit",
-		"../../.eslintrc.json"
+		"../../resources/js/.eslintrc.json",
+		"wikimedia/qunit"
 	]
 }

tests/qunit/ext.uls.tests.js

@@ -23,7 +23,7 @@
 	QUnit.module( 'ext.uls', QUnit.newMwEnvironment() );
 
 	QUnit.test( 'Initial check', function ( assert ) {
-		assert.ok( $.fn.uls, '$.fn.uls is defined' );
+		assert.strictEqual( typeof $.fn.uls, 'function', '$.fn.uls is defined' );
 	} );
 
 	QUnit.test( 'Custom langdb', function ( assert ) {
@@ -60,7 +60,7 @@
 
 		done = assert.async();
 		prefs.save( function ( successSave ) {
-			assert.ok( successSave, 'Options saving API did not produce an error.' );
+			assert.true( successSave, 'Options saving API did not produce an error.' );
 			// Delete old options
 			prefs.set( prefName, undefined );
 			prefs.save( function () {
@@ -85,7 +85,7 @@
 				break;
 			}
 		}
-		assert.ok(
+		assert.true(
 			foundTagalog,
 			'Tagalog is one of the languages presented to users in the Philippines.'
 		);